From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7F2746A63 for ; Thu, 26 Jun 2025 14:08:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C198E402A3; Thu, 26 Jun 2025 14:08:13 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2054.outbound.protection.outlook.com [40.107.244.54]) by mails.dpdk.org (Postfix) with ESMTP id 0B470402A3 for ; Thu, 26 Jun 2025 14:08:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JcdRjsjsCdo2ddVJbzTjKLxyK/3N5CxGl9mBazWWWEjy+6eFQMiI8UWQ0oLjUoOUnxzUQVDFxPTP/avY+lYudN6KRJcuKQzEouWZ6c9Or3xRbX3SCc+X1N18QQDycswhtM5gZuSkqLsN7JEFW3+P0BRCtNpPNxywlImhhcxBMP3324smzIdyQC1vvTU4T9ulR2w7zVlGuI5e3qX/tOh+K9Z1MhMC1T/AMOg8zM2urCDTl/mGeJZcY7dPPD/HDCtHulb8NbruGqseg8/hFKZdais548AAOVHZ0JOUsVp6TtDQVlg3Cm/Boi/Mia/ZrsHEWr5MdMt+R5Z3JapuOiH5VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tu5QmrCvlxD+8EFmnBPgziV1S0fsgVIzd0jBwLMnh40=; b=vjSwDXwNRANPZDVI14F3cDc6UXaeINFSL3sJbddCMTYSAqcfVRQsOulDieVJyoMrAELAixGjn7H3R9sxM76y2SMdNfqiz4ZptNQwodjJZ40M/VRYFAiB3MhxOsMuUvTpDgQ17NDev3d1cK/sjg4zWszmZ7HUGhpjkHyxp1TigUsg3Q4SShzMdvc+i1pV4Gsz536LQiQipJgNb8bK8T9cr/5FtD3JIwNZb5XQeZtgQ7Rpk7vo7YsI5WxfN8cte12l5B8RpnZY/BLqmrrPMslNdCfkn6CxDUUcyXpSzrOq1obPJI2b9f5gXKTOVBQIPCjcErrxsunaW6LjJUN9ZnQ++g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tu5QmrCvlxD+8EFmnBPgziV1S0fsgVIzd0jBwLMnh40=; b=n8d4ZnOBlQxLFZKFMc1c0+2rUXJ9BWCAwm/iPA0Cf7OekWP8NR3J9WcL+FxpcKaCme4GxQPuVcMM8njvPhP2bM7qlrm3jWDN5lryl9PPnL8Tu0gQEb7ny3OmCWv1oBM2xvW3tDZJHPIZrXGgZN5Q7JWm+eU3Xl8N1oTA3ELX7U2MlAOoy7DJEY5+bynPDtVFnZnAtrYObK+Sr6LepJfJ5fc+3Ex944Av8aoy5C0PyDXQJ2f5VvaVDXKR6P7Jo1DThfYOhtj9XTxWF5pMb/O2TAYOWkx7rcsfwBM3FgeT4ZF5njpIOJoC42UtaUJ3DzFKheD7Pu9DmMh6xwg3XLpNnQ== Received: from SJ0PR03CA0181.namprd03.prod.outlook.com (2603:10b6:a03:2ef::6) by BY5PR12MB4146.namprd12.prod.outlook.com (2603:10b6:a03:20d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.16; Thu, 26 Jun 2025 12:08:09 +0000 Received: from SJ5PEPF000001D7.namprd05.prod.outlook.com (2603:10b6:a03:2ef:cafe::48) by SJ0PR03CA0181.outlook.office365.com (2603:10b6:a03:2ef::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.21 via Frontend Transport; Thu, 26 Jun 2025 12:08:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001D7.mail.protection.outlook.com (10.167.242.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:08:09 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:07:56 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:07:54 -0700 From: Xueming Li To: Radu Nicolau CC: Xueming Li , Akhil Goyal , "dpdk stable" Subject: patch 'crypto/virtio: fix driver cleanup' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:01:28 +0800 Message-ID: <20250626120145.27369-69-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D7:EE_|BY5PR12MB4146:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b774bd6-fcf5-4c78-1ffd-08ddb4aa1e21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?dsJ3P/wXkI/lOl0T4opighFqcQJvbiy6AcLeWk7zKBVWHOqPsliKn5TOteaY?= =?us-ascii?Q?34iYQ4ABvfYn0082OuLug1ftm4BG5Xejeh2LRjSh/FuYpwoGUMcpZcA08x7b?= =?us-ascii?Q?tcjlDOkGlCETHbzdcrzJ/qsRtQB9TKNn1X+hESIANVzC+KUkEPnm2kaIv9hj?= =?us-ascii?Q?/ko+jqAKyCHaWnRzd5Ak5wcpwgSIftGLolnZC8PPBeOD/pI4jmKyEtvSh/UB?= =?us-ascii?Q?Fdisgoqlq6fJ7Uz6ur5H71lSFt/Lry9MfXuZnpOzAtXVTHRzSp7y/5TDECYn?= =?us-ascii?Q?0T6sojSPutahp4s7hEbe6e6Il2MxTjmrXf7uQRDrr5LK7YBQrId4dXCqzErq?= =?us-ascii?Q?P2hpZBcN0sH2/zRw5yoyVNMAsWGi8PVgmtQgEPlQbXU+age5n4q4Wii71FhG?= =?us-ascii?Q?A+OnuC+eFpZFR/SCtma1yz1rBzriQ1++s/VYTyNvz7K2T2UX+Jn54ahIuKV2?= =?us-ascii?Q?iqMj4V3k0nmN86OjZN0kYZoOYnxLi5TPjvExa+RiICWQZKVBEtYZKVtrJVX/?= =?us-ascii?Q?9TUO+st7/vgsO2OYQ1dE1F3PCmd9yYWfu0yFGnDnvlXq722tdY8JvDaR+VQA?= =?us-ascii?Q?nHihRLrAkSM4sOB6z0KTh1RMzxJGPFdrqWI0PtGH2QpHTeQTJNMgSMl5WkX5?= =?us-ascii?Q?uZlcp8I3S5fhOZFl8mF03pDOKbbMyFR+NqlVOwpgl+JJ0M+dX6nSuqjlDDa3?= =?us-ascii?Q?pHcUMKf9nIwVMx2kMwgCSExgHj3XJjEW9zng+v+iNt7IaWRk0ROeze1QfUwF?= =?us-ascii?Q?ibk2jI8W27C9slquVfjizESqIFY1q9f+Vhks90oAZ5YFWwC8GsuQwqNWSaCg?= =?us-ascii?Q?mMQb+TuSA0X7rcSguHFO+C4grQihQfB80w8/UAJBhq560p+W+7Jo0wyICl8A?= =?us-ascii?Q?wxe5+JRD2huGzVTQJw0g/7sQNVbeQEEyjVuDpZ94lfinjK8wdwk0+FIQ+hn1?= =?us-ascii?Q?FVLOQnRnZawE9Ijm0LIzsCsB3OLjVHwokqodHrVJGKYNmqpnXAdMOIAyvNeZ?= =?us-ascii?Q?Ol2rJq4jb3H4IaShVurxOJ/JvLpxwwtE7rN42MtcEVYa8Ci305rU0+MeCpfs?= =?us-ascii?Q?pxMhgTvjwwsjIs+K2H2/83Ujlu+0WGeGAdYwbBD8taN+u9PFEBg7XjKJ1nQG?= =?us-ascii?Q?XiynpX0H5zpX/JI+boVvOTl8i0nCW4uGkRX1lEz8jHx0HDUSXjA/k0bpPHoy?= =?us-ascii?Q?65TyPMINsReqTkZgt1Yn2T8eyTLS/VcSE/ZfKZ5wssMZeCTuxmZFDMYcyn1m?= =?us-ascii?Q?bu1eEHpAzFP+ts34rfx08LzbTBBqsdzcLVp1zbjf1O6yd+JNdIopIN7SoxKH?= =?us-ascii?Q?wGxjhJJmQmQs38f/Ra4oIEQZswItnO1kSYHt7kV/I7CNiJC9AC012rfokX+B?= =?us-ascii?Q?3loiuLGcZRI3GxqZVr7WQXASMa4ecjhRtJmPE1N8hIuEHRG+WdZGP54nRIPG?= =?us-ascii?Q?21JSnnDwRR4R/eUtfI0DQB//vsRGTuok/6Ir2IMKR1xXQOVpu9MJVnFnIwlr?= =?us-ascii?Q?6PzwF4iAK0AtdAYeR0rsBflqYlXu6MQ9+mZ4E+lcO3VwVOiWP12f4KxDLQ?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:08:09.9118 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b774bd6-fcf5-4c78-1ffd-08ddb4aa1e21 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4146 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=d9ed369aa2b3f96f22f72f6878f49e77fc8b0f16 Thanks. Xueming Li --- >From d9ed369aa2b3f96f22f72f6878f49e77fc8b0f16 Mon Sep 17 00:00:00 2001 From: Radu Nicolau Date: Thu, 29 May 2025 11:45:53 +0000 Subject: [PATCH] crypto/virtio: fix driver cleanup Cc: Xueming Li [ upstream commit 6adb7f4ae156341958463db80951d8f528932e9f ] Improper cleanup resulted in a segfault when more than 1 device was used Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD ops") Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal --- drivers/crypto/virtio/virtio_cryptodev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c index 332e109876..d99b53b2ef 100644 --- a/drivers/crypto/virtio/virtio_cryptodev.c +++ b/drivers/crypto/virtio/virtio_cryptodev.c @@ -779,8 +779,7 @@ virtio_crypto_dev_uninit(struct rte_cryptodev *cryptodev) cryptodev->enqueue_burst = NULL; cryptodev->dequeue_burst = NULL; - rte_free(cryptodev->data); - cryptodev->data = NULL; + rte_cryptodev_pmd_release_device(cryptodev); VIRTIO_CRYPTO_DRV_LOG_INFO("dev_uninit completed"); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:20.334099721 +0800 +++ 0068-crypto-virtio-fix-driver-cleanup.patch 2025-06-26 19:59:17.470418040 +0800 @@ -1 +1 @@ -From 6adb7f4ae156341958463db80951d8f528932e9f Mon Sep 17 00:00:00 2001 +From d9ed369aa2b3f96f22f72f6878f49e77fc8b0f16 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 6adb7f4ae156341958463db80951d8f528932e9f ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index f591cf0c7a..299898e585 100644 +index 332e109876..d99b53b2ef 100644 @@ -22 +24 @@ -@@ -625,8 +625,7 @@ virtio_crypto_dev_uninit(struct rte_cryptodev *cryptodev) +@@ -779,8 +779,7 @@ virtio_crypto_dev_uninit(struct rte_cryptodev *cryptodev)