From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA18046A63 for ; Thu, 26 Jun 2025 14:08:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B10DF402DC; Thu, 26 Jun 2025 14:08:45 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2063.outbound.protection.outlook.com [40.107.94.63]) by mails.dpdk.org (Postfix) with ESMTP id 4A93A4026B for ; Thu, 26 Jun 2025 14:08:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xV73zGgIF58VTjvnmh1R0Zg2b/2ljmhtrHhQ/EnyqsZ/H2uUYwPSiFyA2vosDwyLcBWYsdAn7Utqr5H3IqKKEut3Zv5H16yviJX2CpQMZfbh9iUapaAhXPPbgUFipgtRQQZGddmWTNdjd52/mjT1qfZleoKs12O/fykCvv+nrYWQdtH4mvlIXkgafDZJWxriMslvuqV9kTlQOrz/xg85SS7iFdcXURLp3jpn6bs4Vp7ldY2SSoTzLSyTFDBK2RwLcu65PywSMq0m8YAd8ZbxpckgJMC4mUb2//4kY/DKypOanZDGVbvbnnFW6FH81Jm6XBjIFNDEzJGF2ifeNT82xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VqqyzeVWOAszk2iQuyTOLC+mlJkFGkT6B6ERuOzwFdI=; b=eIosFC+AWZZUUceeKjr5kG7fF/p8pDF7vl1Y6uxWV/IgMCkwCkqO9lVSPJjYnZixhpWDi1B6bZgf5WFpQSy/pwnsFVl4PaDdn+yT1toUrJVZnmf0RKQVr4kotQpbQQLI2idBeJiE65HOUchqVtJ50ORUsxmS1i+8Ip6UsicHkx8x/2cr7u1D9XikawlBRkkSVM9Y1/YZ/HsKQGCysE0qTZI+cWocztS8FTVCmRA4pfeHIETyGJBOLj4MT+0bVSSErKeVJQR6/3Z5fYDSmCLYNyOi7VbDBUMufzxhzX8aJpLXB/ZNr54r2t3oA+uE+6zWRl2RhRdHSV5exO7q5VxZFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=jaguarmicro.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VqqyzeVWOAszk2iQuyTOLC+mlJkFGkT6B6ERuOzwFdI=; b=gQSBOJICj35osaKbBERguTwulI9WmV5jNcFINIUSbl8ipT2bb67KEBPcGq+QXiiYpyXTwPV34f2c1y8kb+maiGDHzkNPp0AtCcZPfG/reMlUgih+37V7p4n2hb0lEMj5ySbZqnNU1Q2+i4mGJW2Uo7xu+2UFzWWKNgW4hpTEqyJcydFqZLVit4zYx5fqcJiIYbOvdiHK+4MVwbmqBaagng3Vup75oZDF3p1MyKsQDYJBpDzlrsvnRxatghfP7SMEQ9EhUlFog+WjcB59YwTbalMZW2hnl6GCwY4tq9avj7ZhGH5LWV3ilkmDLk11eNVpCQBG3lzdhWynPDKyIdGF5g== Received: from DS7PR03CA0208.namprd03.prod.outlook.com (2603:10b6:5:3b6::33) by CH2PR12MB4056.namprd12.prod.outlook.com (2603:10b6:610:a5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.29; Thu, 26 Jun 2025 12:08:38 +0000 Received: from DS2PEPF00003441.namprd04.prod.outlook.com (2603:10b6:5:3b6:cafe::3a) by DS7PR03CA0208.outlook.office365.com (2603:10b6:5:3b6::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.17 via Frontend Transport; Thu, 26 Jun 2025 12:08:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS2PEPF00003441.mail.protection.outlook.com (10.167.17.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:08:37 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:08:17 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:08:15 -0700 From: Xueming Li To: Sunyang Wu CC: Xueming Li , =?UTF-8?q?Morten=20Br=C3=B8rup?= , dpdk stable Subject: patch 'ethdev: keep promiscuous/allmulti value before disabling' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:01:30 +0800 Message-ID: <20250626120145.27369-71-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003441:EE_|CH2PR12MB4056:EE_ X-MS-Office365-Filtering-Correlation-Id: 017321ee-a829-4345-2f93-08ddb4aa2ef0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|376014|1800799024|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?d1VhSG91Ujlaa1g2R242Q0xxdSsvN29yamM5aEVoSDJBd3lwZmE1ekozYWh3?= =?utf-8?B?dE5iM3FjM0VjZTJ2cmFyRmE0S2NoRUowVXJJb01xaFBwL3BrMjVDZEhQY0Fa?= =?utf-8?B?SUpIVkxVUnZmK3N0VHB4VXpDYUZ4emQ2Rk5HclAzZGdTUlRtc1lyZENST0R4?= =?utf-8?B?ZEJ1MDEwYzFhMlhCU1YrZWswcThJUzVKTDIyNVUwVnpkeGFGOVVLbVp2ejVx?= =?utf-8?B?YlVVRXVZVlFBcDRTVnBsS1BYVEdQdDBWNEUzNHM1MlBXYUgxRVNCNTUxNCt3?= =?utf-8?B?RCtRUkFqVnVKNGlBWWxHbGJmMzdOdkc5QXpTY3BWUzc1RWlFV0VlY0dlRk9O?= =?utf-8?B?M1JhR0w5MmlsUEdnVEVwVjBIaGRTSWswV0FoUWJPTGZub3Zwb3ZraXk3ZmtV?= =?utf-8?B?bTN6ZS9ZQUNxSTd5VTlQZy80TmI1UTVVSmdMQUVWOGxkWDVzRE52TkFDTGJG?= =?utf-8?B?TzdzOFh5N3FsemwzWWd3UWdVZ2krYkJ3bFhSNXZlYTNRNWI2S1RVMk16a2g1?= =?utf-8?B?MWtpa0UzclhKSWpGdXkyZUdaK3lMZDN4S29mTjkzZFVYNExvTVVVWVZEcTU1?= =?utf-8?B?QWNmSmM2UGZqekhnNExTM1ZSb0ZTOWJxbG8zMkZaTmJOR2I0VldBK2FGWldt?= =?utf-8?B?aHNMNzdzU29MK0xZbmtSTkRoL0hTV0FIOEI0bDA0cndJYjNhUkIwRjNldVJN?= =?utf-8?B?aTF4YXRIeWxCVElKYzN6VDIxTE1Bd2ZvRmMyMWF1UkEwMmhyOHVCQkRKQ3hh?= =?utf-8?B?SU1EQzlxTEJUb0FFQ1RTOUVEV3VpZGhyOGNjb01mZSt3a1NTNWRLWGJpek1i?= =?utf-8?B?TGd1T1dWcjBHNm9ybWMwa2V3a3pFcW14MWpoYnJ4Q1BvWFdQcXR6ZkJCVXAx?= =?utf-8?B?ZTlmNEV2bEZSMThpbVdOOTQzZGtkaGVObE55TE41bVVhRmZHTURPQk1RMGFL?= =?utf-8?B?VlNObHZvSk44QWtyY0grOXllYSt2RW55TVBSOXgwYlgza1BIczhkanUrdy9u?= =?utf-8?B?U1VyWitrNHlnZVhWMDN1YlF5L3M2YkQzRm81NUhZaStnQjUxY0tmcVg1WFRl?= =?utf-8?B?M2xSRjd4cUg4N3Y2UGxqQVR1TVA1d0p4Smt1US9yclhKdmpRVEhCaVlrNmxF?= =?utf-8?B?bmsyVmNhR2VrRVdwTFB0a1E3cG5YQzJSSDZKYjhhQ3Vya2lvb253QTVLS3FK?= =?utf-8?B?NHBJUGVNcjF3SHZMOUx6N0NubzBLNnZvOFBiVUhFQ056NEQ2YlZwNUYwYVh4?= =?utf-8?B?eElWOFFzTTJ1WVpBdVFoQmJscVlWMUo3M29LY3MycnRqbm9SZGs1NWg5eTZR?= =?utf-8?B?UVdLWWw5Z1ZNUTRqYis4MWV4TDRXcEcxYXVyUHV0RG1UbDRJcmVEa1dIRzhQ?= =?utf-8?B?d2lQTjl2ZGc1aU9vWnBhYy9IUXJlZHZ5TW9zaUtFdWVSVDIxSEUyWDdMaFNS?= =?utf-8?B?MXVkQVZzRngwc29PZFdieHJMdTkvc3dwMVZoZDNaam9DTHlVQm1DM0lWc0RI?= =?utf-8?B?QTc1aXNybFhUQm80M1ZnWEhlRTdlRzJLaUI3NC9pbmE1Y0tjQ1h3TXBvMWVo?= =?utf-8?B?bWhrQmJxRW03Q3NGd2lpR0Q3bTN6MTFKL2M1Wno2WEIwQ2d0Y3dKOVJpTU0y?= =?utf-8?B?MmRVN1QyajgwUjUvdGw0MTd4OE5yTkI3a2xmTkZ6TGVhenpTMXlsNi8wN2NR?= =?utf-8?B?UnFaVVRyK1pXLy84R2FLMHpZWThKSkhKUmtCK0V0TitLdG84amdNTnl5TTMx?= =?utf-8?B?czljci9ZTGlHSDNSOGVhM1Z5VjZBTlZNK2hzY05EOVNFMWpDSzh4WlhlUW9p?= =?utf-8?B?R0I0L2JYQmRGeGVUYmdNbXA3d1JhcGlhaVJWbTlVL3liam1IbkJadzhVem1K?= =?utf-8?B?Tjd2eVhjM0lwandUL0xhSXlTVXNURjZZeVV3ZGE3eWxSQ1RBYWllMUQ0eGZu?= =?utf-8?B?djNaY3dHbWI0Y0dnWTVPR3BQeUFKS1VZbWp2YkNLa3FRZ0ROTGR3d3ZobXI0?= =?utf-8?B?YUV5WDdrNGczSmJHUFZ6NCtiZStDTTluNTEwaStnNk4waE0wOThlT054WDlN?= =?utf-8?B?aC9yQnl6V3pKRnRkaE5BWVc0b0plWHpXRWdXUT09?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:08:37.9928 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 017321ee-a829-4345-2f93-08ddb4aa2ef0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003441.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4056 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=aad19713c88057e2d0a1b636a615a5c42fdee439 Thanks. Xueming Li --- >From aad19713c88057e2d0a1b636a615a5c42fdee439 Mon Sep 17 00:00:00 2001 From: Sunyang Wu Date: Thu, 22 May 2025 15:42:42 +0800 Subject: [PATCH] ethdev: keep promiscuous/allmulti value before disabling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 00add16978762a8bcd98cd9465503194dc4c1e9a ] The values were reset to 0 before calling the driver function for disabling promiscuous or allmulticast, which could lead the driver to skip disabling. The values of the promiscuous and allmulticast variables are set after calling the driver, according to the return value. Fixes: af75078fece3 ("first public release") Signed-off-by: Sunyang Wu Signed-off-by: Morten Brørup --- lib/ethdev/rte_ethdev.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 86fd457f78..704fc3eae2 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -2891,10 +2891,9 @@ rte_eth_promiscuous_disable(uint16_t port_id) if (*dev->dev_ops->promiscuous_disable == NULL) return -ENOTSUP; - dev->data->promiscuous = 0; diag = (*dev->dev_ops->promiscuous_disable)(dev); - if (diag != 0) - dev->data->promiscuous = 1; + if (diag == 0) + dev->data->promiscuous = 0; diag = eth_err(port_id, diag); @@ -2956,10 +2955,10 @@ rte_eth_allmulticast_disable(uint16_t port_id) if (*dev->dev_ops->allmulticast_disable == NULL) return -ENOTSUP; - dev->data->all_multicast = 0; + diag = (*dev->dev_ops->allmulticast_disable)(dev); - if (diag != 0) - dev->data->all_multicast = 1; + if (diag == 0) + dev->data->all_multicast = 0; diag = eth_err(port_id, diag); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:20.405382318 +0800 +++ 0070-ethdev-keep-promiscuous-allmulti-value-before-disabl.patch 2025-06-26 19:59:17.478418040 +0800 @@ -1 +1 @@ -From 00add16978762a8bcd98cd9465503194dc4c1e9a Mon Sep 17 00:00:00 2001 +From aad19713c88057e2d0a1b636a615a5c42fdee439 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 00add16978762a8bcd98cd9465503194dc4c1e9a ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org @@ -26 +28 @@ -index d4197322a0..dd7c00bc94 100644 +index 86fd457f78..704fc3eae2 100644 @@ -29,2 +31,2 @@ -@@ -3044,10 +3044,9 @@ rte_eth_promiscuous_disable(uint16_t port_id) - if (dev->dev_ops->promiscuous_disable == NULL) +@@ -2891,10 +2891,9 @@ rte_eth_promiscuous_disable(uint16_t port_id) + if (*dev->dev_ops->promiscuous_disable == NULL) @@ -34 +36 @@ - diag = dev->dev_ops->promiscuous_disable(dev); + diag = (*dev->dev_ops->promiscuous_disable)(dev); @@ -42 +44 @@ -@@ -3112,10 +3111,10 @@ rte_eth_allmulticast_disable(uint16_t port_id) +@@ -2956,10 +2955,10 @@ rte_eth_allmulticast_disable(uint16_t port_id) @@ -44 +46 @@ - if (dev->dev_ops->allmulticast_disable == NULL) + if (*dev->dev_ops->allmulticast_disable == NULL) @@ -48 +50 @@ - diag = dev->dev_ops->allmulticast_disable(dev); + diag = (*dev->dev_ops->allmulticast_disable)(dev);