From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5594446A63 for ; Thu, 26 Jun 2025 14:08:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EE8E4026B; Thu, 26 Jun 2025 14:08:41 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2078.outbound.protection.outlook.com [40.107.96.78]) by mails.dpdk.org (Postfix) with ESMTP id 23541400D6 for ; Thu, 26 Jun 2025 14:08:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R6zSargu7VkCzIpNNWdjk6seOExFVNCt5l7Cd0I2Ub8rd64PVynB7pTNclpGVppWeficM/eRtx1ecgRHT9qdfVvmbE7dpo9YbpR8KI7LR18UYPTXf+NIcl4sBlpftn3xFQzbUwXT/NEBRarNzUF/mBq4fOr5Tnjt9W3j6WozbnuY2GKM3YUh16wWXX7WRL0Lbn8rgiI+RfYIfoGbrms1nilUoCqOKwtvJWZc7D7vkV9XWi2GNqacadIXksFNsAHnPbjuUc1mEWsH5Ue6hkKMZqWw/aZwgiVDI9rDazkK7udHx5FKweT4tZPL/afuUStnjRsC65AZ1X/J7s3ESV0Ixg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yUcpHFLD6xnah1KHAXLsT07v254D/PhfkIMP/Q2GiNM=; b=wxLS3gk76LT1pZcGN8c/CYGeKVne6P+RJyEVphKnQLpcMrBK8z3Y9l4lVdNDvaCqkA3B8JKN4+RWV8cawCMpG2B14ROJlbFNumCb9A7UTev7f81pJmM48JecCqvo4z/M8NxhCHqnEFPsg7mr2JOJ09Av0dsUqK9hbqGfTBHIVwnZjK9spyxnUmlC4CwaDR3LiBZDekz1uPEs0j0Ytu8gpRpgw9MGqRrNzfCQujohSwOj/k+PXLmSaxUhSYeEN0hODTLdXTueMXERoPNyVj3sEvezv/Tg8+3nbRxb0/ZsK95C351uQ1323IcvgsIMcKxi1ISl+qe8NkZaP/Vr/rwkIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yUcpHFLD6xnah1KHAXLsT07v254D/PhfkIMP/Q2GiNM=; b=B5s6NmFMURKcLi6rXPtE9NZ7JlxqLIBeVWL+d3B4SoV2t15JF0Q8Ontqe60DXZ8zXHLgBgIEKaSJAfw7KAGmJEwl+xedohVCKBfYO0cwP5LM5W36yRZivA7cAOj2XwG1ap3JFASuwbMkm9pQ/Sv6QL/zaeWWeSWD1egj6x8l1SgoY8mAhTh7JayaQtSHRG3PhYZxG7zjsyDr1wwWJJL/0h8Td24tNYHCHY1OlFeLaKc6K2Tj734qJl8EtjcRqiLLHpT6pJGzowswHIp5l3RKZ2GwfVRCwiEhQs2sNeC+mAho6Xg4/KRltbKI5TUpc3Uf3kWETR+cBxTNztfntLpHyw== Received: from BYAPR02CA0056.namprd02.prod.outlook.com (2603:10b6:a03:54::33) by DS0PR12MB8765.namprd12.prod.outlook.com (2603:10b6:8:14e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.30; Thu, 26 Jun 2025 12:08:36 +0000 Received: from SJ5PEPF000001D5.namprd05.prod.outlook.com (2603:10b6:a03:54:cafe::5c) by BYAPR02CA0056.outlook.office365.com (2603:10b6:a03:54::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.17 via Frontend Transport; Thu, 26 Jun 2025 12:08:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001D5.mail.protection.outlook.com (10.167.242.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:08:35 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:08:20 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:08:18 -0700 From: Xueming Li To: Pavan Nikhilesh CC: Xueming Li , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Konstantin Ananyev , dpdk stable Subject: patch 'eal: fix return value of lcore role' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:01:31 +0800 Message-ID: <20250626120145.27369-72-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D5:EE_|DS0PR12MB8765:EE_ X-MS-Office365-Filtering-Correlation-Id: b13250b4-6b8c-4431-ba14-08ddb4aa2d68 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SVF6RWVELzNwNlJ0NllKUDdCNWtqSTNtVkJMTVJqeE4vZTVod0hHMzNKN0Fm?= =?utf-8?B?TklkVHdNTEtiN1lRa0RLdVdPMytKRHQvaHlDOVBPNWthcXQyQnRaSnM5UGVN?= =?utf-8?B?R1QvVW82Y2NST0d0ZHhJejE1ampuQ1FWTUJleXRFakFGNWw2ajRDZjloa0c2?= =?utf-8?B?V0YzdWNUMjllVDBJQW4vcEEyc2VRME9XVUdsNzlFT0N6bUxKOVhNOVQ3RnFS?= =?utf-8?B?elRocjNKNFo2U3RQSFVDZ2pXdFRhbHAvYS9EMUwxRmtNamFxaGVzL2w4L0tq?= =?utf-8?B?d2dqYzFxcysxbmVHNVBTWW4xSWdhVzhYaThJZTZrcjdHcTAzTGp0Y3g4eWdQ?= =?utf-8?B?NERaWUhrRHZTMWJOZGxVK1dTcVkzNWVPRE9JVTRIeThsbkdnTXE2bUxjVmR6?= =?utf-8?B?Z20zR2dRY0ZXRXVrRlh2aTNUUjdXbXBQQWh1K1hQaTdSVG9aL1kzRk9zc3Iw?= =?utf-8?B?NXlCc0NCWUlhQmo3eVhubDZ5OTZHQWJTbG9mNjB0VXBNVlRWNm9Pek9KclNk?= =?utf-8?B?THlnTWI1YU0rdTRhQ1k2YjQ1bS8xTEZwTU5zVnZCMEdrVm5WZ3l6MmxFbmxW?= =?utf-8?B?blNSc2tMSmhoRWZhWjR0eXVaaEkvWjRyQ2VteGxqbTBVeWRUazQ0dFdJRHND?= =?utf-8?B?NW9PdzE4N3BGNEJlUFJUWW9nYXFQNDM0Y2t3OWhmMjBjb3N4UUdGYUF1dm9E?= =?utf-8?B?M3creDRqQlBXSjNTWkhDdFZMM0hReXFGNFRtQ3ZtQXg2UDIrSkZWa1pSTVYr?= =?utf-8?B?VjU4dUZBN2REQ0NqaFdGRnY5L0RCOXlKVktsVHJsQ2p1NmVYSzZCR1lncmgz?= =?utf-8?B?ZS80enU4cUc0S0FUakIwK0pMNXN3LzdVZklzUUltdGthQ0taY2gvVENrMjdX?= =?utf-8?B?ZUR3ZDJBZEpOU2tSbmtNa2tUeVR3T1d3dkQ2UmxMWlZuazFVU2xPV0Vwc3BR?= =?utf-8?B?eFZaemdKTTQrMEJ2OHVMLzFBY0NVeUV0a2N1RmRjbHUyOFY5djRKV1AzVVJZ?= =?utf-8?B?SVJzbzVXSzhPSElCRkxqODFKcDlzZE92cTdJNC9PNHFZV1ljWDZsUUwzZERl?= =?utf-8?B?emZLeFpaMGpFRWpNdzF5ZXZTKy9RczZCbU92NktRaDRsTnRxekRrdjRobGZ5?= =?utf-8?B?dUpQOTB5K3NkUDZTSXo3c1NvVGdNV0xqcFYyMEFGWTJGQS9QbHcxOFlzSXh3?= =?utf-8?B?alM4MWtnU3dRNmd4RUxRd3lhR3llR2wxVWF6dGxKc004RFk4bGxOaDFYbDdi?= =?utf-8?B?K2NSQ3VXMWNYR0htVit4b0pSaGV2Vzg1QnRYVm1ZblJVZkp4dzRIcmZaSzg2?= =?utf-8?B?M2tmVzhDdGNvQ29wSlhhVTBUcmZ1Qm1maDArZDdZRWFsUVZYT3o4YW5jK2h4?= =?utf-8?B?SWZwcSsxOHowVk9ES0NUN0JaM3RFSm8yUCtXN2lNaCt1NkxTSkxpd3JrZG4y?= =?utf-8?B?L1d5ZlhsMUdNcVFkUmRWOXZ5bDJNKzQ0ei94eTBiMThDd1VERlZtaERpSG55?= =?utf-8?B?Tzd3UGVpZzB0V0hTS2tiWlplQnFCa3FnU2hhQk9qdUg1OUoxRVdCNzhWd3p4?= =?utf-8?B?cUtOUFpSTFQ0eDUzVmdVRzFOcTdjOGRVRHVmNDFEcmMxYVFGMHZ0bWNYSDRq?= =?utf-8?B?bjNhb2lxSHhMejc4ZVpXZTFmaU96eSsrY3dwK3FKVjFUZ1pnanBCVW5JL09D?= =?utf-8?B?VHhxckQvY2xnNVJ2MVdVZnYwbzNqcnpkVjh0cFR0VVVpMkZoK1RRdWYvR3Ex?= =?utf-8?B?OGhOQ3dDdDAyK3lXamJ4WGppVFhwNS9BdDZrTFkxdzFQMnZrZjNhRk92Uzcy?= =?utf-8?B?VUtDanBEMDhVSGVLcEU1bGpCeHp6T2J5WnBmTXlBMitTVFRhMTRMUExqOXNW?= =?utf-8?B?OFV6cVNqdUlrc0oyOVdTTWdJNnp0VDB0RTJKUWhWdTRNN0FSeEpmVlI5R0RZ?= =?utf-8?B?L1h4NURubzRpci9xN0ZVMld3SVEzUEdDYmFka0pPQVl6MjZQR0FZVjRWSlFI?= =?utf-8?B?NnBycFdLbHpqdDRCckRCczZONGsyUVcxd3A5UXVZaWhSMjBEVUhlWTIzeDFI?= =?utf-8?B?WnVhdEpKSy9GK3d5cVNvRXF4SWw5MWsxNWJiZz09?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:08:35.5113 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b13250b4-6b8c-4431-ba14-08ddb4aa2d68 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8765 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=2c14d75f3b5a0833b63307b5f690e818a13a5595 Thanks. Xueming Li --- >From 2c14d75f3b5a0833b63307b5f690e818a13a5595 Mon Sep 17 00:00:00 2001 From: Pavan Nikhilesh Date: Wed, 21 May 2025 01:47:26 +0530 Subject: [PATCH] eal: fix return value of lcore role MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 65e03bc2f35109cb33ad4a6e244d5ea90e78fcde ] Update rte_lcore_has_role() to return false instead of a negative value for invalid lcore IDs, removing the need for callers to pre-validate the ID. Fixes: b0a1502a277c ("eal: make semantics of lcore role function more intuitive") Suggested-by: Morten Brørup Signed-off-by: Pavan Nikhilesh Reviewed-by: Morten Brørup Acked-by: Konstantin Ananyev --- lib/eal/common/eal_common_lcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c index 208e73b465..5c6378fa97 100644 --- a/lib/eal/common/eal_common_lcore.c +++ b/lib/eal/common/eal_common_lcore.c @@ -79,7 +79,7 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role) struct rte_config *cfg = rte_eal_get_configuration(); if (lcore_id >= RTE_MAX_LCORE) - return -EINVAL; + return 0; return cfg->lcore_role[lcore_id] == role; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:20.439903217 +0800 +++ 0071-eal-fix-return-value-of-lcore-role.patch 2025-06-26 19:59:17.478418040 +0800 @@ -1 +1 @@ -From 65e03bc2f35109cb33ad4a6e244d5ea90e78fcde Mon Sep 17 00:00:00 2001 +From 2c14d75f3b5a0833b63307b5f690e818a13a5595 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 65e03bc2f35109cb33ad4a6e244d5ea90e78fcde ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -25 +27 @@ -index 294267177d..9dd6c72055 100644 +index 208e73b465..5c6378fa97 100644 @@ -28 +30 @@ -@@ -87,7 +87,7 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role) +@@ -79,7 +79,7 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role)