From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7424D46A63 for ; Thu, 26 Jun 2025 14:08:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CF92400D6; Thu, 26 Jun 2025 14:08:42 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2062.outbound.protection.outlook.com [40.107.102.62]) by mails.dpdk.org (Postfix) with ESMTP id 319BF400D6 for ; Thu, 26 Jun 2025 14:08:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iCo9LYBcvswgfsm/SXBwNKKTIBa6AD/FvpHDoCaOACIVIUqtEtq0oClShUv61n4V5vRpTRd7KLmG5zAqRqMvrcGFxl0t2Eh1HKrOJ8UC6Cc/L2aAPtxkNdiCPvq6kOdWJT7NkgJ9XzKgvNQtaBpUc/5+xiFn89FUA1Dh5Sh9nyuSPZVSo9A22MYZgD1CY/GSKUdeGOhzYpemEM8cyYygPkvk8ggY8DllKW6Y/z+u/c1MqFCnMXyGED84uH3PpzOiEodR/g0yNfka8Z/U6M5JacdTxCBoU5XqMnbnIoq7EP/JZnR/56wlknIf959v+7aeLDqaStCogQigDphpeztuCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oYQBj57PXAJbzJQ4jAkI4THGehrwzFy+Yl+ftieMMhs=; b=UhPrXInTX3jq7oUbkiKTkR9RClHRpFNySGmWpO9URyEPKiGPUQG36hoiZIj0FYZsgyAMrSWNqblYK4umg7K8o93oTd6nyFKcc03UphCfg/fbGu9Y/jdliKp4e3COpQGCIvNvXnyMypCYizHEyRMWMtpbT39945VfFI84gF3O5S9o0uf4ItPLs9YU8+QXTziu5nlSPwD3asR7QZcZSoefpf3sNtrCJ15WCrTh7S9tc8TuSxut6gKKFkjb5678G8Ykd8BACLQGxeAAKvCsmELeXvhxs6T9o0uyosbuL4/wsySURBUhJ8AJAQMggPm7rrq3Y+uJ5dwwvZCsu1AT/HlKLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oYQBj57PXAJbzJQ4jAkI4THGehrwzFy+Yl+ftieMMhs=; b=Ran+9TYV98zn0M7NSGTuPahjxp9/FCX3TPBwRVaRujjhYGTRz8tJ1HESjiMwOlyX3AQYqXJrXvkx8DkS2maIJu1NtAYSWytwRbtwkMAxeKI2SwwEMN6ymzzRugSIxw+s5lbuxrt0sxDrtPV0FwMM3yDsdLs4+eEWSa+F6SbjiMdHA/mdUkyaZjbN7zzJlhftRmBKJMv9GFv+/VYlpsut45/TOXuEUtUUGKRx5q4uNtXFrDLLTZIBAbW52YDt9Oxxxfhn3bEpYLefP6SwLmOXe5FKMWINyHdtvnQn1KmJvmVYC3YfXg2iMeTfCb6DG5ek3GdnXGPq0UvhscdCCgdXCw== Received: from SJ0PR03CA0164.namprd03.prod.outlook.com (2603:10b6:a03:338::19) by DS2PR12MB9709.namprd12.prod.outlook.com (2603:10b6:8:276::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Thu, 26 Jun 2025 12:08:39 +0000 Received: from SJ5PEPF000001D3.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::82) by SJ0PR03CA0164.outlook.office365.com (2603:10b6:a03:338::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.17 via Frontend Transport; Thu, 26 Jun 2025 12:08:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001D3.mail.protection.outlook.com (10.167.242.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:08:38 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:08:22 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:08:20 -0700 From: Xueming Li To: David Marchand CC: Xueming Li , Anatoly Burakov , dpdk stable Subject: patch 'eal: warn if no lcore is available' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:01:32 +0800 Message-ID: <20250626120145.27369-73-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D3:EE_|DS2PR12MB9709:EE_ X-MS-Office365-Filtering-Correlation-Id: ce3323f8-0964-49fa-42f6-08ddb4aa2f50 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|36860700013|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xvwnKqzddNTRmA0V+L+JNGKnWvI1dwmknuTcH7i6/dUD9yYzW+wioduvHQC/?= =?us-ascii?Q?M6bBoOVHxEIhy1O2KD9OXV+tA01urgyoZvwBZpqtIiEIFrSd3+G+Y+/c3UzI?= =?us-ascii?Q?lK2UWUEt8ugDuiwHgndoa7p4mTgvA4svyfal/kfWWosUwphzJ/FBKrKPiUVx?= =?us-ascii?Q?2EDPeMKuXJWfb0W+Tf+r5hGRyVfJMKqnsPEglI8ra2w+SWTgGhWrakCnWsLO?= =?us-ascii?Q?CIF028fHeEQh1QwHMA8uqgnPsi+7DWXa2WGMXk2Niu3q2iTPl2VCxMqpJuF3?= =?us-ascii?Q?SdpadtXanfDfcOLQjBbgje7D0T3GblM9JMrcGnzWBeNPq9Xr14tQqovY3TTs?= =?us-ascii?Q?EmdR3sUKT1PlJ13mSNhKQe/6uwdQs2N0NS+R7dmpAgkVFgrmqqEfRGtGCuQ+?= =?us-ascii?Q?EYvWMTWrAwWKyDaO34Diywq3Li4y85gHPDJDI3OOdykcwJkw7tNjgI1ozYZE?= =?us-ascii?Q?ndhY2F3kw2FNsQc0ijfpdNooXwodi5+9kULURqua4DMEErVTcrIDwtXR9BK1?= =?us-ascii?Q?wBhPMNTxk6fEag+BNwVw7VsRdD51rgSCLhDgOgjej4BWuwfrMadJbJ6Ynpik?= =?us-ascii?Q?+QVtvZsSXKV8GXyDAxYWFu5KshyIHEkWzQTsifsp+MsU2h0Kvli7z2Mexqqj?= =?us-ascii?Q?7V4/7rFlvOo39euAyIRm9wIWAe+RilgjmmG8XaIR7u7g/ZzT35d8twKKODZU?= =?us-ascii?Q?6HaC+saVFlbEsrpcc9iGsK0gbrDSIpiMLMOoHnOyGtt14zN3I0QMDvINla/k?= =?us-ascii?Q?p01HSJGetDxYFkG+MoxB9hiXLJw4eecdev1ohzhrPJ6Z6DbHPcENk3zmvABj?= =?us-ascii?Q?4MMS8heaGNMo5JhkUCwQdcNUDjkmPVDVbMLHvXKGRYg1zPf956co5fX95V+C?= =?us-ascii?Q?KVWnb27U3JGYq97O/9ftvn8XEyQoIdiUdGoW5+Oce0mGs/5aDUU2g+m9Qliz?= =?us-ascii?Q?h1trjvNunH4Ql8D5zDzZ+OtHTVEsIbF5cv/j5JO8CY8RQta2CnSGnNgrwiwH?= =?us-ascii?Q?y7txXvGUDx1yYjY1sX9omI9zbjymoEE9DxACdWShK42W1hmJ39TZ/TzVTwGr?= =?us-ascii?Q?OvZ2N/ziNa7rUu58jw6vQOPJAWuE6eyowxEnrtVv7S/OYcnItlazbSs9VL/R?= =?us-ascii?Q?J7EfapM+ASu/CLO7JFl1JM3CpEl8Qhx399Zp3zxu3wzYrOCcbVqVEkztrOIK?= =?us-ascii?Q?+ciRJg3L9OOk95+J+oXwntickx9qZ5HE7nu3Zk10SSuUs5l4mLvJCQv62Bln?= =?us-ascii?Q?wHj8cCfzdDqyKyqVGXG6xz5Bf629Nw0lacqwom5lqe6eUntbERQ7L0evmFkk?= =?us-ascii?Q?/JfOj4YsNoHo0QbF3X+X+VSW3pKZCPSy+YXvCLAm9RBQoun3OieTTn9+mAGO?= =?us-ascii?Q?bmN7TOkhq1Mds3LMLSbF7mvkVofWKnkL+zdgoqX0qyvLi6pME7KZGHKo+Vo/?= =?us-ascii?Q?90bpq105GEj9DdOABuNpIySmTPWPcePJagNPwBIm3Tyl/O05+3YNQWCjucx9?= =?us-ascii?Q?lwONbu34Qp6SJ/yS4qnCO5sioC9E8xoBAx9zGNXUFH0tozgCLdkVXUJItQ?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:08:38.7088 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce3323f8-0964-49fa-42f6-08ddb4aa2f50 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D3.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS2PR12MB9709 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=78136965e47224fb44e6e26699aac1f03cc68e05 Thanks. Xueming Li --- >From 78136965e47224fb44e6e26699aac1f03cc68e05 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 8 May 2025 07:19:15 +0200 Subject: [PATCH] eal: warn if no lcore is available Cc: Xueming Li [ upstream commit 2ea1d30dc938866a983156473579d10bddb4951e ] On systems with more cpu than RTE_MAX_LCORE, starting DPDK with cores >= RTE_MAX_LCORE ends up with an ambiguous error log. Example with RTE_MAX_LCORE=8: $ taskset -c 8 ./build/app/dpdk-testpmd EAL: Detected CPU lcores: 8 EAL: Detected NUMA nodes: 1 EAL: Invalid 'command line' arguments. EAL: Error - exiting with code: 1 Cannot init EAL: Invalid argument Add a better hint to help the user. Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") Signed-off-by: David Marchand Acked-by: Anatoly Burakov --- lib/eal/common/eal_common_options.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index aec51736f2..110d95940d 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -2025,6 +2025,11 @@ eal_adjust_config(struct internal_config *internal_cfg) if (!core_parsed) eal_auto_detect_cores(cfg); + if (cfg->lcore_count == 0) { + RTE_LOG(ERR, EAL, "No detected lcore is enabled, please check the core list\n"); + return -1; + } + if (internal_conf->process_type == RTE_PROC_AUTO) internal_conf->process_type = eal_proc_type_detect(); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:20.467822615 +0800 +++ 0072-eal-warn-if-no-lcore-is-available.patch 2025-06-26 19:59:17.482418040 +0800 @@ -1 +1 @@ -From 2ea1d30dc938866a983156473579d10bddb4951e Mon Sep 17 00:00:00 2001 +From 78136965e47224fb44e6e26699aac1f03cc68e05 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 2ea1d30dc938866a983156473579d10bddb4951e ] @@ -20 +22,0 @@ -Cc: stable@dpdk.org @@ -29 +31 @@ -index b6fff7ec05..b194d0ee06 100644 +index aec51736f2..110d95940d 100644 @@ -32 +34 @@ -@@ -2052,6 +2052,11 @@ eal_adjust_config(struct internal_config *internal_cfg) +@@ -2025,6 +2025,11 @@ eal_adjust_config(struct internal_config *internal_cfg) @@ -37 +39 @@ -+ EAL_LOG(ERR, "No detected lcore is enabled, please check the core list"); ++ RTE_LOG(ERR, EAL, "No detected lcore is enabled, please check the core list\n");