From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFBAE46A63 for ; Thu, 26 Jun 2025 14:08:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9278400D6; Thu, 26 Jun 2025 14:08:50 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2054.outbound.protection.outlook.com [40.107.220.54]) by mails.dpdk.org (Postfix) with ESMTP id 3928B4026B for ; Thu, 26 Jun 2025 14:08:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hpULM4jujVagdkNuqf7liBJpKVZtqjJvN1I3JvphW2i/EsOaFkQ4+HX5pfDjQ9euP9DmShrNGiXoCQaS+uMMKUq0jTJlW8WpBDE2dCJRa6L6e1SavkhCJr2LRkKGaVn0Tg7DQ9ho48umQGCU/8+ZuSLcIaO+aJcgd+VnIscSfcvWoDYq4q1olW1b1phn929WZABfd/zLzwohIr8CHdoA5m+niVSZGOAg4yazjcDnlkVv/v1KEODeO5kUTU/Dg46/5li2JEghXXUEIDQ7Txnyopc4xPleVct2VBmRUCHQnqQsVXzpXn5GuLJ8Q4A/f1uIjKgdXvYtmL99TW8jHASsCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3E78IuxNGZFKOPsTKNGNwZnVV+SnoE7rHFxx4cmaIJ8=; b=NvG3PoYI1LEFpKxl1d0zfwX3DcJZwBgOFb4mcEGx1zKUNagiK0F+KwBZrs/ZLtH2beO97/zfn3SddL09N6B+xz/7yBAyrbfMR4g1Jz411P1gfBMB04QrjKYGvHwpxlB38KOcvqJe2pq7J6BLaAuxkMAeLOJ43djoOdgLJFNS2C3cHW6UtxZ1J3oMsiQilp/biLWZMvFzYCQirqv7NgeeZo8vTOJtD6wDv3IOfqYYcgKubYoj3UBc1GbvYKi5kxfOv2fooDW0yskSKecrL0ncBd97JmBFTxUdP9GLlfLVSJGADtfjQR6vEBfXgNC1sijjc5QgeaGDgCEtOHzRPfvOXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3E78IuxNGZFKOPsTKNGNwZnVV+SnoE7rHFxx4cmaIJ8=; b=KIw44feM8PGOQSM8dnL/1gCzK4Jc7QpGKDt+8TLlbGt+FP0NVAqhCeJVZX5MQqfqd5nWNnYgSUHb7808m5WnlQIx1i7m4hcZmIVsl57HNJi7pb7NAxdFrLpZM/epeoELuO85S1gcH07TvZW5hklnMtRpiuSj0wEav50Z7TZuGq+Our9mDe2HQuPNcI84i/S0Zi7BXQYwMhrJmk7W8brVfNuvzfP0STBN1EOSCWumhhqsNgNFwDSP4xjEzHDyhpII/x3bEEXFhgpoM1xq0PmxD9Rpwy431IFCkJo0mCUoZcVeDl7OP8y7MSFdUhDa1wh8u81Orilqj951bkT4/CbLZg== Received: from BYAPR02CA0039.namprd02.prod.outlook.com (2603:10b6:a03:54::16) by SJ0PR12MB6757.namprd12.prod.outlook.com (2603:10b6:a03:449::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.17; Thu, 26 Jun 2025 12:08:43 +0000 Received: from SJ5PEPF000001D5.namprd05.prod.outlook.com (2603:10b6:a03:54:cafe::bd) by BYAPR02CA0039.outlook.office365.com (2603:10b6:a03:54::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.21 via Frontend Transport; Thu, 26 Jun 2025 12:08:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001D5.mail.protection.outlook.com (10.167.242.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:08:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:08:25 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:08:23 -0700 From: Xueming Li To: Chengwen Feng CC: Xueming Li , =?UTF-8?q?Morten=20Br=C3=B8rup?= , dpdk stable Subject: patch 'bus: cleanup device lists' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:01:34 +0800 Message-ID: <20250626120145.27369-75-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D5:EE_|SJ0PR12MB6757:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e07fb60-4dba-4e6f-c7df-08ddb4aa30cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|36860700013|376014|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VWp6Mm9jdHI5QWpJR1lYK3FUUzkyU2NXK2sxRWovZHpnRGJiVGZzL2hxdUd4?= =?utf-8?B?MDlqZTV4V2U3WTNSaGFGYS9qelpSRzFacklpRUFVdVl3ZXJvU2g1cU9BamRB?= =?utf-8?B?UlR4eVJkNnBPUlplbkh5d0p6WjVIYmZCNXByYUVkQVBOcXVVSkVYblMxNmF5?= =?utf-8?B?eDFDQS9xaUJIV1pZcE9DYlFtT3JKTk9nNXh6NE90Zjc2R2I5a2I1NTlGS29I?= =?utf-8?B?VnV5TjE4T1VydWlPWjlqemFqM2l0aFZGd2NRUUt1MVdKS1lJQm16eVpWb2M0?= =?utf-8?B?VjN6eHlUSmJ5OVdReHE1Y2Y0RS9TcmV5NkF2cnFvbTIzb2RvT2E3SjhjaTFM?= =?utf-8?B?K3lubWlWT2NpL2N1WHNKYURwYnpySVVLaFpNQjM3QnMzS3F1WW5HS0hlZHNM?= =?utf-8?B?Q3NmQjVZczRLUzZmUGo4Y3h0ajlVWXUyby9hYVhvNmN0VkRYS2svZ0J5M1hR?= =?utf-8?B?bDkza3QxYXBvMTVMM3NQQ0VybmNoQ204NXYwWHJhalhIbklaUUpYcUw3YmJH?= =?utf-8?B?RHdoTmFYeUpGUFBJbEFkcUkvQXh5L05ub3VZS3M0dXRXTDBuRUkwSy9TVVpP?= =?utf-8?B?Q0lLSE00VzJpaXhPZzFjSzNHZFByZ01MV1B3MzlGK0E1MnU5Sk9TZ0Nuc1Qz?= =?utf-8?B?MzBVNnNvd0ltZVRoczhPVDBuaVpURmRTb2tIb2RsMFludUNvcVR5elRnSzVa?= =?utf-8?B?TC91ME44dTZGNjVJZ1hObm40VnhURENPQXN2ck1obkQ3anBnZ0hKRFk2cTdC?= =?utf-8?B?RlpXTitCOHFraVRLOGQ1emE0eFk3ZXc3VkprR3orUW5HT1VsaHZ2dlF5empm?= =?utf-8?B?NzlKVFpxNmFEOFp6ZFl1VG5vcUtkcithb0tOeW5Ra21Pb0V6NGQ5NzByU2R1?= =?utf-8?B?dWw1VkVEQjJxaEYrRkJEUnRSN1JjUndSOVZXS29sTGtTMHA2WnpPOUhrcDhM?= =?utf-8?B?bnhYeDBSdU91SS9kS3lFTXRWZEZBcHp1Q0VTTHBNWTQwd3pDOG5qV3I5c1dU?= =?utf-8?B?MTdIZG1yOStJWURINmtZOXcwTHBHMU8wTE02M2sya3liUTBWN3JJTEVFQ2RE?= =?utf-8?B?SXNvWmE4R24yVHVkT2ZIOWo5U3ppT2FRM1VxeDZGQnQ1ZmxRUERqYUQyQzhO?= =?utf-8?B?TjdYdjBUaDFDRkV0M3FpKzRNOHVZSXpISjdNNDdYMnpaeXdWY2UwSERGNHRm?= =?utf-8?B?SlNBUnZLaVRaUVkvc0IrdlFpR3VFRHpRNE9rWW1GVlk3UUVqd0h2Z0FOYjFv?= =?utf-8?B?MVozZ2xHSnJwMDZYMnM1Y0ZtdzQzZHNIbStQclBMc0V4SkxpSmpRWmNtS1pW?= =?utf-8?B?cXJYQk5vR0phM21PajZ0WXROVTU3VGxjbXJ2RnVmbGtDQ1BsZWpKRFMzb3I4?= =?utf-8?B?c1VLTVJiRmg1WmI1cGRMcVl4ZUVhNjdDZWd3RCtkL3N5MDVVUnVUejdvNGhT?= =?utf-8?B?aTZObGRab0VIZEpTZExSdWlNMDVJVWFqckxxWWFJeEcza3Q0U1Q4cVZSSk94?= =?utf-8?B?YXdBalpGWTlTejJoNUhyczUraGw0aWQzZWF3VzhSNDVRcXNSY3VoNzc5YjV5?= =?utf-8?B?TFJXM2svZHExZG5VV0JqZmhUQzBQcms5TzFPMlpFU09BRUY0VGk4Zi91MUs0?= =?utf-8?B?SU1MVnd6K1lneHM0d3lsOHl3cUtrcWpuaTBzMTJMbUExUy9DeUZESis3WDB6?= =?utf-8?B?SGg2RkEyajlNdm8wVVRLTHA5U3oreHJ2cEM5KzcreEdTQTllakdTeTFiUnBo?= =?utf-8?B?eTF2Y1l6L2Vta2VObTVwMkEyUUVjRVN5MlRUU1NYR2E2TmNqdElzZGw2RG1T?= =?utf-8?B?VXd4ZDJuV21McUEzVmF3a2x2citqNjVWWS9MWDdFcE5Oc2lZWDdLZ2VWSDc0?= =?utf-8?B?bnJxOU9LZzBLNittWmRXWGt0K1R3WGdKVUYwb3J0RVBGb25nM0pwMjZkV0Q4?= =?utf-8?B?ZkhHeW1NbmZ2UklqdlpvZ3U5aElQNXpGQlU1UFQwWUQ5eVR2VDFvYXJjZUZ1?= =?utf-8?B?QTQxKyszTlRsNDRNNEErR3VCTFBnV3JadlhRWXRPbVJsL3E0TTR0eVUzeHRN?= =?utf-8?B?d0FkZjZvaXVuV01TZ3VSTHlicFhBUzVEWTUyUT09?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:08:41.2258 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3e07fb60-4dba-4e6f-c7df-08ddb4aa30cf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6757 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=0e5825dac707e01523e30fbad2bf6e30ad64bb73 Thanks. Xueming Li --- >From 0e5825dac707e01523e30fbad2bf6e30ad64bb73 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 20 Feb 2025 16:09:06 +0800 Subject: [PATCH] bus: cleanup device lists MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 398bb775edc5434ad94578a5e6c49fa1328acc0f ] Although eal_bus_cleanup() is not invoked for multiple times, this is a good programming habit to remove the device object from list when cleanup bus. Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Fixes: 62b906cf06ba ("bus/uacce: introduce UACCE bus") Fixes: 65780eada9d9 ("bus/vmbus: support cleanup") Signed-off-by: Chengwen Feng Acked-by: Morten Brørup --- drivers/bus/pci/pci_common.c | 1 + drivers/bus/vdev/vdev.c | 1 + drivers/bus/vmbus/vmbus_common.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 1b3fe4783e..df0ad15100 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -455,6 +455,7 @@ free: rte_intr_instance_free(dev->vfio_req_intr_handle); dev->vfio_req_intr_handle = NULL; + TAILQ_REMOVE(&rte_pci_bus.device_list, dev, next); pci_free(RTE_PCI_DEVICE_INTERNAL(dev)); } diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index ec7abe7cda..ae79cfd049 100644 --- a/drivers/bus/vdev/vdev.c +++ b/drivers/bus/vdev/vdev.c @@ -596,6 +596,7 @@ vdev_cleanup(void) dev->device.driver = NULL; free: + TAILQ_REMOVE(&vdev_device_list, dev, next); free(dev); } diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index 8a965d10d9..4dac5a6298 100644 --- a/drivers/bus/vmbus/vmbus_common.c +++ b/drivers/bus/vmbus/vmbus_common.c @@ -238,6 +238,7 @@ rte_vmbus_cleanup(void) dev->driver = NULL; dev->device.driver = NULL; + TAILQ_REMOVE(&rte_vmbus_bus.device_list, dev, next); free(dev); } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:20.531433713 +0800 +++ 0074-bus-cleanup-device-lists.patch 2025-06-26 19:59:17.494418039 +0800 @@ -1 +1 @@ -From 398bb775edc5434ad94578a5e6c49fa1328acc0f Mon Sep 17 00:00:00 2001 +From 0e5825dac707e01523e30fbad2bf6e30ad64bb73 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 398bb775edc5434ad94578a5e6c49fa1328acc0f ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -22 +23,0 @@ - drivers/bus/uacce/uacce.c | 1 + @@ -25 +26 @@ - 4 files changed, 4 insertions(+) + 3 files changed, 3 insertions(+) @@ -28 +29 @@ -index 5df4086f31..c88634f790 100644 +index 1b3fe4783e..df0ad15100 100644 @@ -31 +32 @@ -@@ -451,6 +451,7 @@ free: +@@ -455,6 +455,7 @@ free: @@ -39,12 +39,0 @@ -diff --git a/drivers/bus/uacce/uacce.c b/drivers/bus/uacce/uacce.c -index 9b8ac23952..f5343ed87a 100644 ---- a/drivers/bus/uacce/uacce.c -+++ b/drivers/bus/uacce/uacce.c -@@ -455,6 +455,7 @@ uacce_cleanup(void) - dev->device.driver = NULL; - - free: -+ TAILQ_REMOVE(&uacce_bus.device_list, dev, next); - memset(dev, 0, sizeof(*dev)); - free(dev); - } @@ -52 +41 @@ -index beee8c4033..be375f63dc 100644 +index ec7abe7cda..ae79cfd049 100644 @@ -55 +44 @@ -@@ -603,6 +603,7 @@ vdev_cleanup(void) +@@ -596,6 +596,7 @@ vdev_cleanup(void) @@ -64 +53 @@ -index ac04ee11f8..a787d8b18d 100644 +index 8a965d10d9..4dac5a6298 100644 @@ -67 +56 @@ -@@ -240,6 +240,7 @@ rte_vmbus_cleanup(void) +@@ -238,6 +238,7 @@ rte_vmbus_cleanup(void)