From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16C4A46A63 for ; Thu, 26 Jun 2025 14:09:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1155F400D6; Thu, 26 Jun 2025 14:09:07 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2089.outbound.protection.outlook.com [40.107.220.89]) by mails.dpdk.org (Postfix) with ESMTP id ECB28400D6 for ; Thu, 26 Jun 2025 14:09:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a/9c24MDiOic15XlvLNs3m9tDgSQ43pao17W1/Wy1j9OaDi12vK6HvXDBBTO3PikaBcGT27GQXvRrwpLXotoy1AUbsbobo9pqxgm5VsDAwHX7LI1Q1+cdZYR74OiotVirtuONZ0FWfaE8XBFPbyonSyqFMDxBBoNcNIl7cjeXpVNUKSclcJRes6iNdF6SZ1q3oc46205smsiCKSdl64nOn1uB3CFymPnz9mAhl/9V45TQ2Kr/ZkYBEZP4ftk3drJQB5YLD72EbQ05+gOHxV7jXoJuOLaJRBnAviE1pyMbmX3jFuXCKFK3B0jt+QY7ctvhc028jlkhV4/hrMO5xzPUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jK1nS3r43lHGEb4q4MMofZ4C3PfkVbIpYw6X1cRmebQ=; b=keGd5zhr2E3B7M8OlNKpQ5x5RAB3nh+l92PJiE0tfooHw3Y/+qVUok3B3/owaQtu96kfxaLwoBoifWHi23T1zPCkvJgkpNcMZ2stEg5FR5bylFQsxBeMbchZA+/IDY3SJvUaKNsu305+3sJos7d6jMzaOv3AXGNRaP9bUME5ad00CsCbm0MsoK9Oe05a61HxRkSrR23dR8qyd0IxDZmfZiFOZBx50YN3D781sdq0hxBJaIbIsbxM01Boi51UPPw/fQahUPr3zo5UYjmmrjV7DpaYWe40iEqtTWNTTJHa+7UR8MbggoD45bh+WlS0zff8p8nQs6I4Wt55aGHI25BHpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=freebsd.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jK1nS3r43lHGEb4q4MMofZ4C3PfkVbIpYw6X1cRmebQ=; b=aGioXI4eXBVB7R9F/9hc7LDUSVIN0SHqZn4pjMxrR/G7ikMbhHxILwHSx1JbKhXygDu0Fo8YKKA+EZ5nTnsz1epTuF63wso4khhEUStKZ9inZ59iwoOVvTfHw40Ae+YZvyx+zpFnpe9tKL9+ZbMigRfJWS/oXrgd7la3kY0Pz5dc57VtGZiyESlNGiwSFEr4nfa4UYxR5XV0v42GZvf17cL+EAzLX5GsNKwJAJY/Ry5jyTZGSoOZAZlO8R13SynDuDhlJa6tjjK7iIeWp9ELsJNDdNmsbTH5AYIxuYli7XJpMYSoi81vGTm3O5F3+lvX1c9gPFglo4ZFcblJz5BOZg== Received: from BYAPR02CA0038.namprd02.prod.outlook.com (2603:10b6:a03:54::15) by MN0PR12MB6296.namprd12.prod.outlook.com (2603:10b6:208:3d3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.17; Thu, 26 Jun 2025 12:09:03 +0000 Received: from SJ5PEPF000001D5.namprd05.prod.outlook.com (2603:10b6:a03:54:cafe::2f) by BYAPR02CA0038.outlook.office365.com (2603:10b6:a03:54::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.17 via Frontend Transport; Thu, 26 Jun 2025 12:09:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001D5.mail.protection.outlook.com (10.167.242.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:09:02 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:08:50 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:08:48 -0700 From: Xueming Li To: Jake Freeland CC: Xueming Li , Anatoly Burakov , dpdk stable Subject: patch 'bus/pci/bsd: fix device existence check' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:01:37 +0800 Message-ID: <20250626120145.27369-78-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D5:EE_|MN0PR12MB6296:EE_ X-MS-Office365-Filtering-Correlation-Id: 95473e4e-47a7-485e-e0ed-08ddb4aa3d9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ziJxW673vN7aHnIbeS1fiqI7xB3yQ5DZAxVwlyadwlzZO6jmKcucNj1qV+Wj?= =?us-ascii?Q?TXzEGn7njvcmD7p51urTFhLJh9l6sUBUGMmgRuBhbhcnL/CfSqbF0/USGaO7?= =?us-ascii?Q?OFs+aagh9s50P18PFRGjAQb/ToqRRBfas6p+/QCRROR4jHgYnV2P+LwUuv8D?= =?us-ascii?Q?LKuPxsrW1uqjxEqxQGhidgp0WfebmAm3QhFzwsQbHxj8Bzsmj/MzoZ1HCn+X?= =?us-ascii?Q?Tg9l0btcBF/14u7djA1kA5IgYAa1bY5BoJbDKhy4nh4Eq4nx9s1Cv5EOFqlu?= =?us-ascii?Q?wdBLM/LeaTCLzj7pFzpr8DWEOXT2zVEGPLUXzJrGZ1WLeMSNyds5WRTIxrnK?= =?us-ascii?Q?vl4CuN7KZ8o1WR5i80xIPPnXHkt5Ps74tLMiBWlcFGdvJQp+pUR+WzQyeJ36?= =?us-ascii?Q?QSWjTA7TixYhpDYl1eDr3VXYwm0EeS2gbtC90w5HQXIRlruUHULg2Nn9IoEZ?= =?us-ascii?Q?UH316qqol0C2erI0wVDCTWMIQNlYSdCE26SMs6ANJnEGQocJK9ZCEj6cuEfZ?= =?us-ascii?Q?Jx/EIliggLzldx9Ai57/CC2+/e1aaj4AxVqrUr+piPRYBSvpKzafYolqugd/?= =?us-ascii?Q?+Ewd+BwZ2/s/As5g8L6RPYV/vxWNdJkB0ekTzm6IR/wSUx0+UfgmyBqXOExq?= =?us-ascii?Q?DTIF1Xadt4VMyU9//qXNOevMg2sfJ6cJWufJ9qjcIv3s99opjeRWxnG3bm29?= =?us-ascii?Q?DcTdg8fVAxJJx6URNMR14V5FzscRerfNJnnKZHbo+M7JksOSiLvi3qQfiYc9?= =?us-ascii?Q?uZGS4s8Eyb68QMZGVAK7P0zDpf/iIH+ggGzp7vpwANC/0G7n4frL19dVsM9Z?= =?us-ascii?Q?4YhYXbMum9rXJKtY2vTxzwOC7bGF5pWvyohT/YfPdullGRDXnBY84oOHBFGE?= =?us-ascii?Q?CtTQjemEaptTm93gh7q2ObenZg2FgGFMYhJxKMVa6auSrujYla5w7NkCxOkt?= =?us-ascii?Q?CSkUcq5OS9+VsVvaC+iHaMpbaedUWqT693IXFAF02dqmuYCuhS+zPVAaGAAQ?= =?us-ascii?Q?FHb0uuFvIImujildlE1PjOLESAZ95kKJnHQnK7e0wAQPsw1mcxrinjweeudM?= =?us-ascii?Q?UUO+3UGTxgDI0FPZonwBmo9Y10543uLu/+KuFHWs8Xem8L+B6tldi58Iwt/f?= =?us-ascii?Q?KA8oGlQk4LIaM2LB0Us9uTf6RkgvLHm2vGw+UbP389gsHq1G91g0LdDnjAIe?= =?us-ascii?Q?JUpCJmDzNn31hi5dfibWHnuOo5knG0LBLRHVk/aFK1k0cquTTzMXctDvtbHt?= =?us-ascii?Q?FWmLHGKBwObV4RyDid4dPpATjfQezJlN4Dlt/Lpf855BSdyBDEHZaqow8A1I?= =?us-ascii?Q?XVL52w5H74Hg2J7Cz+uZUEBFy+zTJCOPOYbWTZrxkUiNflRqWnfNOpfl75Ft?= =?us-ascii?Q?bc7nNbLfOas2gUqjjrDg8zlsyJ3twOHzAOme0vrbe1bXkPeKCRy4Fdx72rcO?= =?us-ascii?Q?8QWkI4YHh3DW8H+S/VkOx6o/qyhz1SpLdXW1KGH4PK6RgkmVaxudKgnlnNaA?= =?us-ascii?Q?o3nDpIVw2qy5hENO+IOZRMYX4vHvsbuZRUnv6AkkFe+wtB02o3iXLrcUhQ?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:09:02.7283 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 95473e4e-47a7-485e-e0ed-08ddb4aa3d9d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6296 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=74a2941c3ba5886ca89f73df018798978757e96d Thanks. Xueming Li --- >From 74a2941c3ba5886ca89f73df018798978757e96d Mon Sep 17 00:00:00 2001 From: Jake Freeland Date: Tue, 6 May 2025 12:40:44 -0500 Subject: [PATCH] bus/pci/bsd: fix device existence check Cc: Xueming Li [ upstream commit 6d4e6dbccc3bd965bfd5e5836d7cb21c1b1f9c6c ] Use open(2) instead of access(2) to check for the existence of the target device. This avoids a possible race condition where the device file is removed after a successful call to access(2) but before open(2). This also fixes any potential bugs associated with passing open(2)-style flags into access(2). i.e. access(2) does not formally support the O_RDWR flag. Fixes: 764bf26873b9 ("add FreeBSD support") Signed-off-by: Jake Freeland Acked-by: Anatoly Burakov --- drivers/bus/pci/bsd/pci.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c index 27f12590d4..933a43a9f5 100644 --- a/drivers/bus/pci/bsd/pci.c +++ b/drivers/bus/pci/bsd/pci.c @@ -105,20 +105,27 @@ pci_uio_alloc_resource(struct rte_pci_device *dev, { char devname[PATH_MAX]; /* contains the /dev/uioX */ struct rte_pci_addr *loc; + int fd; loc = &dev->addr; snprintf(devname, sizeof(devname), "/dev/uio@pci:%u:%u:%u", dev->addr.bus, dev->addr.devid, dev->addr.function); - if (access(devname, O_RDWR) < 0) { - RTE_LOG(WARNING, EAL, " "PCI_PRI_FMT" not managed by UIO driver, " - "skipping\n", loc->domain, loc->bus, loc->devid, loc->function); - return 1; + fd = open(devname, O_RDWR); + if (fd < 0) { + if (errno == ENOENT) { + RTE_LOG(WARNING, EAL, " "PCI_PRI_FMT" not managed by UIO driver, " + "skipping\n", loc->domain, loc->bus, loc->devid, loc->function); + return 1; + } + RTE_LOG(ERR, EAL, "Failed to open device file for " PCI_PRI_FMT " (%s)", + loc->domain, loc->bus, loc->devid, loc->function, devname); + return -1; } /* save fd if in primary process */ - if (rte_intr_fd_set(dev->intr_handle, open(devname, O_RDWR))) { + if (rte_intr_fd_set(dev->intr_handle, fd)) { RTE_LOG(WARNING, EAL, "Failed to save fd"); goto error; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:20.627862309 +0800 +++ 0077-bus-pci-bsd-fix-device-existence-check.patch 2025-06-26 19:59:17.506418039 +0800 @@ -1 +1 @@ -From 6d4e6dbccc3bd965bfd5e5836d7cb21c1b1f9c6c Mon Sep 17 00:00:00 2001 +From 74a2941c3ba5886ca89f73df018798978757e96d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 6d4e6dbccc3bd965bfd5e5836d7cb21c1b1f9c6c ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index 2508e36a85..3f13e1d6ac 100644 +index 27f12590d4..933a43a9f5 100644 @@ -27 +29 @@ -@@ -106,20 +106,27 @@ pci_uio_alloc_resource(struct rte_pci_device *dev, +@@ -105,20 +105,27 @@ pci_uio_alloc_resource(struct rte_pci_device *dev, @@ -39,2 +41,2 @@ -- PCI_LOG(WARNING, " "PCI_PRI_FMT" not managed by UIO driver, skipping", -- loc->domain, loc->bus, loc->devid, loc->function); +- RTE_LOG(WARNING, EAL, " "PCI_PRI_FMT" not managed by UIO driver, " +- "skipping\n", loc->domain, loc->bus, loc->devid, loc->function); @@ -45,2 +47,2 @@ -+ PCI_LOG(WARNING, PCI_PRI_FMT" not managed by UIO driver, skipping", -+ loc->domain, loc->bus, loc->devid, loc->function); ++ RTE_LOG(WARNING, EAL, " "PCI_PRI_FMT" not managed by UIO driver, " ++ "skipping\n", loc->domain, loc->bus, loc->devid, loc->function); @@ -49 +51 @@ -+ PCI_LOG(ERR, "Failed to open device file for " PCI_PRI_FMT " (%s)", ++ RTE_LOG(ERR, EAL, "Failed to open device file for " PCI_PRI_FMT " (%s)", @@ -57 +59 @@ - PCI_LOG(WARNING, "Failed to save fd"); + RTE_LOG(WARNING, EAL, "Failed to save fd");