From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CE1146A63 for ; Thu, 26 Jun 2025 14:09:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96B0F400D6; Thu, 26 Jun 2025 14:09:26 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2056.outbound.protection.outlook.com [40.107.243.56]) by mails.dpdk.org (Postfix) with ESMTP id ABABA400D6 for ; Thu, 26 Jun 2025 14:09:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sd2j0JlnbBwyCah9Vo+6ZvxVAMI2+aqsc+ZnwrdP44szjxpg9/Rcl+5zf0Uze05PH1qT6Y3cep/kYPQbRiewpdw559lL0B+zMjCTUbC8iLNJYAImy1/x7FXT3ozv2uEm977D5AemGzBANFrcM535oN2yfT5GEqWudTN764FL7y/svjAVDqAlgdvmm4RurKkOIezJd/uyGfTBcsdDDi5l1r78HageU8scq/ZgXCwkghbjAW+44a9IFpSGihrzsD7Taus1ThL0tP/8tSCdJenyZbvDZmRCz9rq+0rpmUSjQBAy5HN7Z5VraXtWXoij7fPX5GxwyARzHIO9U6mKc5K66w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nYEJEuYLFrkLd7PLzHnv7cCYpUslCCQTs8hZaW8m9QI=; b=XgQBgMHlO1XNs8H6B7wVUAuBP39GMcQZs3ZFW6cAavnLaNwCKB8YifaLEXCBOMRoUnfrdnzMSkDqHtE1FcOchEWeF9oXqJdW1KXeKlxs67o82iNq5n73EpJUW+NEtnfJTkdtPrX/vH5gkKMlqMaaRr+L3xIHpjA0EqmfzYbGyPyoK3Bi0PzyRtpbXWNiFXcW73CR2zYwjMNA3EqiNDLcPe8khjZMJUv24VDnDHJxUVGZExd8qRzyB1cCE/EUfQ+k3wKnQZEviWwfmuGRL/iAUICqz9xgYerbYwc8s4MVfEotc+WgT7zLqjlXX2ZE6SNfRy+ipKHSNx7QeLZKK9J39Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nYEJEuYLFrkLd7PLzHnv7cCYpUslCCQTs8hZaW8m9QI=; b=fMzK/oktHgqwRhDLmPdlsEgj6ND30f7a9jRzndRnPYL6z6MU92tOWnGXIPt8AhhT5pDy7ykthAMEJoiPfqtM6ESFmN+E248lYBMxSfqbVvUpWZbaEzB/9vQURy6pBIYs4lW5OQSAbDXZS7po5pv6VRzxc4nnWSkgVyKJmdkVms71feacaCocw+zIpsDqS1I5krNRwDGj9aREtP3Yxhhis+sNFSepi1bYixaB80evu3Y9WOGYn0qv6qhrfedSOBT1DxCltwsmb3BNAKlKyTpWRwtBDrsHuF58cCVO9uuMzNZ7PA24GQYNp3DTGZj0nrrjj6xRzgrBF0M5WJKKJoKyhg== Received: from CH2PR20CA0017.namprd20.prod.outlook.com (2603:10b6:610:58::27) by SA5PPF3C36BFCB5.namprd12.prod.outlook.com (2603:10b6:80f:fc04::8c7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.28; Thu, 26 Jun 2025 12:09:21 +0000 Received: from DS2PEPF00003446.namprd04.prod.outlook.com (2603:10b6:610:58:cafe::45) by CH2PR20CA0017.outlook.office365.com (2603:10b6:610:58::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8835.34 via Frontend Transport; Thu, 26 Jun 2025 12:09:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS2PEPF00003446.mail.protection.outlook.com (10.167.17.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:09:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:08:53 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:08:52 -0700 From: Xueming Li To: Stephen Hemminger CC: Xueming Li , Bruce Richardson , dpdk stable Subject: patch 'crypto/qat: fix size calculation for memset' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:01:39 +0800 Message-ID: <20250626120145.27369-80-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003446:EE_|SA5PPF3C36BFCB5:EE_ X-MS-Office365-Filtering-Correlation-Id: 887f104c-2327-4e58-32e1-08ddb4aa4888 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9DPi1FX8M1g90yOgehzKsV9xmmxh3Ue4LssI2MhYhfITSasaQzchFeOSEjo9?= =?us-ascii?Q?AHJ9wNj569fzdDpn+Ds7zpYOpv2yDkSsX2hMxGdvlDpB8ttMaGGBPOH5VoYn?= =?us-ascii?Q?X4KOu5Ql9QfdV+Q82L7/9YFMnoYjG8cokxSZjJvitoCdKwOqylftZg/5gQaB?= =?us-ascii?Q?E8EyPgB+9sduHmnJVkry6CQLi4UVqmqm1vGlFxbSRmgRF56cZTX6zP02tZnP?= =?us-ascii?Q?M6a6yp8lJ/pjs8BsDLP0Ja8YuMZzlgJiGBKa9fllfHi9rLPyFMIi5HAxytWO?= =?us-ascii?Q?6LRlgD7VkxJIhRSkvWmY1p3fJLURtOqFeUcWODqFZ0axp4uKfyXPjeRIhCIF?= =?us-ascii?Q?DFQaXRCAF8pQUqzXGDA3CX5V3evN1Qjbj5e53ZJq2ErM6b2CQkGX9Wfez1/3?= =?us-ascii?Q?mzIQqxVijqcz70+r9qzRS/EvtvG19jTPftxkQk35xUnlrc7TTnOAlxHZYDE/?= =?us-ascii?Q?iS3MtOYBqGRWijLwefFkxu+g/2nlw3hM8j5D3/SgsDIkwOvwUdNZreqjoqv/?= =?us-ascii?Q?IICgWzUYd2ADIgLFrj1K2eem0bOLmvyjGua0j2c7fRtX00jsOIeTLilyjBoh?= =?us-ascii?Q?PbrzEN8gsFA2wpVB0JCef6M+seYxcxGpXjPsKDbbdSmx+Qsk5nEgUGVUrHPs?= =?us-ascii?Q?099VRv4UT4FQyupBtkFeFXJcCMgzjgDtc0B0n6ngxzuKduwuXxPyXfCq7yWF?= =?us-ascii?Q?LuarPLawVsl3cZbarVnX7QTg8qgB6SzV4bJY/pgo+Z4leMA/1Txn8Vm9Ony/?= =?us-ascii?Q?Hbd7qMxBxGhPxqEvPFBOKTx3xldWvVOJOT0gUfjF43q92KG0wjdJwf5ejlVK?= =?us-ascii?Q?EAasbOaU64OOKuczrP+QW/iXeXdrPDyEl8oparApUPyK69WGx8wDxUOnQDgU?= =?us-ascii?Q?piLC9042DhLJAL7681y/c//lLAnm4c8zETABTnqzlHeAja6cOd7sBfpAVRnD?= =?us-ascii?Q?fWG1ca5l9OOI/LBWnlZKOuI3i/ZUvEZnNa9d83NmeHANA0t5/kM2+1MtDvi5?= =?us-ascii?Q?ZoCFECC+7UaK/wZO5JcRQsNucxHkKdgQZTV62V/OgTNK3smgxll08aEfKfeN?= =?us-ascii?Q?iMeW1qZBhya7v5zgz3q8DSY4fYPSnF0AcLhd2RGLXyv9gYgVZqMSAgTS81xh?= =?us-ascii?Q?OXylzVL8bKMYoHsdqHpJ+X7w9fcSZ6Aj7GFmGLp6gCUx4ArJRX5LXM2iYB4V?= =?us-ascii?Q?RG9O72FIrMaJvTsWuI52fYADIJk6OnitRPFENLmzxgUph1eyGbj8faNn46Eh?= =?us-ascii?Q?s9UWzBRUQ6+wtIF93rSQjOJj3LlPMXdtGI/mlcxrqmW9sTmAugZ9AQZJQc4H?= =?us-ascii?Q?kL+nn05LIrwuZct1cDdwrcAzQFAiRsEVhgT7Rwz4QVZGWIUrmLAEsy6f788h?= =?us-ascii?Q?rJ+2gLG/1dv4QUkYdoqzZxucgdov90hRnBnBvH8ChAlN7pZ2S5Jt3txAnELn?= =?us-ascii?Q?wQoyFhaywATbc/9Y0cukvOgQjzcpsO0sYQHwLwS+FwNHHmwQm18VNkepPCA5?= =?us-ascii?Q?YeJhZN6N9yI8JGvySWjABskij13EGJ/12Lox?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:09:20.9266 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 887f104c-2327-4e58-32e1-08ddb4aa4888 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003446.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA5PPF3C36BFCB5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=bedd4b04981354f3c6c3f0c617310840bfd4925f Thanks. Xueming Li --- >From bedd4b04981354f3c6c3f0c617310840bfd4925f Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 20 Feb 2025 08:27:14 -0800 Subject: [PATCH] crypto/qat: fix size calculation for memset Cc: Xueming Li [ upstream commit 99763482361f08c77c9752985d7a7fd9adecd719 ] The memset was always doing 0 bytes since size computed later. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 3a80d7fb2ecd ("crypto/qat: support SHA3 plain hash") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/crypto/qat/qat_sym_session.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index f6dd96497c..4002593df6 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -2174,7 +2174,7 @@ int qat_sym_cd_cipher_set(struct qat_sym_session *cdesc, return 0; } -int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, +static int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, const uint8_t *authkey, uint32_t authkeylen, uint32_t aad_length, @@ -2443,27 +2443,27 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, break; case ICP_QAT_HW_AUTH_ALGO_SHA3_224: /* Plain SHA3-224 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_SHA3_256: /* Plain SHA3-256 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_SHA3_384: /* Plain SHA3-384 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_SHA3_512: /* Plain SHA3-512 */ - memset(cdesc->cd_cur_ptr, 0, state1_size); state1_size = qat_hash_get_state1_size( cdesc->qat_hash_alg); + memset(cdesc->cd_cur_ptr, 0, state1_size); break; case ICP_QAT_HW_AUTH_ALGO_AES_XCBC_MAC: state1_size = ICP_QAT_HW_AES_XCBC_MAC_STATE1_SZ; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:20.690592806 +0800 +++ 0079-crypto-qat-fix-size-calculation-for-memset.patch 2025-06-26 19:59:17.510418039 +0800 @@ -1 +1 @@ -From 99763482361f08c77c9752985d7a7fd9adecd719 Mon Sep 17 00:00:00 2001 +From bedd4b04981354f3c6c3f0c617310840bfd4925f Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 99763482361f08c77c9752985d7a7fd9adecd719 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 7f370f03fb..5d831b3106 100644 +index f6dd96497c..4002593df6 100644 @@ -23 +25 @@ -@@ -2346,7 +2346,7 @@ int qat_sym_cd_cipher_set(struct qat_sym_session *cdesc, +@@ -2174,7 +2174,7 @@ int qat_sym_cd_cipher_set(struct qat_sym_session *cdesc, @@ -32 +34 @@ -@@ -2620,27 +2620,27 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, +@@ -2443,27 +2443,27 @@ int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,