From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28EEB46A63 for ; Thu, 26 Jun 2025 14:09:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21D0B400D6; Thu, 26 Jun 2025 14:09:41 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2076.outbound.protection.outlook.com [40.107.92.76]) by mails.dpdk.org (Postfix) with ESMTP id 419AE400D6 for ; Thu, 26 Jun 2025 14:09:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FIOBWhHOQbzUZPrJTFP4l3gGELhzBM1nyGBCgAAk0qh2VDp0nC98Cbf4I2oHmboCum//uegCZJBkSKZnRehpWzF08QfC1A5gF5FdqzbHttROQ5IBAh7MrWAHiEzXbZxcElGK4gkFnj2hXFJakWdXfoBInbUbOhmHojfymQeVyf/hqr/wcZcWlwZrX0sdp7nQ78UCBeg3gRfvBA39nRMJ6SzaW57L6gyYF1AVbTH/GXhalyWbyEuC/jqGjvldy1oyyDmcU0cJUhg1P3DDn2rh4x96f9UD4vtjTglT3/kpJ/v0a5fDiOImvt0qJmRjI1UFLyamtuLgZBJ18UvegonoYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AAVWE8oB+/OiremFN9RRu/zKY/eCqubUQrTBPl6IEeg=; b=EuSIS8NOAr5Z5PCVzWQLMTiLNJE9W4jm+p1zG9uZ6mPLXNnOBQ76kq34tDX/aik/e9rVcIqT6Br3UpXg2loPehkLXftjgttBvmB6Q5BzpqXxfu52Mttmu5sC2hT9TouND+wKzrFkKYiwberPmVRIzreb4dc8rbClGbh6CywlqjBqF0DtV33clIDyOt9IQ2Xb1mZBTEzyHJQe948Hl4PJCQugtaMd5WDGa1xMwESMWGQGkVWAXNtEpPzFmQcVLmqu0/okYDU5D1DfonZmfLH4dc28y5cfbo0veDqWFWgnV8trIpfolGyyAaQzvu7HXud16h1qfdHHhqGGquX2y1TiRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AAVWE8oB+/OiremFN9RRu/zKY/eCqubUQrTBPl6IEeg=; b=SxDW4VbTXu9kcdlKoJpyyz5+hG7KAye6YvWfnNWvx0r733TxW6IMX3PJGmPO6VjXSUGzsYYVzZzMcHiRgUP1SLqUIFj/+f/WR1AsMKFUOulaCqC0eAyDEznuiDlcPPhchBpZjMrYA8hUZT4RFAMNLOBX9B40ZIWZDY/48YEzsvGfuwLr5OkTuUfUqTDCUEKik1IcTMPgJipwRlGmueir+okOw/OpcgdEtZnMblm7Ak4hwWVAwauKCvUnvfI4haU2iT7FkTvOVSumFRGE6rJ95+etgatJS199/Z3royIRwNVorKdp/5kzsYyd4UBa8/2UxJcgkhxDGsqF8z1tT4gOUg== Received: from CH2PR20CA0026.namprd20.prod.outlook.com (2603:10b6:610:58::36) by SJ2PR12MB9087.namprd12.prod.outlook.com (2603:10b6:a03:562::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.21; Thu, 26 Jun 2025 12:09:37 +0000 Received: from DS2PEPF00003446.namprd04.prod.outlook.com (2603:10b6:610:58:cafe::4c) by CH2PR20CA0026.outlook.office365.com (2603:10b6:610:58::36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.21 via Frontend Transport; Thu, 26 Jun 2025 12:09:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS2PEPF00003446.mail.protection.outlook.com (10.167.17.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:09:37 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:09:13 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:09:11 -0700 From: Xueming Li To: Maxime Coquelin CC: Xueming Li , Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: avoid setting kernel MTU if not needed' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:01:40 +0800 Message-ID: <20250626120145.27369-81-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003446:EE_|SJ2PR12MB9087:EE_ X-MS-Office365-Filtering-Correlation-Id: 38ffdd82-8b5f-4c99-d28a-08ddb4aa5232 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?WjATmluIPuuhdvCwuz+Yt/LMWkeUfE8DaXaAISQwpCemnjm//MReoRHPVELa?= =?us-ascii?Q?8U2he+dTbh7+g9U63EcTyJ/kw8jU0W+9U9nDxuyDFgRxzcxAO08x7z3jhIwa?= =?us-ascii?Q?+Vh/jcjoXcDPUVGpGg6RMrUkACVo0ffkNvfV0gls7vsTcRXGL9j1SLnPYZkt?= =?us-ascii?Q?0Q5G9y0VAXOmv+d7uDUDy9zx8/1PGiR+Skg2qO5LuzthPlP1U35NY2rbIA+n?= =?us-ascii?Q?QKr86G81AbzUwpWGnRc+uwiTCa2uQBz0K6LbxN9ICp7DZadtlrVq55VIb9T1?= =?us-ascii?Q?KJyYo2ZTq4xSkU7h/8k9jkqMZmzin0cwIGjLGXoMTM/UNF9/TWoAXAV58Tqh?= =?us-ascii?Q?ScVzwMYad2UZ8Dam+EV0Cjh5qTK9kFoMt/2XcStgUYrnx5WCqOYRPuXvwzlY?= =?us-ascii?Q?up4N5iXUPOIyPRmC7s4SbM1YUHsalVuI+OhOUUQ+o6baiCobE41zgHXUeX27?= =?us-ascii?Q?bCgsbJiL4UmbXmK5NRySjh7i2THkJkxWnZ3WjnAQPx5bz3dhkDxnK8SyHLrB?= =?us-ascii?Q?K0Lh0odv28vC9wxK357TjwALzm354fBKwP9w9AQ1CsBQeSPwiANGMrBRZ+kf?= =?us-ascii?Q?1aen9+TTaSLiec81FXBzz3tMd9zf5NIF2d6JK/MUX1nL+NduHPz/FcOzNIe8?= =?us-ascii?Q?qqvN1zD62FckiGpitDZBeBPGrz75W2QLFUdK35KF7EYGGDq3v8Vx2vghoN7P?= =?us-ascii?Q?mAziH4CqnrSxU4xCI/FGpzdUlEGBkEvAzreXCmWFIbbuyY1rNqe7hob5teFv?= =?us-ascii?Q?S/i55EDrcqee294hqmrjPd61MoX1LKfGfr1Yrch2vfTbGd4VrMcGiJYIieZa?= =?us-ascii?Q?eyF3msvyfDS9gE/4ybAZgHZFkfyxu8FxpKN1tR8gy4VOnPn6qSI7DVh5UtAA?= =?us-ascii?Q?cMq2g/F6BYmLwYEe3NAgQabh1Zh4JwNX5XJg8tcJUjUsd1035ktrK1zU/6lz?= =?us-ascii?Q?tpawTPK55YMLiIRwyczXbXBPmhLzeV9P5QQcbGI5bHNuXyJ2ztxlWj/WVoBi?= =?us-ascii?Q?qT7+WS9AN4yJhZsEqCOVfNvHPnS9UrdFv6hQLRG1kOXGGDXqEylsBZ9Mc0Hs?= =?us-ascii?Q?zbQFLLaJxi3nimTg97dG4wkVtWUdnskHs8Lnli+UC+YE9d5j8eoKxdvvendV?= =?us-ascii?Q?7Mw5Kd8PE8/hOBl+ztB6q7PC35DYsmso1g9e0SnaiQtyfkEYVrtyI+qk/Wuc?= =?us-ascii?Q?Ktr1qzLAxVEqulJ3lq4lFo2U2YbUV3L2JgaG0eUwBZIytaw1n6AEK2sjMcSl?= =?us-ascii?Q?2PLe2ZOJELrSOJxs3h/uJNKyFEql4n567Q02uX8oFktrg9dMEYUEe8Cn2I4H?= =?us-ascii?Q?WldcymrmaGUJq5UqlnyVM6/b0OoFNTguoWwIt655jjFfVOB3IcoHZx28fs8h?= =?us-ascii?Q?jKTHwbS+zrFFluVPTZhpUx7jLoLj/5efc8O9QRep2jOFv4Ao7IiKkjY6BeBl?= =?us-ascii?Q?1lYXoJre66XVD4FaOF7YbxK5h9sXnLcN6KfLwTpzIPQrag8OKeBAHOCF8gs1?= =?us-ascii?Q?9/6rp1fSAIKZuNwVa2y4cz6fzB66aM7UZk2XZkvWcjLcrXvzaJ79jY7vBg?= =?us-ascii?Q?=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:09:37.1368 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 38ffdd82-8b5f-4c99-d28a-08ddb4aa5232 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003446.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9087 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=ca9827ee06b30c13d157fd518ad1594b90c16667 Thanks. Xueming Li --- >From ca9827ee06b30c13d157fd518ad1594b90c16667 Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Wed, 28 May 2025 11:36:44 +0200 Subject: [PATCH] net/mlx5: avoid setting kernel MTU if not needed Cc: Xueming Li [ upstream commit f1f9113a08b202d302ba9448d351c04da48ff46d ] This patch checks whether the Kernel MTU has the same value as the requested one at port configuration time, and skip setting it if it is the same. Doing this, we can avoid the application to require NET_ADMIN capability, as in v23.11. Fixes: 10859ecf09c4 ("net/mlx5: fix MTU configuration") Signed-off-by: Maxime Coquelin Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 4218aef032..3762797fe2 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -669,6 +669,14 @@ mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) ret = mlx5_get_mtu(dev, &kern_mtu); if (ret) return ret; + + if (kern_mtu == mtu) { + priv->mtu = mtu; + DRV_LOG(DEBUG, "port %u adapter MTU was already set to %u", + dev->data->port_id, mtu); + return 0; + } + /* Set kernel interface MTU first. */ ret = mlx5_set_mtu(dev, mtu); if (ret) -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:20.720653005 +0800 +++ 0080-net-mlx5-avoid-setting-kernel-MTU-if-not-needed.patch 2025-06-26 19:59:17.514418039 +0800 @@ -1 +1 @@ -From f1f9113a08b202d302ba9448d351c04da48ff46d Mon Sep 17 00:00:00 2001 +From ca9827ee06b30c13d157fd518ad1594b90c16667 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit f1f9113a08b202d302ba9448d351c04da48ff46d ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index a50320075c..b7df39ace9 100644 +index 4218aef032..3762797fe2 100644 @@ -26 +28 @@ -@@ -678,6 +678,14 @@ mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) +@@ -669,6 +669,14 @@ mlx5_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)