From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08AD446A63 for ; Thu, 26 Jun 2025 14:09:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 033BA400D6; Thu, 26 Jun 2025 14:09:37 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2053.outbound.protection.outlook.com [40.107.94.53]) by mails.dpdk.org (Postfix) with ESMTP id 74E8A402A8 for ; Thu, 26 Jun 2025 14:09:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vKuVO+FCYkkaK1Q3DjBVGCkiRYtVoeEIl5CiFCddPzzPS8+CYiV43AZYi69EEcbKyeg9mGyIZrpHeLYEgrmfVuYn6q8u29C79353+dwyY6y3b/klrqEPc4JLFxsravEFt5T7XtTO9NGSuUYyP4dx+pO9d5oRetxG5qrg+RRtktRQfiR2SUW+Z4TetJ8g6kl+Cuebcrflmocyhwkp02Yj7gmR5BT7JyQTjiOPA1vQgzGn2e0pRfMUCjtacrnXKfml97MaFmO0yVSO3MKM/ZJ5E+6uwqx3gHIQNZpb6CcA8STQ21zDzGoCY8dILvnUPpMBDXgG6T26OuYasT9ELx5eLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fc62oyRpx2rrQ72+BO+BAPuOc1o72XLFagE8p5or7iA=; b=FL20JvA8luFxG+Ok4anrn4Ir9ucPkfAOl5GxcumceDq/wge+Op8bSzRz4mfPrO9lVOXyP2w3ncDxesYzTcDP7dOA0SmgHex+uApbhiGWXDrCY8HZ75Nv/Afk4TxniQ85TjYMg23Wt8K0WFvwjJzzD6l8o7N8grywCtS3rIeA4QJ3DA89l5EJJIgTCv9yFf2iQ7v3jzcAdIKnN8rTIkqZU5E9PrbDTdUxVdkDWZmEhJj3I8t+l4NLLhH4rACDL34iUEmSvcFSqgayVEcZfQCvsZiIP8CSVFQxBxU2vvoVm2ZdLsbHN7S+PM5yw3fH79lNBCquUY1SENXzzfHRtwcWHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fc62oyRpx2rrQ72+BO+BAPuOc1o72XLFagE8p5or7iA=; b=lw1AOzqnsnR5csH7rpJljBcHLvTvDvFKfxxqr4z4I3vc6JiROwJpiM9eO8pQsWxZjFpYWDMgBRKyxPnU1ZnAWBPl07OTrJ37UL8QdLi+bpQ0ZvexgTw3SQxgLMHklbS6/CGmEnXBTA2VfICrChr/2nW2D06QSClmT1q5U1YXfJMrR4nFCap79gteo58dsCfFyzobavXKMI/dV3+TDYGV4n2bje98hTqerGFGMvF/oxor233NazagN0HhiheqQkUFCkRdf7IZI5aESFAHlD6a1CdMFbswjRSTU0t0vT5cbAVLVXX8ow8+S76MUNZdVsCIOoRN8MphT3mbDgwUJLcveg== Received: from SJ0PR05CA0169.namprd05.prod.outlook.com (2603:10b6:a03:339::24) by DS5PPF4ACC15C0E.namprd12.prod.outlook.com (2603:10b6:f:fc00::64c) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.30; Thu, 26 Jun 2025 12:09:33 +0000 Received: from SJ5PEPF000001D2.namprd05.prod.outlook.com (2603:10b6:a03:339:cafe::c8) by SJ0PR05CA0169.outlook.office365.com (2603:10b6:a03:339::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.17 via Frontend Transport; Thu, 26 Jun 2025 12:09:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001D2.mail.protection.outlook.com (10.167.242.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Thu, 26 Jun 2025 12:09:32 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 26 Jun 2025 05:09:19 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 26 Jun 2025 05:09:17 -0700 From: Xueming Li To: Dengdui Huang CC: Xueming Li , dpdk stable Subject: patch 'net/hns3: check requirement for hardware GRO' has been queued to stable release 23.11.5 Date: Thu, 26 Jun 2025 20:01:43 +0800 Message-ID: <20250626120145.27369-84-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250626120145.27369-1-xuemingl@nvidia.com> References: <20250626120145.27369-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D2:EE_|DS5PPF4ACC15C0E:EE_ X-MS-Office365-Filtering-Correlation-Id: 240cd76b-fda5-4dee-5571-08ddb4aa4f47 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?cvGODzbvDDtdqKdT4C32iuXqjAAZ1Zo5RAdIaoMHIbjBC3+7B2++9qHMyeXM?= =?us-ascii?Q?4gTwodSJhohlr7H0MtTXi3nVx3+4QLDmoFXI9ISFn+QXWq0wgoVJt2osKE1L?= =?us-ascii?Q?RGTzAW+SePL03ppkseJyc9oylu01wbIphdiWkzBfFLEdwQ3EHPpXj6bHj6Nx?= =?us-ascii?Q?+MyJ5Flg3wnkcRTBm4aBIWLNZMrw9u6gi0/BvRsLWJUHMAB56NdUqHOzM+S8?= =?us-ascii?Q?qR6SkpnPYDTkIRuOg1G4stOi5Re113cXVB/7ritmUBX7famG7cmK33vYEsUW?= =?us-ascii?Q?4jENY4DseFeMUnaBwdycrtEchGn75dZlTYLl2sn4jRWKn3tphmyZ9msDITle?= =?us-ascii?Q?E9t/OLHyHd1w3buExEoZSLJ4vnsXiEQxjzovYBdiJ31FjC+mv8rPrAXC48vF?= =?us-ascii?Q?JgqfKuONVmUB2ViEDmcTlNA7tPNugXVwwuL5pkfF1We/A5AN4rpCA+DFkTgO?= =?us-ascii?Q?nh9IAjMEOIE7NASTp88F6UUp92cYSbDKKglHrvqwEMNlBgTtDZKL1FBBFKGQ?= =?us-ascii?Q?FsebEdcZBgwJ3GXLiTj6Q/7dPGxcGKt0TDwOQtIUxWlBAHhjB1iW3dGPOUMv?= =?us-ascii?Q?UuCTUapApoD8LfG0ksYY8WKZAGvKR2HrqMtaVbl05WGqM4YDvaLza1z2xslz?= =?us-ascii?Q?HgNEAUWYrcRSZSllRT6Ed15c1uxK8jaAsqXDMd/Q4yE8WgOrncATNA8+9D/g?= =?us-ascii?Q?A7uGejzDoLhdJN7NvFRfCziSHE7BgBcNATVGSPJGPpKbOPg+uNLzitDF1e8r?= =?us-ascii?Q?hJWFlRNIEdIj1+9aChPYllpG6h/LAErvdZjf08c3ZD5RcvFYf48wDEEqWOSY?= =?us-ascii?Q?Pu7mJrWrFYDahNmNvwz3mepp6WOBd9xWOooc4Mk8E2AbybVBIhlRVR7UmPDv?= =?us-ascii?Q?FVE6oZOq1w09IokT214U0osvMx+DLQMkRAhqfIQxGD/yw2FdXiyUbjyXRAGO?= =?us-ascii?Q?ftCkiM7wN4kyxCBQNpLO4dKz6v8+ZTviilM1Kftn9MRyO175b9fBR9G8BuRg?= =?us-ascii?Q?jsUXTcI7ReghiLyqFWwKpWoJbruCB2QZ2iIAXxIyk+XJWTkXPhu14SC3Rf8t?= =?us-ascii?Q?eN87WthsKHfn/6BmIkevq1uc9MHiKnFMg1/bQBv9eHWYQgynqZnNyEkWkGQB?= =?us-ascii?Q?qERTNFOTDovFjphGHtZmVfhz6ZD1v7e6ajitNPkTiGNu26i87sSu7ONTU3DB?= =?us-ascii?Q?w8ri9CpIaJWs9fL3dmjA4+0DKVdtfcJIOOC+KUYSMNgloZYiMXNf2FkvSjdd?= =?us-ascii?Q?aWTLy+8wD+aXkaIdDWurOvUGQ3BEh+Uv/5Kg+Sc+J1q1a7uErK2O48gejLig?= =?us-ascii?Q?KKvY159EQp3i6twmbkliUscyjG/Bvv0lGdGf7y0N5ElVrtjHkDD7eWex0azn?= =?us-ascii?Q?ZfiMisWMfP67G3ek6znWrF/eT55nO/P/aiEbMCsyfl6NkI+euZLke6vMQpTa?= =?us-ascii?Q?qPKkTdhKqp/r9A/O+dyHD44mCsEz07JSOLhnxWG4FADnG2vLhIQNBoTXinHK?= =?us-ascii?Q?zoO+jEIMd8h7+Pe1pA/ST2WYPk9BsbQmbOo6?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 12:09:32.3412 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 240cd76b-fda5-4dee-5571-08ddb4aa4f47 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS5PPF4ACC15C0E X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=b779239d616c0adf67eb23fd41f7ad78cfceb877 Thanks. Xueming Li --- >From b779239d616c0adf67eb23fd41f7ad78cfceb877 Mon Sep 17 00:00:00 2001 From: Dengdui Huang Date: Mon, 9 Jun 2025 21:06:49 +0800 Subject: [PATCH] net/hns3: check requirement for hardware GRO Cc: Xueming Li [ upstream commit ae68b5d91c632a1dde839123f27b0317cf094170 ] The HIP08 platform requires that data address be 64-byte aligned for the GRO feature. Most applications already use 64-byte aligned. So a check is added to avoid using the GRO function when 64-byte aligned is used. Fixes: d14c995b775a ("net/hns3: check Rx DMA address alignmnent") Signed-off-by: Dengdui Huang --- drivers/net/hns3/hns3_rxtx.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 58aa6edff4..1fb34e286d 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -276,12 +276,25 @@ hns3_free_all_queues(struct rte_eth_dev *dev) static int hns3_check_rx_dma_addr(struct hns3_hw *hw, uint64_t dma_addr) { + uint64_t rx_offload = hw->data->dev_conf.rxmode.offloads; uint64_t rem; rem = dma_addr & (hw->rx_dma_addr_align - 1); if (rem > 0) { - hns3_err(hw, "The IO address of the beginning of the mbuf data " - "must be %u-byte aligned", hw->rx_dma_addr_align); + hns3_err(hw, + "mbuf DMA address must be %u-byte aligned", + hw->rx_dma_addr_align); + return -EINVAL; + } + + /* + * This check is for HIP08 network engine. The GRO function + * requires that mbuf DMA address is 64-byte aligned. + */ + rem = dma_addr & (HNS3_RX_DMA_ADDR_ALIGN_128 - 1); + if ((rx_offload & RTE_ETH_RX_OFFLOAD_TCP_LRO) && rem > 0) { + hns3_err(hw, + "GRO requires that mbuf DMA address be 64-byte aligned"); return -EINVAL; } return 0; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-26 19:59:20.812153701 +0800 +++ 0083-net-hns3-check-requirement-for-hardware-GRO.patch 2025-06-26 19:59:17.526418038 +0800 @@ -1 +1 @@ -From ae68b5d91c632a1dde839123f27b0317cf094170 Mon Sep 17 00:00:00 2001 +From b779239d616c0adf67eb23fd41f7ad78cfceb877 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit ae68b5d91c632a1dde839123f27b0317cf094170 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index bde46733b0..f9fde3948a 100644 +index 58aa6edff4..1fb34e286d 100644 @@ -24 +26 @@ -@@ -281,12 +281,25 @@ hns3_free_all_queues(struct rte_eth_dev *dev) +@@ -276,12 +276,25 @@ hns3_free_all_queues(struct rte_eth_dev *dev)