From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4829E46A63 for ; Thu, 26 Jun 2025 15:07:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28638400D6; Thu, 26 Jun 2025 15:07:19 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 9453B400D6 for ; Thu, 26 Jun 2025 15:07:17 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-235f9ea8d08so10174765ad.1 for ; Thu, 26 Jun 2025 06:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uetpeshawar-edu-pk.20230601.gappssmtp.com; s=20230601; t=1750943237; x=1751548037; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oEmYbJVk8mEPyCG4GxGlfjC2h+EhEBw2Rx6RviTkstA=; b=E1elysDDfFrbGS19U/TB872t0U1nwGM79/FHce5vCbyxqnMxpZUwihNqEBfnrGZ2F8 +b99boPLQleERN/ZWnr4R02B6pCRg14JTzvaGMKLNUbK768/y4ujhKtJ5Z5MxdOeyNNo hzQ/YX9A8b0NhJ1Cf5gILoXUHmQofP6lbFGu/MK0Yj2gIpVe0Sy8GsoORoAoytACsvZW tm3+G9DkBzxNCqUXO6qciuxFKN1df4tH4Eit//bPE98L0ZCILAITKkT+BvtrAlMtogN9 mmaPoRmceVzc7Q8Te5Oh0tq0Oc+0oGw6gvu82EDEBghC5ZhRdTQNU/Azodl7sWUnYhq5 TrgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750943237; x=1751548037; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oEmYbJVk8mEPyCG4GxGlfjC2h+EhEBw2Rx6RviTkstA=; b=eIfPMesXeYg3PM/dyp670zOjpl774oJ6qoZ5K3QRo6W51dzzyGvoLIfQdkWijbpVUc h0p85WIdRcGJXOGzK8bwoLnRVQF3niUJNtRvheJuBXCOnW5ZtAGk4NdXOjwgMqK0m4W0 tEgnSs0Gf3h07OVec4RnId9HYA9/+L0iL0zY4BZub5WIyeK+h9jn+qoj6ArQY1bpZPRy O9O8jupfYkNVMFldZH+enZ7HQFFKV5aClgCVPIgTbcferM3b0s2EuMAbDby229b4syrK IR/fEih4pa1LGkyJYLIlT5fvy9OcmwUcR1lAhOJBR7qrj3cFY0g/F2zc0sJA42Nw9O+0 2aSA== X-Forwarded-Encrypted: i=1; AJvYcCXMNas/2IOTY0fk1IqCwwdGaovhAaGizr2wMhTb3JlHbjnqgn+oRbp+Ni5PhNidj46n0seNL0A=@dpdk.org X-Gm-Message-State: AOJu0YxLmkVGKDc/H6TShxQJCyyT0rPl1UyloLCJMquKjpzyOdAaXHcl S0BvtpDF7Ui8pS6Fa5NcHnSFxMvoM4sMFkVJ/yO4kvxK/vM9wwiNxhzAoyQpf0iww1M= X-Gm-Gg: ASbGncsUnmWjC2BFi/qrZFrg5nrfnAamH09+AsIVY6aZxTxBGkjLEwKHSZwMaHWNX7j rrI/pOzBOchILB7/UbaxQblYC6O+ZcZ8zgzwDamFMEK2lyl8vo6Iq8kZID3poVEnD4A+/ZVcMuw QGrjHGrZoyvaVbWUZYXMFra++dE5raHAzZqWowBMP009Z3kI4LT16ylB8QUU8Vw+7mkljseaemC 36GOUyXOEGQOXehTXjIA2Gt4oefK7ela6tTFRk250CAj0r+busolinvp5ph3m5ZufKV+JPvaL7U AqAP3011c3hDf16VH0M6nYUFfpu7Y+F1tR0uCqu8f/yTH8HjYLcMt+MB/0GYZ0wRdNOraCJx0Up zPwX/ueTL4yre X-Google-Smtp-Source: AGHT+IExY1G3CwrPJudT1WxTZgDt7Foh1dgVnoTk2Rm3CVtp1IzAiSQCbKMQEJi4fPxRwT6mVIIKSg== X-Received: by 2002:a17:902:f711:b0:236:6f5f:caaf with SMTP id d9443c01a7336-23823fd61bfmr116977045ad.15.1750943236471; Thu, 26 Jun 2025 06:07:16 -0700 (PDT) Received: from localhost.localdomain ([64.62.143.197]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d867c0d9sm155104415ad.177.2025.06.26.06.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jun 2025 06:07:16 -0700 (PDT) From: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> To: dev@dpdk.org Cc: rasland@nvidia.com, Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>, stable@dpdk.org Subject: [PATCH v2] net/mlx5: fix segfault on indirect action age query with conntrack Date: Thu, 26 Jun 2025 09:07:02 -0400 Message-ID: <20250626130702.3921887-1-14pwcse1224@uetpeshawar.edu.pk> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org v2: - Added missing check for AGE + CT conflict in flow_dv_query(). - Removed unnecessary null check from flow_aso_age_get_by_idx(). - Added Fixes tag for LTS tracking. - Ensured .mailmap and Signed-off-by addresses match. This patch fixes a segmentation fault that occurs when querying the AGE action of a flow rule that uses indirect connection tracking (CT). Background: AGE and CT indices share a union in the mlx5 flow struct. When using CT without age, the age index is invalid. Querying AGE in this case leads to a crash due to reading an invalid pointer. Fix: Add a check in `flow_dv_query()` to prevent AGE queries on indirect CT actions. This is the correct fix rather than null-checking the pool. Steps to reproduce: 1. Create an indirect CT action: flow indirect_action 0 create ingress action conntrack / end 2. Create a root rule with jump: flow create 0 ingress pattern eth / ipv4 / tcp / end actions jump group 3 / end 3. Create a group 3 rule using the indirect action: flow create 0 group 3 ingress pattern eth / ipv4 / tcp / end actions indirect 0 / jump group 5 / end 4. Create a group 5 rule matching CT state: flow create 0 group 5 ingress pattern eth / ipv4 / tcp / conntrack is 1 / end actions queue index 5 / end 5. Querying the first rule causes segfault: flow query 0 1 age Fixes: 2d084f69aa26 ("net/mlx5: add translation of connection tracking action") Cc: stable@dpdk.org Signed-off-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> --- .mailmap | 1 + drivers/net/mlx5/mlx5_flow_dv.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/.mailmap b/.mailmap index 8483d96ec5..6126f7e472 100644 --- a/.mailmap +++ b/.mailmap @@ -812,6 +812,7 @@ Kevin Scott Kevin Traynor Ke Xu Ke Zhang +Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> Khoa To Kiran KN Kiran Kumar K diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index c217634d9b..7ce093e075 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -18134,6 +18134,11 @@ flow_dv_query(struct rte_eth_dev *dev, error); break; case RTE_FLOW_ACTION_TYPE_AGE: + if (flow->indirect_type == MLX5_INDIRECT_ACTION_TYPE_CT) + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_ACTION, + actions, + "age not available"); ret = flow_dv_query_age(dev, flow, data, error); break; default: -- 2.43.0