From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD6FB46A9C for ; Mon, 30 Jun 2025 14:26:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7D7C402E1; Mon, 30 Jun 2025 14:26:35 +0200 (CEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id B79BC40667 for ; Mon, 30 Jun 2025 14:26:34 +0200 (CEST) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-451ebd3d149so8835575e9.2 for ; Mon, 30 Jun 2025 05:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751286394; x=1751891194; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=016RDXevAYKm08XP0MPNyVWXc3en/Xwjt3ifED2KUnE=; b=cgQpyXMPaHgD2L451mdJBkb2mietb+3fMy78yPsieHfv0WrMTktG+cj86cm9d1SZuD XCf2C/JbCYkvMX8HdnTTc0CvQId0AJ+FUOAR+fPR0hJuNXqTOB0g9uPEbIR4J2eMaNj/ gfb/6ocdU4GzidZoxAy79PhkKIXCGHxuY460EXQzeQ/28D19LOjo+xDRBeAgpvawT+eU PnFRNkM3cXcOFJO9pJH7kyXKcvEmDaDbwiUB9O/xKc6MsNdBq4B8WwDPYLDxAj8dVzQa L+AHoi/w33Hzyk7HNbQQnXin76+KqUvB7ew835w/jmPAm6gOYUanzZBzH3lwAdEfdIZn CTsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751286394; x=1751891194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=016RDXevAYKm08XP0MPNyVWXc3en/Xwjt3ifED2KUnE=; b=NZOueNIHkfAl+mxJK6ABT3rM+P/akbepRwk3gyvZWVSqrDt4HI6PDQsVOeQsYbMGOm wQJdzE2mxMRuIbGs81p8pLXmXnuFqmd+eBsc3ZPtbBxZK/K+vjJhJbK2Pfh3u1YoQdw2 MYS7sse69smFNYqexqiNRz4FsyXaMEgdbtYczGUJX5S6oyvviCykhdrWUBtEYc7qt622 8nJtsKYb5qk1INtY4xZwh9Sf6CHGOZ5svl0oGEaUNF6LeI3A+GnGx3cWKfRt/aDlR6IZ 4B3kJUaK3OPZIvRUJiaf/60AK7KoehFMtoR1//+4p28oa4+Dz2Np4M13+vLSvIBtWusT tTcA== X-Gm-Message-State: AOJu0Yw+M8/VAul7T83tjlV9L77Ajpwp3Qz8yAdjCzZrEhzt3hmI+sun 3OvL66kC+vmKQTm8xZJ3Z69JVXVntC2xj9v2CButsrHIDiK8tDLZg2QADMpHxEUB X-Gm-Gg: ASbGncv64nPWAnjt1EO914wcmXeH6LxjfgZNKQfzSZGcwhRA9aqIAnSdoPaS7h3k6kT M0xAnh9qQ83XFWBMbDIKIjBc9gkfF6KLV6MCgraMocVyYCTnGhb+F6Q4mM4XkwC1AXhvtzQ3ZQW 25hwXCG47O9zl8XV1Ec08aDYtuobl2J6Vdi5rqo8Rb3taKqo5LJT7t3GvPwhGKHuuHSsZxK64qE SsP0wCFaSdUI8zvYNzsAbIvt8rCa8tq6FFVJlkLCy9tFJ/2ra/zbCSy8UK3tJtreDlZXnJeeLXz fOMEFFSNYMd189/75g27bkd9oMdHAxJ5ILNt6xZiorvvchdLyDsQYl4pTdhKEDgzTz0= X-Google-Smtp-Source: AGHT+IFIdbc8uGIrjj5H91JHzNDFn6jkTCB4QfIyXlAnDRXNUQoz2wx9tGwZHZLsyPp89WziTDpBbg== X-Received: by 2002:a05:600c:5493:b0:44b:1f5b:8c85 with SMTP id 5b1f17b1804b1-4538ee3b945mr130816205e9.13.1751286394093; Mon, 30 Jun 2025 05:26:34 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:ded1:f637:68f:c2a6]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a892e52c8esm10393777f8f.55.2025.06.30.05.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 05:26:33 -0700 (PDT) From: luca.boccassi@gmail.com To: Rakesh Kudurumalla Cc: dpdk stable Subject: patch 'examples/ipsec-secgw: fix crash with IPv6' has been queued to stable release 22.11.9 Date: Mon, 30 Jun 2025 13:25:43 +0100 Message-ID: <20250630122556.1133654-13-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250630122556.1133654-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-72-luca.boccassi@gmail.com> <20250630122556.1133654-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/02/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a329f9ce9bf4209d4b1a1d2eca30a1978d19c882 Thanks. Luca Boccassi --- >From a329f9ce9bf4209d4b1a1d2eca30a1978d19c882 Mon Sep 17 00:00:00 2001 From: Rakesh Kudurumalla Date: Thu, 27 Mar 2025 12:33:00 +0530 Subject: [PATCH] examples/ipsec-secgw: fix crash with IPv6 [ upstream commit d03869e8e9c7c46bf7637d221ca6921516764109 ] While running ipsec-secgw application if IPv6 rules are not configured in IPsec configuration, LPM look up fails and destination port is updated as BAD_PORT. During process_packet ethernet_hdr is updated resulting in crash due to out of bound. This patch fixes the same. Fixes: 6eb3ba03995c ("examples/ipsec-secgw: support poll mode NEON LPM lookup") Signed-off-by: Rakesh Kudurumalla --- examples/ipsec-secgw/ipsec_neon.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/ipsec_neon.h b/examples/ipsec-secgw/ipsec_neon.h index 8b93b4b52e..fc04000336 100644 --- a/examples/ipsec-secgw/ipsec_neon.h +++ b/examples/ipsec-secgw/ipsec_neon.h @@ -23,6 +23,7 @@ processx4_step3(struct rte_mbuf *pkts[FWDSTEP], uint16_t dst_port[FWDSTEP], uint32x4_t ve[FWDSTEP]; uint32_t *p[FWDSTEP]; struct rte_mbuf *pkt; + uint16_t port; uint32_t val; uint8_t i; @@ -34,7 +35,8 @@ processx4_step3(struct rte_mbuf *pkts[FWDSTEP], uint16_t dst_port[FWDSTEP], *l_pkt |= 1; p[i] = rte_pktmbuf_mtod(pkt, uint32_t *); - ve[i] = vreinterpretq_u32_s32(val_eth[dst_port[i]]); + port = (dst_port[i] == BAD_PORT) ? 0 : dst_port[i]; + ve[i] = vreinterpretq_u32_s32(val_eth[port]); te[i] = vld1q_u32(p[i]); /* Update last 4 bytes */ @@ -76,6 +78,7 @@ process_packet(struct rte_mbuf *pkt, uint16_t *dst_port, uint64_t tx_offloads, { struct rte_ether_hdr *eth_hdr; uint32x4_t te, ve; + uint16_t port; uint32_t val; /* Check if it is a large packet */ @@ -85,7 +88,8 @@ process_packet(struct rte_mbuf *pkt, uint16_t *dst_port, uint64_t tx_offloads, eth_hdr = rte_pktmbuf_mtod(pkt, struct rte_ether_hdr *); te = vld1q_u32((uint32_t *)eth_hdr); - ve = vreinterpretq_u32_s32(val_eth[dst_port[0]]); + port = (dst_port[0] == BAD_PORT) ? 0 : dst_port[0]; + ve = vreinterpretq_u32_s32(val_eth[port]); val = vgetq_lane_u32(te, 3); #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-30 13:21:22.255398768 +0100 +++ 0013-examples-ipsec-secgw-fix-crash-with-IPv6.patch 2025-06-30 13:21:21.751057449 +0100 @@ -1 +1 @@ -From d03869e8e9c7c46bf7637d221ca6921516764109 Mon Sep 17 00:00:00 2001 +From a329f9ce9bf4209d4b1a1d2eca30a1978d19c882 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d03869e8e9c7c46bf7637d221ca6921516764109 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org