From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EC1446A9C for ; Mon, 30 Jun 2025 14:26:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76C00402E1; Mon, 30 Jun 2025 14:26:50 +0200 (CEST) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mails.dpdk.org (Postfix) with ESMTP id 7250F402E1 for ; Mon, 30 Jun 2025 14:26:48 +0200 (CEST) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-451d6ade159so13455065e9.1 for ; Mon, 30 Jun 2025 05:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751286408; x=1751891208; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SJJtNddnzRqAVDdfhdsc/Xt2zhwuTaUAPmerP8qSPxc=; b=SKMwvmWsmnLq1zqmgz0PlFKuw7DOFUi3nLXR0tYOGXdJL7vPEPQ0P+Ysve2+RBmSSo vUNTvHkWdjIzpMpBYn0+vp6s0+q4ERlycqxBpXiadXkhmRGWeiFRSUr/qJkf+BGcyiTu Y/1lStu4sSKyWnhIcHmKKuyr4oOj3sT2hEDc69aBQ2SsE/dde3ylGIPmnX006mNwpV5S bKNHjampdy761e2Lr+0wjZK+ctPsaw54J6UqdkNn4uRC5GpgyHXjO+DeUGdFDW8QxaeW kjVD5+Wh+LEP9XchxcF1CLRstoujq3upYGDT9ai+DZLfze5Sa7tA3g6tIfxzWr/XP5Ju Jrww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751286408; x=1751891208; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SJJtNddnzRqAVDdfhdsc/Xt2zhwuTaUAPmerP8qSPxc=; b=mxBF/4tgljvRr/qUyCXhGFag5sfSUSIcNnG9eCOHqk3kmOs7ZWT/b/mxUWDtKQdbg9 PhF98kIGmKxOPFLAlJyNcMMJofVUKab+q+Fyki7ZYRVYpj/3t01ktfWIsKZ7NI0oDj/u Eel6+SeX0qxcKtf9A/bkiXttO09R5nn1SXBScAPPcNhugrj8crmNduRF7qQgZlPyLQEk SKQMMmYCbYU+SK9aqxpV9k87CGgqy1X3+MD4fNKQUbeSusLtblxHp1+DFgFIb6zx8uYn P73DvjKA5vZcB0eqvD8X++5/SNOZ9/teJlCOIfcXe1476/nKN+ZrOm8BELVaLqHouSIM K7sQ== X-Gm-Message-State: AOJu0YwlUz2JLLjeHm9Gti5fWMAHppfePHCVhdco6zw0vVsxRb4PXvUP w7LIp5BSVa12uiJ9ZSXlNahkwsLRLA+IQEeaEJdpgRN90Ch5jQ8MTynFxYOMgu2z X-Gm-Gg: ASbGncsrFrB3brDrmppaIubcVMPCVodyRzS+Inhsdvirq4Dh950K/OoDVC3XJzvfn41 MMYmNIgiU6H0gTrpOnrc7jKZQ3prsQFDUiKwMY9TVRAInaUIebQrlLkuDWjkVCutPkdsvRE8BlX 5a4VzTjZ+g5/TWpQwaX4jglMtLB323KVQaQfAtqPuV7pvNGh9LcI1pg4s2+juY5L3LU4ZhigH0n 9iEeCBUbiOBXXDCDXlM2AIXjbDjsOxlytM4xiFoaTSfaLSzuF0EzlT0r4bROCikXPA+87t4pqCg I2TVvoVVjaMuJJry6EdEFl5+8aVeIP6aKNQaiyFWiMdktV0CsgCva+RRnKExvhtN8Ls= X-Google-Smtp-Source: AGHT+IESHyfLdtBcUjJoesYMxg0me8l0hmo8KQspNxeRzbAQEff7WKg/cA2vRqdiXT9NptRM0IWQ8g== X-Received: by 2002:a05:600c:1389:b0:43c:f70a:2af0 with SMTP id 5b1f17b1804b1-4539b3f67c8mr69176035e9.16.1751286407733; Mon, 30 Jun 2025 05:26:47 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:ded1:f637:68f:c2a6]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-453823ad20bsm164333295e9.20.2025.06.30.05.26.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 05:26:47 -0700 (PDT) From: luca.boccassi@gmail.com To: Nithinsen Kaithakadan Cc: dpdk stable Subject: patch 'test/crypto: set to null after freeing operation' has been queued to stable release 22.11.9 Date: Mon, 30 Jun 2025 13:25:46 +0100 Message-ID: <20250630122556.1133654-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250630122556.1133654-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-72-luca.boccassi@gmail.com> <20250630122556.1133654-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/02/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/480d514addd5549a9bcf5b0f492e69c2b4908310 Thanks. Luca Boccassi --- >From 480d514addd5549a9bcf5b0f492e69c2b4908310 Mon Sep 17 00:00:00 2001 From: Nithinsen Kaithakadan Date: Wed, 18 Jun 2025 12:54:09 +0000 Subject: [PATCH] test/crypto: set to null after freeing operation [ upstream commit 74164b5881526bffc142eb53b89d8900366222d3 ] Set pointer to NULL post rte_crypto_op_free operation. Fixes: 3bf0db60f5d2 ("test/crypto: add queue pair depth used count") Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") Fixes: ffbe3be0d4b5 ("app/test: add libcrypto") Signed-off-by: Nithinsen Kaithakadan --- app/test/test_cryptodev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 92113a55d2..8d58510e2d 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -1454,6 +1454,7 @@ ut_teardown(void) /* free crypto operation structure */ rte_crypto_op_free(ut_params->op); + ut_params->op = NULL; /* * free mbuf - both obuf and ibuf are usually the same, @@ -12335,6 +12336,7 @@ test_multi_session(void) "Failed to perform decrypt on request number %u.", i); /* free crypto operation structure */ rte_crypto_op_free(ut_params->op); + ut_params->op = NULL; /* * free mbuf - both obuf and ibuf are usually the same, @@ -12462,6 +12464,7 @@ test_multi_session_random_usage(void) "Failed to perform decrypt on request number %u.", i); rte_crypto_op_free(ut_paramz[j].ut_params.op); + ut_paramz[j].ut_params.op = NULL; /* * free mbuf - both obuf and ibuf are usually the same, -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-30 13:21:22.357035644 +0100 +++ 0016-test-crypto-set-to-null-after-freeing-operation.patch 2025-06-30 13:21:21.759057628 +0100 @@ -1 +1 @@ -From 74164b5881526bffc142eb53b89d8900366222d3 Mon Sep 17 00:00:00 2001 +From 480d514addd5549a9bcf5b0f492e69c2b4908310 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 74164b5881526bffc142eb53b89d8900366222d3 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 7535ef6974..5229ac2bf6 100644 +index 92113a55d2..8d58510e2d 100644 @@ -22,6 +23 @@ -@@ -2625,6 +2625,7 @@ test_queue_pair_descriptor_count(void) - - rte_pktmbuf_free(ops_deq[i]->sym->m_src); - rte_crypto_op_free(ops_deq[i]); -+ ops_deq[i] = NULL; - } +@@ -1454,6 +1454,7 @@ ut_teardown(void) @@ -29,2 +25,3 @@ - return TEST_SUCCESS; -@@ -14789,6 +14790,7 @@ test_multi_session(void) + /* free crypto operation structure */ + rte_crypto_op_free(ut_params->op); ++ ut_params->op = NULL; @@ -31,0 +29,4 @@ + /* + * free mbuf - both obuf and ibuf are usually the same, +@@ -12335,6 +12336,7 @@ test_multi_session(void) + "Failed to perform decrypt on request number %u.", i); @@ -38,2 +39,2 @@ -@@ -14933,6 +14935,7 @@ test_multi_session_random_usage(void) - ut_paramz[j].iv); +@@ -12462,6 +12464,7 @@ test_multi_session_random_usage(void) + "Failed to perform decrypt on request number %u.", i);