From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C142D46A9C for ; Mon, 30 Jun 2025 14:27:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD17B4066C; Mon, 30 Jun 2025 14:27:08 +0200 (CEST) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id EEE3F402E1 for ; Mon, 30 Jun 2025 14:27:06 +0200 (CEST) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4537edf2c3cso42850775e9.3 for ; Mon, 30 Jun 2025 05:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751286426; x=1751891226; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hcrxqyFvdRzdA09+rBW5NcOfm9mmbmC6DQMrzFBkkdI=; b=AYjoBRi3asiHWoHHWzUIdtFg9BRgxnQJltS5ErnFpoI7ejSw54RCyEraw96LteVzIu v7KrNYQrHumNamKauSGVYnduPtDYSGtUiJDuUR43DzwbC1xuPYNLXuFP0gS8qjrJynug 1RJzTZvJmzEXjZNkRFTpBuHqVYRuUD5AQ5uo1QK/yM1RaMRn5K3lkaCr0fpniW3r/c3t kyNpM5ZEcTPe2rxJZ4049RZtmu2gWCuGmHMwS2ipthAf9kXkZb2u1B2A3lvD4RUSJWWE 58+MUvZbaqZaXblHZVomV26csBFId4w0eNwXPse1apnQ+ej0Z1l+KoKicpWmH85zw7fD WPlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751286426; x=1751891226; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hcrxqyFvdRzdA09+rBW5NcOfm9mmbmC6DQMrzFBkkdI=; b=s9LKWZRTR6vugcxt5YN5LxnIYwTrYfYii42AN1eTqEsiRXaxUYItGW2Htd+jXGOaIx UkPwIUVrbbEZs+Ul8ostgdc2pc7WhP5wW/Ii3sRQQDuVG8V+Ey0fgz+q2iace0tRQvwl FAHhT/ukDIBVcNongAnVZ8zMydp9YptijJace+AR41v6LC+vX4Y2AuekjkmlTUZysMQE 51fqud2TemplkyVH8B9lGZe/81RZPRMWl1eGZOY0DpcpMJAshSufKzVBsRZ1Fbfi62gc qZDh+fU2Opmd6ndMgztgHd4jyY6uf3YN5rryBvHgki9C5eQwS1c+R3QSGaOJM9M69oTq fBKA== X-Forwarded-Encrypted: i=1; AJvYcCXQ3KUF8cQMS/hj5JIgx+rXwNAPk4Tp6UmlxwDOzcnyq2t/Qvf5xkOvNNMqMYSeDpoTCJxEt2o=@dpdk.org X-Gm-Message-State: AOJu0YwQ7kvfyFgyC9NfGUbGWlJMKyQvgU8UaqMdevisA+HYZbCUlt5m 5ZXZRFwIrU+NacDmgsG9G684Wn6D6zcQoFW1LQ0mrGF/+SV/LC1Oq0OfXXbiMDu7 X-Gm-Gg: ASbGnct/i6OvSPuYRyzM2aV28hybr7JJpYgfZTHTqXC75pNxJ6Mx8EltuZGjG5LxyMj bVCaqJft+J1E+mMYPZcFXsSQEPzzG7U57MHY2AYf4pmfvUVZR66/5w2kWGNKyUOfrb/Ml1LRT7K txeLOGcje/wtsYWWDkNzv058EqBiPMPC+O5oiedW+6I/9lefSxDSpKA6+MQLeJ2lM4TI4r54+IS ttdvRKOMhM1biotQLBZEG8IuasPDvUiMvJJ9Kt5WHkjR6DxYAhwTbNQMGA5ViKrM+NH/xPRzK4R VdRUrbDf4HblJwBPTZEZ4XhAF0LHJgwnh/RaC7GdysFhs5nkk9b2lA2+Cb7VOTHkqkmiPIxouGu Mhw== X-Google-Smtp-Source: AGHT+IEr/u3IJXqg6RtY9iGdSpO7wXFxR/E8DGkWJ1vc747srOlbJWU9ViyPZHL8tcNLD5qvuMI3Ng== X-Received: by 2002:a05:600c:8b18:b0:43c:efed:733e with SMTP id 5b1f17b1804b1-4538ee27c3emr128074795e9.14.1751286426294; Mon, 30 Jun 2025 05:27:06 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:ded1:f637:68f:c2a6]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-453823c42e1sm162827035e9.37.2025.06.30.05.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 05:27:05 -0700 (PDT) From: luca.boccassi@gmail.com To: Pravin Pathak Cc: Pavan Nikhilesh , dpdk stable Subject: patch 'app/eventdev: fix number of releases sent during cleanup' has been queued to stable release 22.11.9 Date: Mon, 30 Jun 2025 13:25:53 +0100 Message-ID: <20250630122556.1133654-23-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250630122556.1133654-1-luca.boccassi@gmail.com> References: <20250612210733.2506558-72-luca.boccassi@gmail.com> <20250630122556.1133654-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/02/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/dddccf4a49cfa280e68da7e4c9bdcd04ad076286 Thanks. Luca Boccassi --- >From dddccf4a49cfa280e68da7e4c9bdcd04ad076286 Mon Sep 17 00:00:00 2001 From: Pravin Pathak Date: Sun, 22 Jun 2025 13:13:52 -0500 Subject: [PATCH] app/eventdev: fix number of releases sent during cleanup [ upstream commit c2ef482eaa0928ee47abe71cd740456a68d88e77 ] During cleanup, only send releases for events app was not able to enqueue. Current code is sending releases for entire dequeue burst. Fixes: f0b68c0b2af7 ("app/eventdev: clean up worker state before exit") Signed-off-by: Pravin Pathak Acked-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_common.c | 4 ++-- app/test-eventdev/test_pipeline_common.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c index 140c0c2dc3..728cbe6b4c 100644 --- a/app/test-eventdev/test_perf_common.c +++ b/app/test-eventdev/test_perf_common.c @@ -1216,9 +1216,9 @@ perf_worker_cleanup(struct rte_mempool *const pool, uint8_t dev_id, for (i = nb_enq; i < nb_deq; i++) rte_mempool_put(pool, events[i].event_ptr); - for (i = 0; i < nb_deq; i++) + for (i = nb_enq; i < nb_deq; i++) events[i].op = RTE_EVENT_OP_RELEASE; - rte_event_enqueue_burst(dev_id, port_id, events, nb_deq); + rte_event_enqueue_burst(dev_id, port_id, events + nb_enq, nb_deq - nb_enq); } rte_event_port_quiesce(dev_id, port_id, perf_event_port_flush, pool); } diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index b111690b7c..264eace81b 100644 --- a/app/test-eventdev/test_pipeline_common.c +++ b/app/test-eventdev/test_pipeline_common.c @@ -707,10 +707,10 @@ pipeline_worker_cleanup(uint8_t dev, uint8_t port, struct rte_event ev[], rte_pktmbuf_free(ev[i].mbuf); } - for (i = 0; i < deq; i++) + for (i = enq; i < deq; i++) ev[i].op = RTE_EVENT_OP_RELEASE; - rte_event_enqueue_burst(dev, port, ev, deq); + rte_event_enqueue_burst(dev, port, ev + enq, deq - enq); } rte_event_port_quiesce(dev, port, pipeline_event_port_flush, NULL); -- 2.47.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-06-30 13:21:22.622005580 +0100 +++ 0023-app-eventdev-fix-number-of-releases-sent-during-clea.patch 2025-06-30 13:21:21.767057807 +0100 @@ -1 +1 @@ -From c2ef482eaa0928ee47abe71cd740456a68d88e77 Mon Sep 17 00:00:00 2001 +From dddccf4a49cfa280e68da7e4c9bdcd04ad076286 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c2ef482eaa0928ee47abe71cd740456a68d88e77 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 4709de8b07..f77557e765 100644 +index 140c0c2dc3..728cbe6b4c 100644 @@ -24 +25 @@ -@@ -1833,9 +1833,9 @@ perf_worker_cleanup(struct rte_mempool *const pool, uint8_t dev_id, +@@ -1216,9 +1216,9 @@ perf_worker_cleanup(struct rte_mempool *const pool, uint8_t dev_id, @@ -37 +38 @@ -index 204117ef7f..c1382ac188 100644 +index b111690b7c..264eace81b 100644 @@ -40 +41 @@ -@@ -684,10 +684,10 @@ pipeline_worker_cleanup(uint8_t dev, uint8_t port, struct rte_event ev[], +@@ -707,10 +707,10 @@ pipeline_worker_cleanup(uint8_t dev, uint8_t port, struct rte_event ev[],