From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79E1946B1F for ; Mon, 7 Jul 2025 18:09:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71F724065A; Mon, 7 Jul 2025 18:09:06 +0200 (CEST) Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by mails.dpdk.org (Postfix) with ESMTP id 76C1A40287 for ; Mon, 7 Jul 2025 18:09:04 +0200 (CEST) Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-70109af5f70so34200496d6.0 for ; Mon, 07 Jul 2025 09:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1751904543; x=1752509343; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+I0a8dKbjPlWw5RPGHhAQXZhxDgwM0ketz4fMVUOJSE=; b=Z8ZWonaeK5DsF2otqEsndLQKZw697BufRGs5/40FgVFOZftadOVK08UqdobCryFrJ2 NPY+p9QWB/h+npU80U16PlDrOB1xOJYPUlzlvaje3osy4oiDRugjpx93Wftb81Ib73yI IzESkIQp+gwqLEtBO/u7uNkAB3GsAUXM8lYiVJ/0jHp6MT93O4OyI+NSMSzAWzGfnjfZ CnyenNb2DUFSLpjg4AZRJgvNkbIE96HeHCQrjpZDLFPafvs5+CZMV0T8p8sY/jEti1z7 haKyhYZPnyGovR6nEyF+qlVH4z+z1lENgbBWEY8YYTMebqGvDZ++0p44kyQahfYeCkUm KclQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751904543; x=1752509343; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+I0a8dKbjPlWw5RPGHhAQXZhxDgwM0ketz4fMVUOJSE=; b=cMRv0BctinhyqtaR0kTqZv6OHkRSxkpwHjFr142XYuEto+eXGxxbzohBhhYIscknOS ziSjmcO8b3kNeW+S4m5u+0vvYHo1iETYieKVlg8HDbtu72pkNWyc6WkimNPCcpsj1Hox 3tCn2bJmbGLuYO3ngbdVWxFxmL/9fYRKD5xGqxhLyZ2iIxtonCx2aW9uQ3j6fCKx3eZj 7FLiwD057hhX2/Lk34v9AKlAh78xd2BmYri5ntEnVd3uVNBNOSjAuEY4Mmn/F2N/WW6V sob1jcTGJ+YY3Fj0dokkbPQUfkl9rzemRJMyqUvGT+I4wouqHDXamZvvn9CxiXRUFdzK 55cw== X-Forwarded-Encrypted: i=1; AJvYcCU3Afs3QdZvqYZclbvFgg0y9RVRwXDLdjRq3/kDlkWKGPMlWlHZfR12tjQeocGA4lBDEaW4vN8=@dpdk.org X-Gm-Message-State: AOJu0YweY2SVfoAaAYZ1VPXvs6WUrpDVemIONvy53jOIrtMQiqMIzlNN fSQ7q2/9+sg0rSCquqfmFpsG3bgK4dpfW7gKyW3JcabCPteaGfgiv6h2GGggRzshAug= X-Gm-Gg: ASbGncsJPM8uWDCk5z+gyO7sGReyCD+b8az4UMgVXf4UBG/Jq7Igdgyso8iYTG9yI4O z36Kvw/urWKxWSxHnDRO+CfI/6JCnihIEn/SMwyzajhSbQ611keyx5S8Gh2rtvl8ieBzXNbRYY7 6nEOFjeGrj8BhFmtAKpXjMug0bcZzHtL88lumt1V4YeOrSO8MYG/WWn2h7UqFWyc0eXK+pe//hg bnuu64L2HwEOaLcWPVb5RTQ0O/NkqjUufZTbOAA5unp9d68ryGuPSeGsKtarwinzTu9Gd6Nw/51 ySe85i18NnJhhWNJp02rYrid+MHfC0ThbjMkEu6eXa+t3jQj1IP5/VNKSbvaDqjoImaclV9R+tU n/fRsfd9DnCIhPcWV5EjEykLEFZWGy3JvRqXzFBM= X-Google-Smtp-Source: AGHT+IFIUvgV+GKBhPOw0sejTYAbYHDKTBV+X2Cgqr5rOCDQvVxKwNZ6/IDa3jMjfYNemqtMKtyBdw== X-Received: by 2002:a05:6214:2608:b0:6f8:d223:3c14 with SMTP id 6a1803df08f44-702d171dd04mr136816446d6.25.1751904543420; Mon, 07 Jul 2025 09:09:03 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d51147sm61672866d6.57.2025.07.07.09.09.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 09:09:03 -0700 (PDT) Date: Mon, 7 Jul 2025 09:02:24 -0700 From: Stephen Hemminger To: Junlong Wang Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH v1 2/6] net/zxdh: fix issues related to MAC configuration Message-ID: <20250707090224.1ee10cf3@hermes.local> In-Reply-To: <20250707055621.357606-2-wang.junlong1@zte.com.cn> References: <20250707055621.357606-1-wang.junlong1@zte.com.cn> <20250707055621.357606-2-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, 7 Jul 2025 13:56:17 +0800 Junlong Wang wrote: > Fix error handling when MAC configuration fails. > This is issue was discovered during internal testing. > > Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations") > Cc: stable@dpdk.org > > Signed-off-by: Junlong Wang > --- > drivers/net/zxdh/zxdh_ethdev.c | 15 +++++++++++ > drivers/net/zxdh/zxdh_ethdev_ops.c | 34 +++++++++++++++++++----- > drivers/net/zxdh/zxdh_msg.c | 10 +++---- > drivers/net/zxdh/zxdh_tables.c | 42 ++++++++++++++++-------------- > 4 files changed, 69 insertions(+), 32 deletions(-) > > diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c > index 80053678cb..8996d86b90 100644 > --- a/drivers/net/zxdh/zxdh_ethdev.c > +++ b/drivers/net/zxdh/zxdh_ethdev.c > @@ -1265,6 +1265,7 @@ static int > zxdh_mac_config(struct rte_eth_dev *eth_dev) > { > struct zxdh_hw *hw = eth_dev->data->dev_private; > + struct zxdh_msg_info msg_info = {0}; > int ret = 0; > > if (hw->is_pf) { > @@ -1274,7 +1275,21 @@ zxdh_mac_config(struct rte_eth_dev *eth_dev) > PMD_DRV_LOG(ERR, "Failed to add mac: port 0x%x", hw->vport.vport); > return ret; > } > + hw->uc_num++; > + } else { > + struct zxdh_mac_filter *mac_filter = &msg_info.data.mac_filter_msg; > + mac_filter->filter_flag = 0xff; > + memcpy(&mac_filter->mac, ð_dev->data->mac_addrs[0], > + sizeof(eth_dev->data->mac_addrs[0])); Since mac_filter->mac and eth_dev->data->mac_addrs are both of same type (rte_ether_addr), using structure assignment operation instead of memcpy is preferred. Assignment assures that types are the same. mac_filter->mac = eth_dev->data->mac_addrs;