From: Maayan Kashani <mkashani@nvidia.com>
To: <dev@dpdk.org>
Cc: <mkashani@nvidia.com>, <rasland@nvidia.com>, <stable@dpdk.org>,
"Anatoly Burakov" <anatoly.burakov@intel.com>
Subject: [PATCH] examples/multi_process: fix cleanup on exit
Date: Tue, 8 Jul 2025 10:09:54 +0300 [thread overview]
Message-ID: <20250708070954.165222-1-mkashani@nvidia.com> (raw)
Device was started but not stopped on exit signal.
Added port stop and close on exit.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Maayan Kashani <mkashani@nvidia.com>
---
examples/multi_process/symmetric_mp/main.c | 27 ++++++++++++++++++----
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c
index f7d8439cd4e..de16608a0fb 100644
--- a/examples/multi_process/symmetric_mp/main.c
+++ b/examples/multi_process/symmetric_mp/main.c
@@ -92,6 +92,25 @@ smp_usage(const char *prgname, const char *errmsg)
exit(1);
}
+static void
+exit_cleanup(void)
+{
+ unsigned int i;
+
+ RTE_LOG(INFO, APP, "Close ports.\n");
+ for (i = 0; i < num_ports; i++) {
+ if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
+ if (rte_eth_dev_stop(ports[i]))
+ rte_exit(EXIT_FAILURE, "Error stopping ports\n");
+ if (rte_eth_dev_close(ports[i]))
+ rte_exit(EXIT_FAILURE, "Error closing ports\n");
+ }
+ }
+
+ /* clean up the EAL */
+ rte_eal_cleanup();
+ exit(0);
+}
/* signal handler configured for SIGTERM and SIGINT to print stats on exit */
static void
@@ -104,9 +123,10 @@ print_stats(int signum)
printf("Port %u: RX - %u, TX - %u, Drop - %u\n", (unsigned)p_num,
pstats[p_num].rx, pstats[p_num].tx, pstats[p_num].drop);
}
- exit(0);
+ exit_cleanup();
}
+
/* Parse the argument given in the command line of the application */
static int
smp_parse_args(int argc, char **argv)
@@ -486,8 +506,5 @@ main(int argc, char **argv)
rte_eal_mp_remote_launch(lcore_main, NULL, CALL_MAIN);
- /* clean up the EAL */
- rte_eal_cleanup();
-
- return 0;
+ exit_cleanup();
}
--
2.21.0
reply other threads:[~2025-07-08 7:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708070954.165222-1-mkashani@nvidia.com \
--to=mkashani@nvidia.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).