[PATCH] examples/multi_process: fix cleanup on exit

[PATCH] examples/multi_process: fix cleanup on exit

[Maayan Kashani]

Device was started but not stopped on exit signal.
Added port stop and close on exit.

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org

Signed-off-by: Maayan Kashani <mkashani@nvidia.com>
---
 examples/multi_process/symmetric_mp/main.c | 27 ++++++++++++++++++----
 1 file changed, 22 insertions(+), 5 deletions(-)

diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c
index f7d8439cd4e..de16608a0fb 100644
--- a/examples/multi_process/symmetric_mp/main.c
+++ b/examples/multi_process/symmetric_mp/main.c
@@ -92,6 +92,25 @@ smp_usage(const char *prgname, const char *errmsg)
 	exit(1);
 }
 
+static void
+exit_cleanup(void)
+{
+	unsigned int i;
+
+	RTE_LOG(INFO, APP, "Close ports.\n");
+	for (i = 0; i < num_ports; i++) {
+		if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
+			if (rte_eth_dev_stop(ports[i]))
+				rte_exit(EXIT_FAILURE, "Error stopping ports\n");
+			if (rte_eth_dev_close(ports[i]))
+				rte_exit(EXIT_FAILURE, "Error closing ports\n");
+		}
+	}
+
+	/* clean up the EAL */
+	rte_eal_cleanup();
+	exit(0);
+}
 
 /* signal handler configured for SIGTERM and SIGINT to print stats on exit */
 static void
@@ -104,9 +123,10 @@ print_stats(int signum)
 		printf("Port %u: RX - %u, TX - %u, Drop - %u\n", (unsigned)p_num,
 				pstats[p_num].rx, pstats[p_num].tx, pstats[p_num].drop);
 	}
-	exit(0);
+	exit_cleanup();
 }
 
+
 /* Parse the argument given in the command line of the application */
 static int
 smp_parse_args(int argc, char **argv)
@@ -486,8 +506,5 @@ main(int argc, char **argv)
 
 	rte_eal_mp_remote_launch(lcore_main, NULL, CALL_MAIN);
 
-	/* clean up the EAL */
-	rte_eal_cleanup();
-
-	return 0;
+	exit_cleanup();
 }
-- 
2.21.0

Re: [PATCH] examples/multi_process: fix cleanup on exit

[Burakov, Anatoly]

On 7/8/2025 9:09 AM, Maayan Kashani wrote:
> Device was started but not stopped on exit signal.
> Added port stop and close on exit.
> 
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Maayan Kashani <mkashani@nvidia.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

Re: [PATCH] examples/multi_process: fix cleanup on exit

[Thomas Monjalon]

09/07/2025 15:30, Burakov, Anatoly:
> On 7/8/2025 9:09 AM, Maayan Kashani wrote:
> > Device was started but not stopped on exit signal.
> > Added port stop and close on exit.
> > 
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Maayan Kashani <mkashani@nvidia.com>
> > ---
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

There's always more cleanup and error handling we can do in examples.
As they are just code examples, I assume it does not have to be production-ready.

Applied, thanks.

Re: [PATCH] examples/multi_process: fix cleanup on exit

[Stephen Hemminger]

On Tue, 8 Jul 2025 10:09:54 +0300
Maayan Kashani <mkashani@nvidia.com> wrote:

> +static void
> +exit_cleanup(void)
> +{
> +	unsigned int i;
> +
> +	RTE_LOG(INFO, APP, "Close ports.\n");
> +	for (i = 0; i < num_ports; i++) {
> +		if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> +			if (rte_eth_dev_stop(ports[i]))
> +				rte_exit(EXIT_FAILURE, "Error stopping ports\n");
> +			if (rte_eth_dev_close(ports[i]))
> +				rte_exit(EXIT_FAILURE, "Error closing ports\n");
> +		}
> +	}

Could the ethdev cleanup be integrated into eal_cleanup() so applications
don't have to care?