From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB9A346B32 for ; Wed, 9 Jul 2025 17:01:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0B8640A70; Wed, 9 Jul 2025 17:01:19 +0200 (CEST) Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by mails.dpdk.org (Postfix) with ESMTP id 0A555402DA for ; Wed, 9 Jul 2025 17:01:16 +0200 (CEST) Received: by mail-ua1-f44.google.com with SMTP id a1e0cc1a2514c-86fea8329cdso7348241.1 for ; Wed, 09 Jul 2025 08:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1752073276; x=1752678076; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=QYb3c+tpZU6cVUTudJoTu35YJvg33xuSef4JiGD+ls0=; b=vQXoYdixj2hTpWefPZIbtULijEdeQJppSB3yfPUrz3EqolbohKThCWqXsqSrtm7md4 gJ7YiHmMFwLDftxFdtpm2AJYbfR198XKJdtVK9eis0X7DEE0omt4nILiMZjQksmou0yV tfHHjgTc2rbGyucWtoG9CBUZ+VotPEufQoRjwoQlecSXLySypfjRux+I89npEKpWZj46 U6MirskzL6pZmBnqqWPm4MrAZQ99ZUKnb/RfkZZiDwDQ1vdh08xgh70aClU+9RsTVeCx r98QRZPjGEXjuRr29+7IJcD5dueIHfbo0xE3RoYYgM/4uczJtB2Y52e4bIPkssallDQa zvVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752073276; x=1752678076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QYb3c+tpZU6cVUTudJoTu35YJvg33xuSef4JiGD+ls0=; b=EJiZxuIUjkiaS3aS4AqPx+M+nowO8Z9AIFAMxUVlC8YJ5qU5l7UYA8T918ufFP7TA3 ef7YYVl8DXpJIWzZEYo8Mmf5DUrWwKDLIQHmU/BS0qoq+GG4C+tlrw2tmoAI1oYzqtgo NbojpInQN11ky9OXLGx6/8UAAAb8qecPV6x/pxJpAMbNrDv9+ZdG8Srj4IQhq3VmB3F2 +m+SgXZUsdb6+9I9L/Nm9B+TOxaZZyRIO0kIMrlvvsWqFP5LxGCqzifCrOrZSV28j44Z j5D+je4USutpI+ClOU89UtPFvQn+fIsOE7hxshfzH4AEaM/+bXgdyGqa/WjYicPyHq2G Ofbw== X-Forwarded-Encrypted: i=1; AJvYcCXDII3/qzbjZNTjMtwnCXNLsOPc8+TeEPsrmjggiKauM1Foh0ix4FSEFIZHNEnj1XkFR3ecjsQ=@dpdk.org X-Gm-Message-State: AOJu0YylztwzU+7cPd/GmnoPhlfvsACS4OGCUKqX4RDuFxS8ibLz0oCj xhLjXfiEj2L1OkzF/FvLc+vVCfeoimEPLsU+lZeWDxpDuL2N1GGj7wKkMhfLWW1nhPg= X-Gm-Gg: ASbGncu/l6wr8eqhCIG5QiOqNy2pQsAs/yhbuU1sS6oAVKfscIgwJ2c0P4G1V+bxPwy 6g7TyX25JirM0DVSGtfrJjeoB/ET53iZrcnuOWNBsEque0uomAbY25Qp/fpkVDZOt42gAtQsF91 G1Czl47n00CDEgdExBRhS60No8PrNRqngg+wx3X68dtsvbxa3buHNJkUxSPFyO7HyI3lnjiwyh3 y02Kw45goI7Gex1wRPpEdPWrG7rZrgP7lizhy9p0naQgg6bR97t1i7koCb/FifWGwKlvC45Xcwh xGQnJwnqAQm7d0/YqLwgjoi6nKxQ5AnTJtJaol3Oq1WvzV5z05X8/6WYnCx84JFyefG5sUovdfv 3BGUC2pKpfHBL3KR4QvAiM3TFKHahjCW+YhIOAwnR6T/vSu3s8w== X-Google-Smtp-Source: AGHT+IFhNWg8iPMnSwOSnvCzeUINaGUpkBLuqq2BvQv1dvobunPLqh5jGhiGSW6dJsBBtPn1LGAdKw== X-Received: by 2002:a05:6102:5cc8:b0:4e9:d951:1433 with SMTP id ada2fe7eead31-4f54a9db1c4mr1989589137.12.1752073268450; Wed, 09 Jul 2025 08:01:08 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a994a78bf3sm98472101cf.52.2025.07.09.08.01.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 08:01:08 -0700 (PDT) Date: Wed, 9 Jul 2025 08:01:04 -0700 From: Stephen Hemminger To: Maayan Kashani Cc: , , , "Anatoly Burakov" Subject: Re: [PATCH] examples/multi_process: fix cleanup on exit Message-ID: <20250709080104.62fb27dc@hermes.local> In-Reply-To: <20250708070954.165222-1-mkashani@nvidia.com> References: <20250708070954.165222-1-mkashani@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 8 Jul 2025 10:09:54 +0300 Maayan Kashani wrote: > +static void > +exit_cleanup(void) > +{ > + unsigned int i; > + > + RTE_LOG(INFO, APP, "Close ports.\n"); > + for (i = 0; i < num_ports; i++) { > + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { > + if (rte_eth_dev_stop(ports[i])) > + rte_exit(EXIT_FAILURE, "Error stopping ports\n"); > + if (rte_eth_dev_close(ports[i])) > + rte_exit(EXIT_FAILURE, "Error closing ports\n"); > + } > + } Could the ethdev cleanup be integrated into eal_cleanup() so applications don't have to care?