From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B793D46CA9 for ; Fri, 8 Aug 2025 17:32:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CF434028B; Fri, 8 Aug 2025 17:32:11 +0200 (CEST) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id 3D1E44028B for ; Fri, 8 Aug 2025 17:32:10 +0200 (CEST) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-459e39ee7ccso21999715e9.2 for ; Fri, 08 Aug 2025 08:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1754667130; x=1755271930; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jNdUi8wT8m2f3iq6zFeD5X8EcIAM/gXI/BQirdIXUsE=; b=nz9jh+7AsFCKNJQThhdnwhjXfGZjUSLRi+UxFHxG7AwEtiFMg34/aljc3tbGs6bzmK JP6VkMJsSt5bmr1Tq33wpFUXl3sdKMRCYiqS0Y1EFObfXTqDK7ruGZYM0T5/xgGzu0U4 PyEryVv9tXVl2flHFRMzxlGHphG8eQn9MwO++qAbIxVL9SiPT0j3gs0RmkFIpdzHZUOA ux5K6HONReqtEJiD/GggtQmBevrtsyJdl/K3jZd+XU6M/DwdH+eZEo2PBkMimdW+GsEX F2RblDRfY5fO3QlXydoZNiGdsRvI1TDsq3jdtmFajg3LEHk26pnXZBkWf5i7zvl5Dlsr IrHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754667130; x=1755271930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jNdUi8wT8m2f3iq6zFeD5X8EcIAM/gXI/BQirdIXUsE=; b=EjYvTC3F7WvQ6A7oZHS/+dfFD81WcJwMBARWJfw4ex4vyJi2eDfu05uqSOze67UWul Vr72mxY1+k7uoBEso2oYzO6XdDiqjukQ0QVvzvZBz2K3nGmErKa2j5zedsVy2LdG/Snd R4uGJz2U3Y2SkSs58300mNeZ0PDA54ecTfWCnP4J7+GJNaYpuGblG6pw5NYE/gyf938p +nOH2MnhK2gRNb6QS+rW0Mt93RH6M+qMkwvDy61A6O8VVBii5FDBq4+uRNDUn0fW8c+S iXNqB+LzY7Sv1KnfV//KaDc7ACO3zr/EMXoHfWN4sGoQMEHBcT/MGvM0AJkbFJEwtZzf WWIA== X-Forwarded-Encrypted: i=1; AJvYcCXsTKi7yQqnjvhDDaXlkFEcqlLwuVaLwiaJFpqTXIZ5G/fLEkYWFITEBztwOub9MTY0FRTuRvY=@dpdk.org X-Gm-Message-State: AOJu0Yw2yG5sSCqD5b+TEdDEqE1ybV4gPjNnFAYTdYSxj+Lh22UHSdpm CJg4laPMG91e9sW4bzmAds7WPPp7eOPN3UneYGZ2YtZYjmbOFnvlQTdnzi2ipWWiS0I= X-Gm-Gg: ASbGncvEMFE/EqvEat+EaZItFrG1zFzRhlOo+OA1oeqTahQkKZphC5IqiwswHSLzTEw cxcWyfL8/Tf6cA5fs8PZffb/StrKG9lq3akGqS1BU1HUEBQWeDRsuDw2oHFYSbBArYuTFMm8EgQ NM7b1fDsUipQOk2lS9bpl6N9hsq+7r10OYW74wGiFVR+RHUb/V9qs2LDbiKAiwLK0cvOrJIo5YK tpkg/+fgPDTfV5XRdqaHI5hJkl8TdQbJJ+kzDQTdsHqStCQ1jahQwLBtMQ3c01Qv3gOvJbGQtp9 hqOY3HNVJKK9tSkX89QI13sVzbZoU9XpYZ9n4g3KJEsF2EkZ8e1JnTqihOERnC/9MglmD9IFI8o kxXWajft4cmutHctI0KEs1fFg/HxkCaERSr6RleYb3YpBeoxOuxvBGgbwsTqcWtfXRhi/fpF8uK ESqpL3xw7DPw== X-Google-Smtp-Source: AGHT+IHO2V1bsaTMTAIzevoARrUfFyOd79E9ptlBERqbRbCdB46AjpbkeBFIMBwtQnU1lNqAxCE1Og== X-Received: by 2002:a05:600c:4712:b0:456:fd4:5322 with SMTP id 5b1f17b1804b1-459f4f524c2mr29174145e9.11.1754667129515; Fri, 08 Aug 2025 08:32:09 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459e78a35cdsm61373235e9.3.2025.08.08.08.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Aug 2025 08:32:09 -0700 (PDT) Date: Fri, 8 Aug 2025 08:32:04 -0700 From: Stephen Hemminger To: "Varghese, Vipin" Cc: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>, "thomas@monjalon.net" , "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , "dev@dpdk.org" , "stable@dpdk.org" Subject: Re: [PATCH] [PATCH v4] lib/ethdev: fix segfault in secondary process by validating dev_private pointer Message-ID: <20250808083204.0174ac6b@hermes.local> In-Reply-To: References: <20250729143420.0fd7b627@hermes.local> <20250730050702.74381-1-14pwcse1224@uetpeshawar.edu.pk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 8 Aug 2025 03:49:01 +0000 "Varghese, Vipin" wrote: > [Public] > > Since somehow the email are split it is difficult to see the indexing > > > > > Caution: This message originated from an External Source. Use proper caution > > when opening attachments, clicking links, or responding. > > > > > > Hi Stephen, > > > > Many thanks for diving deeper into the issue and sharing the insights. > > > > I agree. given that the primary tears down all the devices on exit, the secondary is > > left with dangling pointers and inconsistent state. > > Secondary if PMD should not be attempting to cleanup (especially for ethdev_ptr shared from primary) I agree to that. > But should not be covered in library or PMD. While cleanup for other needs to be done properly > > Without a mechanism to notify or synchronize that teardown, > > You already have health check added in the code for identify if primay is still alive or not.. > There used to be MP thread spawned which actually piggy back the communication. Is this broken? Can you please point to git There is no easy way to handle the case where primary crashes; leaving secondary process with pointers to dead data.