From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1201746E5A for ; Wed, 3 Sep 2025 13:33:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AED540281; Wed, 3 Sep 2025 13:33:18 +0200 (CEST) Received: from mail-lf1-f98.google.com (mail-lf1-f98.google.com [209.85.167.98]) by mails.dpdk.org (Postfix) with ESMTP id E3FFC40281 for ; Wed, 3 Sep 2025 13:33:16 +0200 (CEST) Received: by mail-lf1-f98.google.com with SMTP id 2adb3069b0e04-55f6bb0a364so5690938e87.1 for ; Wed, 03 Sep 2025 04:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1756899196; x=1757503996; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UGBoDaSM1RJG7iewvZSuvsIdTYAY2IgiQT3h9ufIpHY=; b=NXULnaq0EKKGkKuyk2hQEdzaaF4gMBtdWP0GU5jty1ACAJUCd0IU4eB/l3oPC9fPh+ oy8pYIaj8WnD6SHr34Uwu6rrhPR1zoKQOQK6/CZ+vbVhwtlgIbJfwg1EnfcjLuiamMZ8 Wm+QRf/dZpC1dLYesSD+lpcH5Ffcylb3WeqduG0bX2gvbQy4D0BoV/yR2nGYPIIeaz2/ RhgqxsppYCD9Q7sBF2PUoBiduOZzYl4nUvfL3rGDLiyKbPOw/k2YCuTBdL7wr935uuG0 z/xsTxu8ffktJgK/+VCRkNluNR5sXnc6b0GgaJl2HGhoek5H/K0xIe7kUAfmYWwb2syt mxcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756899196; x=1757503996; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UGBoDaSM1RJG7iewvZSuvsIdTYAY2IgiQT3h9ufIpHY=; b=Rjq5/W2R70hzAMpWPihZYR3tY32XSTuDo+BcQyil4R6wVfbKaGLlG+crHyJzUpBHFi Ecu9tXCmTI0UFljC0Zmr96kBgeMywMRSH5PfMUSW7ChS5etmkbyf8I9IDUr0DIoe/kPo omBKalvoUch15kLJ8vovJlMdZFBtk0sZSiEr5nNvGMB2tvJ473Xt5i+cvUsazykDW2g6 WfH3Thm4wfYd9gq33Act0PpkFDZNBtJPS1B18DSDwtDuCK62F/vXUoDiotBI/q5iT69y OuBxfoOlRo5lp5ArWgqEpWwXPS0uTALMKSxuB35gkkoMwU2T5FiQi5lraH6Nge0mP8Wu GklA== X-Forwarded-Encrypted: i=1; AJvYcCWA/NGRV/AQyaSCy48bD5ECVQY3VQRlQZ6EARZlIl1WsBCMO6ueMC0tkb5FNKRIKoNLHpvCxDo=@dpdk.org X-Gm-Message-State: AOJu0YzioR2KsDZNMpn+msCgt/O2w9fAzPI3Hd9jw2n+XVbvhrDziKQT q8EWyqL/QaEn5quwWN8mky/rof4Ri0Rn6BrXfe5tRbb0tEHpxia3UiculfyIY0dFkOBQoe2qFrK jFmZRI1aWmHa+yLo06aNgpgMtB/SeHPfHUNI= X-Gm-Gg: ASbGncsAT59Ng53MsDDHm2JBW016a7tTtWM9iJhiMBEWeorZiJb9vcOh7+wUoAtoGgF k0WKaWJvAhkpkeZC1AzCB5FbJqhpv2PWGbOOwPe7ctYquLzVT9IMOBNO50bzit5XLkQyRZ570T/ AY8MhNAFO+YZ/HM04dAmmTk5hmUoNH/mq8VFxO6NnmtnjJ8wTlRKU6FX7MsySCKdkKZYfKfikgE WYVa2CvkejLxKAD4djdQXgRXSKglwUxN5M+93JdsQsXak7wmXgslMsqAeM1S6CmgrcTIWgspSEe gcZrJqjzrc2j87/+wtmYVgcu0GE3ksj0ADQI1gCn6Cf6wOEhNv3F2ejdZhLa8rEq992z7V1umR2 9X0rPCLAGvIp0zuuW5fA= X-Google-Smtp-Source: AGHT+IFIb25k/ndj/0wkgDySOa9WzdavB9byXi3SIfgP62cXlt5JEYcW4uz+CfYaiJqk2klkzkEFuZTiV45E X-Received: by 2002:a05:6512:1393:b0:55f:4506:a638 with SMTP id 2adb3069b0e04-55f7093e990mr4349308e87.41.1756899194505; Wed, 03 Sep 2025 04:33:14 -0700 (PDT) Received: from smtpservice.6wind.com ([185.13.181.2]) by smtp-relay.gmail.com with ESMTP id 2adb3069b0e04-5608ad07774sm353446e87.51.2025.09.03.04.33.14; Wed, 03 Sep 2025 04:33:14 -0700 (PDT) X-Relaying-Domain: 6wind.com Received: from localhost (vader.dev.6wind.com [10.17.1.39]) by smtpservice.6wind.com (Postfix) with ESMTP id E967A31A92; Wed, 3 Sep 2025 13:33:13 +0200 (CEST) From: Thierry Herbelot To: dev@dpdk.org Cc: Thierry Herbelot , Thomas Monjalon , Devendra Singh Rawat , Alok Prasad , Jerin Jacob , Olivier Matz , Edwin Brossette , stable@dpdk.org Subject: [PATCH] net/qede: reduce the optimization level Date: Wed, 3 Sep 2025 13:32:52 +0200 Message-Id: <20250903113252.2496087-1-thierry.herbelot@6wind.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The qede PMD stopped working under Ubuntu-24.04 (using gcc-13) when compiled with -O3 (default level for all DPDK code). A bug is opened for this issue (see Link). A first workaround is to just disable all optimizations (-O0), which restores packet Rx with Qlogic NICs. However, the performance impact is not acceptable (around 50% drop). A better compromise is to use -O1 for the qede PMD: - there is some perf impact, - but the PMD is working as expected (packets are correctly received). When compiling with both -O2 and -O3 and gcc-13, there is no packet reception when using the qede PMD. The root cause could be missing 'volatile' keywords or missing memory barriers in the qede PMD code. Link: https://bugs.dpdk.org/show_bug.cgi?id=1379 Signed-off-by: Thierry Herbelot --- drivers/net/qede/base/meson.build | 1 + drivers/net/qede/meson.build | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/qede/base/meson.build b/drivers/net/qede/base/meson.build index a6dad3ec7bcc..6c8800a3f48f 100644 --- a/drivers/net/qede/base/meson.build +++ b/drivers/net/qede/base/meson.build @@ -55,3 +55,4 @@ foreach flag: error_cflags base_cflags += flag endif endforeach +base_cflags += '-O1' diff --git a/drivers/net/qede/meson.build b/drivers/net/qede/meson.build index e1b21d6ff5cd..3c2a5205732a 100644 --- a/drivers/net/qede/meson.build +++ b/drivers/net/qede/meson.build @@ -22,3 +22,4 @@ sources = files( if cc.has_argument('-Wno-format-nonliteral') cflags += '-Wno-format-nonliteral' endif +cflags += '-O1' -- 2.39.2