From: Ivan Malov <ivan.malov@arknetworks.am>
To: dev@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Andy Moreton <andy.moreton@amd.com>,
Pieter Jansen Van Vuuren <pieter.jansen-van-vuuren@amd.com>,
Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,
stable@dpdk.org
Subject: [PATCH 3/4] common/sfc_efx/base: fix auto FEC selection for netport MCDI
Date: Fri, 5 Sep 2025 18:45:13 +0400 [thread overview]
Message-ID: <20250905144514.11698-4-ivan.malov@arknetworks.am> (raw)
In-Reply-To: <20250905144514.11698-1-ivan.malov@arknetworks.am>
Currently, the driver's request to have automatic FEC is ignored. Fix that.
Fixes: 8e79cd30230d ("common/sfc_efx/base: implement PHY link control for Medford4")
Cc: stable@dpdk.org
Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
Reviewed-by: Andy Moreton <andy.moreton@amd.com>
---
drivers/common/sfc_efx/base/efx_np.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/common/sfc_efx/base/efx_np.c b/drivers/common/sfc_efx/base/efx_np.c
index 69a5a75b6c..54305ee61e 100644
--- a/drivers/common/sfc_efx/base/efx_np.c
+++ b/drivers/common/sfc_efx/base/efx_np.c
@@ -1368,8 +1368,10 @@ efx_np_link_ctrl(
}
}
- /* The software mask may have no requested FEC bits. Default is NONE. */
- cap_enum_hw = MC_CMD_FEC_NONE;
+ if ((cap_mask_sw & EFX_PHY_CAP_FEC_MASK) == 0)
+ cap_enum_hw = MC_CMD_FEC_NONE;
+ else
+ cap_enum_hw = MC_CMD_FEC_AUTO;
/*
* Compared to older EF10 interface, in netport MCDI, FEC mode is a
--
2.47.2
prev parent reply other threads:[~2025-09-05 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250905144514.11698-1-ivan.malov@arknetworks.am>
2025-09-05 14:45 ` [PATCH 1/4] common/sfc_efx/base: fix autoneg detection with " Ivan Malov
2025-09-05 14:45 ` [PATCH 2/4] common/sfc_efx/base: default to auto fcntl " Ivan Malov
2025-09-05 14:45 ` Ivan Malov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250905144514.11698-4-ivan.malov@arknetworks.am \
--to=ivan.malov@arknetworks.am \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=andy.moreton@amd.com \
--cc=dev@dpdk.org \
--cc=pieter.jansen-van-vuuren@amd.com \
--cc=stable@dpdk.org \
--cc=viacheslav.galaktionov@arknetworks.am \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).