From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2C0A46E98 for ; Mon, 8 Sep 2025 09:04:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5D28402DA; Mon, 8 Sep 2025 09:04:48 +0200 (CEST) Received: from mail-lf1-f99.google.com (mail-lf1-f99.google.com [209.85.167.99]) by mails.dpdk.org (Postfix) with ESMTP id A0A36400EF for ; Mon, 8 Sep 2025 09:04:42 +0200 (CEST) Received: by mail-lf1-f99.google.com with SMTP id 2adb3069b0e04-55f646b1db8so4648858e87.0 for ; Mon, 08 Sep 2025 00:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1757315082; x=1757919882; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n70Ie4ymQB70BDng/k/l/99LdGND+8LCStHLPAGa/9w=; b=jCCTg0qQkkVJjzkc87Kxx6OjS8q5ykD1FoxJf2uElksn+rJNKwbbbH6pNwdmCuPT2T KDciALtozwpKPoDjK54wFBMQpSOitLCu2zLol5sx3yu3tosaC+FE87Eu+Czqn8/4eZ7h lfoXTMA9zQubhZwXg9KvScblm/Hy2cyBmv2hkKTNDtKbNBkLqXPZMe2Z64G05Dh77B8d eA8/Jnqnkd4h0ORawoUYCfCsyBfkuPYlLPnvlYCb8qELb4azMdv+KIQ5uAQpRWIlyl6/ yvvGxlXUCtlOPg0/9KUv/H1DK6jSJZPog0/nngv2IwNSMLuC7Mgzd2M58ZrZhZeFOazZ qrKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757315082; x=1757919882; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n70Ie4ymQB70BDng/k/l/99LdGND+8LCStHLPAGa/9w=; b=XE54E4PomKc2WPiW50JjDEf3BVcjsWD/+7lk6gLg4l/sZ8X/juAyt+XW/p5uTDcjjN U5GSz0C1d5nhCIV8rm9tXMODjjJ1mPl+uB1BNQflVyqoZ/rXcuulKmzeY0ZhxlqMqqfc bwisP8vSAUywvpK5AmRG3rjmvhVMpF6smlXQkwjCotdkve/7KXJgTFryvdcq8T+NjaYp e0ANiWLfkSMnTaIjCX5+UgTfF/eGREzcJlhcbG+5ZfcfDaQFAe+fLv3fvHbb691jJu28 PNnmaAUCpegCRebAAiO8juxfQq8hkM49dIVAnSdteBCryqZRN//szX8PbtMhi40QYSmO 0JXQ== X-Forwarded-Encrypted: i=1; AJvYcCWboJnCaO73CDGaD0R0CDngBeAeOpsLVIY1UvPG+6n8xBKDY83j1xCdtsleIGeZgiar9OOCCLE=@dpdk.org X-Gm-Message-State: AOJu0YwjOuJa9ndQmc+SyRmYQefZ7sXpZ4/LJlR4qR1jORXJKS2kI1je YukC8IjaobxlAtrh+hwTDCOW7M4lMjJ/CLJIVvt8h0KSdIc4bHIimElch+ua7FAlKnXjfl1vKT1 FeswhdhaCkNghDIXgpIpIBvjyT+Z7KNijolg= X-Gm-Gg: ASbGncsitnOtbERy9NFqMRaSfakKZ5dkyMwl9S/yqxCOokzfZzrDY56RDKNGCWtlMdG TUTEZsdl1vzrZ5WGOOToJ9ikxiVj7NX91PZZpGM63LDUyMpc7vkilBUVTFQQoIBmU/YOL54sAy8 FbBFCYzA2Mc7HxpL/Ce7r+n/eUdCmYko2sY+9vzpzTUG/BXqw1RGFak9NqBZ/1vcXB3AfvjT+3J IIRXyX+XzfAHwDC0KdMdZSzSkCNl3N1A4JPlOeLdyxZBbgDy3duswOTeEU9/nuXSJdcsZ/1uBtN PoWj9iWIhbV8hoCifYWBx3eZTyo8u0P2mUFnrzP0pnOBzlkljZWkhMqirnNDoqmRMnh6Kv4363t oTUNU1lhVXLlFk/3Ht9k= X-Google-Smtp-Source: AGHT+IEFSc4ja0o43ZVsKcvU38o9Z8hdjmyzV1XZln/xXmQxvq2YXjT/zx/b5zZ5/qvNwYS8qncCYjEe6FiT X-Received: by 2002:a05:6512:3b0c:b0:55f:63ef:b2bc with SMTP id 2adb3069b0e04-562603a1050mr1893390e87.8.1757315081637; Mon, 08 Sep 2025 00:04:41 -0700 (PDT) Received: from smtpservice.6wind.com ([185.13.181.2]) by smtp-relay.gmail.com with ESMTP id 2adb3069b0e04-5618ea86404sm2705455e87.36.2025.09.08.00.04.41; Mon, 08 Sep 2025 00:04:41 -0700 (PDT) X-Relaying-Domain: 6wind.com Received: from localhost (vader.dev.6wind.com [10.17.1.39]) by smtpservice.6wind.com (Postfix) with ESMTP id E7EF23420D; Mon, 8 Sep 2025 09:04:40 +0200 (CEST) From: Thierry Herbelot To: dev@dpdk.org Cc: Thierry Herbelot , Thomas Monjalon , Devendra Singh Rawat , Alok Prasad , Jerin Jacob , Olivier Matz , Edwin Brossette , stable@dpdk.org Subject: [V2] net/qede: reduce the optimization level for gcc > 11 Date: Mon, 8 Sep 2025 09:04:13 +0200 Message-Id: <20250908070414.1297844-1-thierry.herbelot@6wind.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20250903113252.2496087-1-thierry.herbelot@6wind.com> References: <20250903113252.2496087-1-thierry.herbelot@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The qede PMD stopped working under Ubuntu-24.04 (using gcc-13) when compiled with -O3 (default level for all DPDK code). A bug is opened for this issue (see Link). The same issue is also seen with gcc-12 and gcc-14. A first workaround is to just disable all optimizations (-O0), which restores packet Rx with Qlogic NICs. However, the performance impact is not acceptable (around 50% drop). A better compromise is to use -O1 for the qede PMD: - there is some perf impact, - but the PMD is working as expected (packets are correctly received). When compiling with both -O2 and -O3 and gcc > 11, there is no packet reception when using the qede PMD. The root cause could be missing 'volatile' keywords or missing memory barriers in the qede PMD code. Link: https://bugs.dpdk.org/show_bug.cgi?id=1379 Signed-off-by: Thierry Herbelot --- V2: be more precise when dropping optimization level (only for gcc > 11) --- drivers/net/qede/base/meson.build | 4 ++++ drivers/net/qede/meson.build | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/qede/base/meson.build b/drivers/net/qede/base/meson.build index a6dad3ec7bcc..130835cc31b1 100644 --- a/drivers/net/qede/base/meson.build +++ b/drivers/net/qede/base/meson.build @@ -55,3 +55,7 @@ foreach flag: error_cflags base_cflags += flag endif endforeach +# no packet Rx with gcc > 11 with compiling with default -O3 or -O2 +if (cc.get_id() == 'gcc' and cc.version().version_compare('>11.0')) + base_cflags += '-O1' +endif diff --git a/drivers/net/qede/meson.build b/drivers/net/qede/meson.build index e1b21d6ff5cd..e4268883ff93 100644 --- a/drivers/net/qede/meson.build +++ b/drivers/net/qede/meson.build @@ -22,3 +22,7 @@ sources = files( if cc.has_argument('-Wno-format-nonliteral') cflags += '-Wno-format-nonliteral' endif +# no packet Rx with gcc > 11 with compiling with default -O3 or -O2 +if (cc.get_id() == 'gcc' and cc.version().version_compare('>11.0')) + cflags += '-O1' +endif -- 2.39.2