* [PATCH v5 6/9] eal/arm: fix C++ build for 32-bit memcpy
[not found] ` <20250926124103.750844-1-david.marchand@redhat.com>
@ 2025-09-26 12:40 ` David Marchand
2025-09-26 13:01 ` Bruce Richardson
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: David Marchand @ 2025-09-26 12:40 UTC (permalink / raw)
To: dev
Cc: bruce.richardson, stable, Wathsala Vithanage,
Mattias Rönnblom, Morten Brørup
This was caught while checking ARM arch headers.
In file included from buildtools/chkincs/chkincs-cpp.p/rte_memcpy_32.cpp:1:
/home/runner/work/dpdk/dpdk/lib/eal/arm/include/rte_memcpy_32.h:302:1:
error: expected declaration before ‘}’ token
302 | }
| ^
Fixes: 719834a6849e ("use C linkage where appropriate in headers")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/eal/arm/include/rte_memcpy_32.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/eal/arm/include/rte_memcpy_32.h b/lib/eal/arm/include/rte_memcpy_32.h
index 99fd5757ca..861be06f5e 100644
--- a/lib/eal/arm/include/rte_memcpy_32.h
+++ b/lib/eal/arm/include/rte_memcpy_32.h
@@ -19,10 +19,14 @@
/* ARM NEON Intrinsics are used to copy data */
#include <arm_neon.h>
+#endif /* RTE_ARCH_ARM_NEON_MEMCPY */
+
#ifdef __cplusplus
extern "C" {
#endif
+#ifdef RTE_ARCH_ARM_NEON_MEMCPY
+
static inline void
rte_mov16(uint8_t *dst, const uint8_t *src)
{
@@ -252,7 +256,7 @@ rte_memcpy_func(void *dst, const void *src, size_t n)
return ret;
}
-#else
+#else /* ! RTE_ARCH_ARM_NEON_MEMCPY */
static inline void
rte_mov16(uint8_t *dst, const uint8_t *src)
--
2.51.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 6/9] eal/arm: fix C++ build for 32-bit memcpy
2025-09-26 12:40 ` [PATCH v5 6/9] eal/arm: fix C++ build for 32-bit memcpy David Marchand
@ 2025-09-26 13:01 ` Bruce Richardson
2025-09-26 19:55 ` Morten Brørup
2025-09-27 6:33 ` Mattias Rönnblom
2 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2025-09-26 13:01 UTC (permalink / raw)
To: David Marchand
Cc: dev, stable, Wathsala Vithanage, Mattias Rönnblom,
Morten Brørup
On Fri, Sep 26, 2025 at 02:40:59PM +0200, David Marchand wrote:
> This was caught while checking ARM arch headers.
>
> In file included from buildtools/chkincs/chkincs-cpp.p/rte_memcpy_32.cpp:1:
> /home/runner/work/dpdk/dpdk/lib/eal/arm/include/rte_memcpy_32.h:302:1:
> error: expected declaration before ‘}’ token
> 302 | }
> | ^
>
> Fixes: 719834a6849e ("use C linkage where appropriate in headers")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/eal/arm/include/rte_memcpy_32.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> diff --git a/lib/eal/arm/include/rte_memcpy_32.h b/lib/eal/arm/include/rte_memcpy_32.h
> index 99fd5757ca..861be06f5e 100644
> --- a/lib/eal/arm/include/rte_memcpy_32.h
> +++ b/lib/eal/arm/include/rte_memcpy_32.h
> @@ -19,10 +19,14 @@
> /* ARM NEON Intrinsics are used to copy data */
> #include <arm_neon.h>
>
> +#endif /* RTE_ARCH_ARM_NEON_MEMCPY */
> +
> #ifdef __cplusplus
> extern "C" {
> #endif
>
> +#ifdef RTE_ARCH_ARM_NEON_MEMCPY
> +
> static inline void
> rte_mov16(uint8_t *dst, const uint8_t *src)
> {
> @@ -252,7 +256,7 @@ rte_memcpy_func(void *dst, const void *src, size_t n)
> return ret;
> }
>
> -#else
> +#else /* ! RTE_ARCH_ARM_NEON_MEMCPY */
>
> static inline void
> rte_mov16(uint8_t *dst, const uint8_t *src)
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v5 6/9] eal/arm: fix C++ build for 32-bit memcpy
2025-09-26 12:40 ` [PATCH v5 6/9] eal/arm: fix C++ build for 32-bit memcpy David Marchand
2025-09-26 13:01 ` Bruce Richardson
@ 2025-09-26 19:55 ` Morten Brørup
2025-09-27 6:33 ` Mattias Rönnblom
2 siblings, 0 replies; 6+ messages in thread
From: Morten Brørup @ 2025-09-26 19:55 UTC (permalink / raw)
To: David Marchand, dev
Cc: bruce.richardson, stable, Wathsala Vithanage, Mattias Rönnblom
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Friday, 26 September 2025 14.41
>
> This was caught while checking ARM arch headers.
>
> In file included from buildtools/chkincs/chkincs-
> cpp.p/rte_memcpy_32.cpp:1:
> /home/runner/work/dpdk/dpdk/lib/eal/arm/include/rte_memcpy_32.h:302:1:
> error: expected declaration before ‘}’ token
> 302 | }
> | ^
>
> Fixes: 719834a6849e ("use C linkage where appropriate in headers")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 6/9] eal/arm: fix C++ build for 32-bit memcpy
2025-09-26 12:40 ` [PATCH v5 6/9] eal/arm: fix C++ build for 32-bit memcpy David Marchand
2025-09-26 13:01 ` Bruce Richardson
2025-09-26 19:55 ` Morten Brørup
@ 2025-09-27 6:33 ` Mattias Rönnblom
2 siblings, 0 replies; 6+ messages in thread
From: Mattias Rönnblom @ 2025-09-27 6:33 UTC (permalink / raw)
To: David Marchand, dev
Cc: bruce.richardson, stable, Wathsala Vithanage,
Mattias Rönnblom, Morten Brørup
On 9/26/25 14:40, David Marchand wrote:
> This was caught while checking ARM arch headers.
>
> In file included from buildtools/chkincs/chkincs-cpp.p/rte_memcpy_32.cpp:1:
> /home/runner/work/dpdk/dpdk/lib/eal/arm/include/rte_memcpy_32.h:302:1:
> error: expected declaration before ‘}’ token
> 302 | }
> | ^
>
Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Fixes: 719834a6849e ("use C linkage where appropriate in headers")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/eal/arm/include/rte_memcpy_32.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/eal/arm/include/rte_memcpy_32.h b/lib/eal/arm/include/rte_memcpy_32.h
> index 99fd5757ca..861be06f5e 100644
> --- a/lib/eal/arm/include/rte_memcpy_32.h
> +++ b/lib/eal/arm/include/rte_memcpy_32.h
> @@ -19,10 +19,14 @@
> /* ARM NEON Intrinsics are used to copy data */
> #include <arm_neon.h>
>
> +#endif /* RTE_ARCH_ARM_NEON_MEMCPY */
> +
> #ifdef __cplusplus
> extern "C" {
> #endif
>
> +#ifdef RTE_ARCH_ARM_NEON_MEMCPY
> +
> static inline void
> rte_mov16(uint8_t *dst, const uint8_t *src)
> {
> @@ -252,7 +256,7 @@ rte_memcpy_func(void *dst, const void *src, size_t n)
> return ret;
> }
>
> -#else
> +#else /* ! RTE_ARCH_ARM_NEON_MEMCPY */
>
> static inline void
> rte_mov16(uint8_t *dst, const uint8_t *src)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v6 6/9] eal/arm: fix C++ build for 32-bit memcpy
[not found] ` <20250930065740.1838899-1-david.marchand@redhat.com>
@ 2025-09-30 6:57 ` David Marchand
0 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2025-09-30 6:57 UTC (permalink / raw)
To: dev
Cc: bruce.richardson, stable, Morten Brørup,
Mattias Rönnblom, Wathsala Vithanage
This was caught while checking ARM arch headers.
In file included from buildtools/chkincs/chkincs-cpp.p/rte_memcpy_32.cpp:1:
/home/runner/work/dpdk/dpdk/lib/eal/arm/include/rte_memcpy_32.h:302:1:
error: expected declaration before ‘}’ token
302 | }
| ^
Fixes: 719834a6849e ("use C linkage where appropriate in headers")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
lib/eal/arm/include/rte_memcpy_32.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/eal/arm/include/rte_memcpy_32.h b/lib/eal/arm/include/rte_memcpy_32.h
index 99fd5757ca..861be06f5e 100644
--- a/lib/eal/arm/include/rte_memcpy_32.h
+++ b/lib/eal/arm/include/rte_memcpy_32.h
@@ -19,10 +19,14 @@
/* ARM NEON Intrinsics are used to copy data */
#include <arm_neon.h>
+#endif /* RTE_ARCH_ARM_NEON_MEMCPY */
+
#ifdef __cplusplus
extern "C" {
#endif
+#ifdef RTE_ARCH_ARM_NEON_MEMCPY
+
static inline void
rte_mov16(uint8_t *dst, const uint8_t *src)
{
@@ -252,7 +256,7 @@ rte_memcpy_func(void *dst, const void *src, size_t n)
return ret;
}
-#else
+#else /* ! RTE_ARCH_ARM_NEON_MEMCPY */
static inline void
rte_mov16(uint8_t *dst, const uint8_t *src)
--
2.51.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v7 6/9] eal/arm: fix C++ build for 32-bit memcpy
[not found] ` <20251001064512.2539269-1-david.marchand@redhat.com>
@ 2025-10-01 6:45 ` David Marchand
0 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2025-10-01 6:45 UTC (permalink / raw)
To: dev
Cc: bruce.richardson, stable, Morten Brørup,
Mattias Rönnblom, Wathsala Vithanage
This was caught while checking ARM arch headers.
In file included from buildtools/chkincs/chkincs-cpp.p/rte_memcpy_32.cpp:1:
/home/runner/work/dpdk/dpdk/lib/eal/arm/include/rte_memcpy_32.h:302:1:
error: expected declaration before ‘}’ token
302 | }
| ^
Fixes: 719834a6849e ("use C linkage where appropriate in headers")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
lib/eal/arm/include/rte_memcpy_32.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/eal/arm/include/rte_memcpy_32.h b/lib/eal/arm/include/rte_memcpy_32.h
index 99fd5757ca..861be06f5e 100644
--- a/lib/eal/arm/include/rte_memcpy_32.h
+++ b/lib/eal/arm/include/rte_memcpy_32.h
@@ -19,10 +19,14 @@
/* ARM NEON Intrinsics are used to copy data */
#include <arm_neon.h>
+#endif /* RTE_ARCH_ARM_NEON_MEMCPY */
+
#ifdef __cplusplus
extern "C" {
#endif
+#ifdef RTE_ARCH_ARM_NEON_MEMCPY
+
static inline void
rte_mov16(uint8_t *dst, const uint8_t *src)
{
@@ -252,7 +256,7 @@ rte_memcpy_func(void *dst, const void *src, size_t n)
return ret;
}
-#else
+#else /* ! RTE_ARCH_ARM_NEON_MEMCPY */
static inline void
rte_mov16(uint8_t *dst, const uint8_t *src)
--
2.51.0
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-10-01 6:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20241127112617.1331125-1-david.marchand@redhat.com>
[not found] ` <20250926124103.750844-1-david.marchand@redhat.com>
2025-09-26 12:40 ` [PATCH v5 6/9] eal/arm: fix C++ build for 32-bit memcpy David Marchand
2025-09-26 13:01 ` Bruce Richardson
2025-09-26 19:55 ` Morten Brørup
2025-09-27 6:33 ` Mattias Rönnblom
[not found] ` <20250930065740.1838899-1-david.marchand@redhat.com>
2025-09-30 6:57 ` [PATCH v6 " David Marchand
[not found] ` <20251001064512.2539269-1-david.marchand@redhat.com>
2025-10-01 6:45 ` [PATCH v7 " David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).