From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3FFF489B4 for ; Thu, 23 Oct 2025 17:47:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE2AB40430; Thu, 23 Oct 2025 17:47:56 +0200 (CEST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id A38E44021E for ; Thu, 23 Oct 2025 17:47:52 +0200 (CEST) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-b550eff972eso665937a12.3 for ; Thu, 23 Oct 2025 08:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1761234472; x=1761839272; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=40lnV69UwbIVxryHObxRQHARRLz50lT+fAtg323Hyng=; b=TVrWqBy05fxXMVBprsR5xi7g1X/WzkI82U+d9tlpYMTZ1IcHjx+267K3Nm6G4PeqEz B1mCeDrRUuN5VSxflL6+NAS08jo88fBqaf5iQgR1778Pty728VZIaGmSrjqYsFeIjpO1 MJKyFS0+jR8/q+TSr4LB4IwVAvlpd3fG2+BcuRzURAXFF2wqvbhomWks5xLE10BNKkvz KXQGPUXMIF/vIaVTyVnRnCM0TQ5jj5fFBLxdpTV5XaK3EKwb2KykO/nx2FhHXfohZyAn ngjEuaWwfoMU5FHVFOs4kaWPoL2MXsPJlY2P82bORGLZaFFYP+qXlMpWQjR6aalCiE/5 ceZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761234472; x=1761839272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=40lnV69UwbIVxryHObxRQHARRLz50lT+fAtg323Hyng=; b=lGqND/kt+NP+1s3lyX0rTVr4/UBa08NrHIeES/xOMkFsuJqoecmS2XZwdA26MwvSmW m/hnWXQAt2Gu0id5ylt18tCHIGnD7mkD1EpMIIbWQ3l6H+hE3zY5u5Mzxo5+zZTSH31A WUVtouhEsEK0Xy51IVKmhUzhu+LR1TrRe9O495OwYz0UdnWEB/FTNkcsrg1cXrkJUrxw BHIfuADSK3kf4rEHk4Gg+szKOrEsowrqrUReEPwvkcmSJIg/zdNf7q0QSf76On30xKkG BjzkF1FvYIOH6CuVA3/WM4U3FSqpmXRPcOxRaw8JfWJ/itk4hmpeMIDXJwAJZhOtVt5L WTPQ== X-Forwarded-Encrypted: i=1; AJvYcCWShrK1NdnUzauB+yHjILZWlk7rmnfJG/kqvpbN8F22i99HctW1533DY1Gs73kQyXT9uSlQMJ0=@dpdk.org X-Gm-Message-State: AOJu0Yy+Pbp4nV3uyak9YWw003ndMnOfabocwlI5qiUIKHvoRR7eeld/ s6HpB71A8y45cLyjg+NqXjcNmX9lnYWIydgJ/3gEy5uTAAMQe54W/jEimEU/oT6n5I4= X-Gm-Gg: ASbGnctwodI9gTjzcU2zK380oeAzIVPt/oQdyorLfrFK+HTQSW9T/Ihh19QxD9C/Kvi dSazrt8DKbvk1Z1t2qSNWPcaKN6++WAJxqecywFzl9w8ahcyI4Mkb7zQXnqZWvACPf+93ex66Ho mGis+0yJjxRnPLeWkRbpz0yIM1v5BVXe4gg1eZ8iV/PPwRDvs0QVGWrk9eQaU4NHQf5fu91BCya Ldf1H32WV6KOHeom7sfjyxAkenazKS8MpdAMuHcGNEoTcMhfUGrTVXW+iUR0BvD3vG5Fnw48hpu G1n6H71gcMiXMB4EmG0asb0c+W3PmhLkRfL5a9owrJizYtbGgy3t7EAbMad5qjoPpg8VnNlqOZL 5iN4LyF2ksOyTlC2V/sUgZlGbwVd7pmhDbzb99z9cwh+74VF0uCqHeACt3a7Lr+6O1PoWXnBjAI rR0kLdduT70FM2Wq7rUgTMEEQ+A9TnVo0cj7vaygZagOMfqFzR X-Google-Smtp-Source: AGHT+IE8jKLHA5S6UZGjEC7pG79B8CL55A0E3WNxt6tSVbRU+M32/L6AAyH+hWlLnqxYRHUsKbm4Yg== X-Received: by 2002:a17:903:8c6:b0:26d:353c:75cd with SMTP id d9443c01a7336-290c9cc30b8mr316571405ad.21.1761234471753; Thu, 23 Oct 2025 08:47:51 -0700 (PDT) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2946dddc0e4sm27906065ad.8.2025.10.23.08.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Oct 2025 08:47:51 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Reshma Pattan , Suanming Mou , Anatoly Burakov Subject: [PATCH v4 2/8] pdump: handle primary process exit Date: Thu, 23 Oct 2025 08:46:23 -0700 Message-ID: <20251023154748.38535-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251023154748.38535-1-stephen@networkplumber.org> References: <250811213632.16023-1-stephen@networkplumber.org> <20251023154748.38535-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org If primary process exits, then it is not possible (or needed) to cleanup resources. Instead just exit after closing the capture file. Bugzilla ID: 1760 Fixes: a99a311ba101 ("app/pdump: exit with primary process") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index fa85859703..1741d7e709 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -1028,13 +1028,15 @@ main(int argc, char **argv) dump_packets(); disable_primary_monitor(); - cleanup_pdump_resources(); + /* dump debug stats */ print_pdump_stats(); - ret = rte_eal_cleanup(); - if (ret) - printf("Error from rte_eal_cleanup(), %d\n", ret); + /* If primary has exited, do not try and communicate with it */ + if (!rte_eal_primary_proc_alive(NULL)) + return 0; - return 0; + cleanup_pdump_resources(); + + return rte_eal_cleanup() ? EXIT_FAILURE : 0; } -- 2.51.0