From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A39AD489C9 for ; Fri, 24 Oct 2025 23:55:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 938C4402ED; Fri, 24 Oct 2025 23:55:04 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id F08F540267 for ; Fri, 24 Oct 2025 23:55:01 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-33b5a3e8ae2so3270347a91.1 for ; Fri, 24 Oct 2025 14:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1761342901; x=1761947701; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DCYjS8lCU4ey/Xq/QimMFCgJnsxEn9LlKb03adqG16o=; b=r6W19DdkMqszTzWEKeDWJViavlWqpmdKh2YPJfMQ8P4de2781zx0SDRI6l78CI41MK z5J0V7/JFIjMregQeHwRBBKmBRcCzTetxjyr1h6Htz28/vxVLQZz4GYEyUV2pM9/x22T j7FqAYnu+znoGFkgCyjvX39aibj6q7p7AL4fljBrPIN7eQPWz/o5npUkjnqHcofvg76e 4ZV5C7o1tC5/EjlqZ7Plh/ziiH4qW1LRcNH/0otzhfmOVGvfqyx43RFdhe+69T6r+ZgP igs0W2GBybXchEfnNo+UTXDNisYry0Opf5NpioMZ7uxqEQ+8HJfO7s8TjT+qb5ow0qa6 wV5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761342901; x=1761947701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DCYjS8lCU4ey/Xq/QimMFCgJnsxEn9LlKb03adqG16o=; b=mFKUXnjKuvPQfBky+Ncfer3z5yXifViaDEOi178H2obnk6ysPkbo7jAI/VmqcFSmaP hbF8Gjy1mOlWOd8/3sskm03V8N7KOzWSiHhjeCUeKOcVLp5lZqSlhZoFxGzpR9LCxuBA uOTFCdJtB8HGCabWO1m6RmZssyGn6RcuH6+UTPRMe5uOt+3DgJ4bDlpkk1uSndM9d0to jpCSdjQApEdG7cUBBuId0PNUDULPVpvlEFIDSCTTjRJesC/R3PNrE7y/vjGUwsLMruRG l8mYj+XVPChIv7fkKXQpS5hR5nW5pfzcc/0E6cxyoyb4UK3+xYaKpRxGDk4/G1jhzcZB nuUQ== X-Forwarded-Encrypted: i=1; AJvYcCWuj6a7apbee3++agE7BKiXq9THugafj/JixBpRkSxw6IODyMiTqQVl38zZdXKttz0gkSaBPzw=@dpdk.org X-Gm-Message-State: AOJu0Yzrje+0c9pFUwr6QBr0yMy9/rgA1qqXYA0eci99pP1V0Cv1/le2 D6uKEJoyQfLDeRkQr45Uf1c2qqGQVWTElmSWSjJuSx3ssqoz2VvhPJfnrlIMYxDSRkw= X-Gm-Gg: ASbGncvCLxH3nDT1O0+h6YrUWYaspQrnEczoHIlu9ujAhNu4eooLVZ1jXW/OBFFTrKa VO1PXh+rkKuHpi0pJiDCUY9rfTgrhOUfca/4vfn7wbUQbHanFkw/QSfpT5cKYQL7Yqxnc9GTe2b ebhRISGXtrZE22jGzKkTsUK2QH/jeFe6v5IdNy/1Z8r8LURNYts4YKI0mybOmH0NZYjCMPB/QBp G+mF3vaSAR/dVLIuTLqlEZlfb/ewmzOS3WP/8r2P7CWwZS5wOmK45dT+22zHD8mCaZlILpEY+qU opZUxi5umeoOPd9rsJ+maRpWo6fC56LVpDLjCTgUIvouwt0FSVSQYi3uom1IGM8q71mI65i0Fer Tk3c0ZfBp/7XD+ijCLaLzXbbR2YBiAqjjhDnX11PPMxF5SMkFMKybZBfViyag8n61yi0zbFqDpO diiXvZyx1WQQDQUgweWg2KC6Mb8t4aOP3234OjH9w= X-Google-Smtp-Source: AGHT+IGHfA/0Yje3jKWO11l/ZQ+Fe2NdGFble6EaWTz+oqma9JS+4hpyecI4sbD+CWvcD+RcF7ktSA== X-Received: by 2002:a17:90b:4b11:b0:32e:8ff9:d124 with SMTP id 98e67ed59e1d1-33fd3bdcdc7mr4916064a91.15.1761342901100; Fri, 24 Oct 2025 14:55:01 -0700 (PDT) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a414012de3sm252530b3a.2.2025.10.24.14.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Oct 2025 14:55:00 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Bruce Richardson , Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>, Reshma Pattan , Suanming Mou , Anatoly Burakov Subject: [PATCH v5 2/8] pdump: handle primary process exit Date: Fri, 24 Oct 2025 14:53:57 -0700 Message-ID: <20251024215456.282171-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251024215456.282171-1-stephen@networkplumber.org> References: <250811213632.16023-1-stephen@networkplumber.org> <20251024215456.282171-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org If primary process exits, then it is not possible (or needed) to cleanup resources. Instead just exit after closing the capture file. Bugzilla ID: 1760 Fixes: a99a311ba101 ("app/pdump: exit with primary process") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> --- app/pdump/main.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index fa85859703..1741d7e709 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -1028,13 +1028,15 @@ main(int argc, char **argv) dump_packets(); disable_primary_monitor(); - cleanup_pdump_resources(); + /* dump debug stats */ print_pdump_stats(); - ret = rte_eal_cleanup(); - if (ret) - printf("Error from rte_eal_cleanup(), %d\n", ret); + /* If primary has exited, do not try and communicate with it */ + if (!rte_eal_primary_proc_alive(NULL)) + return 0; - return 0; + cleanup_pdump_resources(); + + return rte_eal_cleanup() ? EXIT_FAILURE : 0; } -- 2.51.0