From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 354D7489EF for ; Mon, 27 Oct 2025 17:21:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3084940657; Mon, 27 Oct 2025 17:21:04 +0100 (CET) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mails.dpdk.org (Postfix) with ESMTP id 316CA40653 for ; Mon, 27 Oct 2025 17:21:02 +0100 (CET) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-47106fc51faso61872505e9.0 for ; Mon, 27 Oct 2025 09:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761582062; x=1762186862; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wdaMCLj/fJcPm40VhWQJPkvn5ECfFkI193dP959BhmY=; b=lBQ31KiqeMjNX6QTPTMqtY/+mp6cvVOlTyOJxvGws9MJ/DiLaIo+Spurji7kDmLpvy OiNnC8IN2bdS1cuQIEX9yCRvk3raZUaP7V9+ZOVhjqDQ0LS8bpusaojpzmEFC44E6yg6 Lg5JjSRPADsdHIV7a1bNF5/qTZ77FDfYBESH8L+qKfmoJByLy+zjZCfr25QTEWCeggRq UyS21gGI4BJoa5l2YAiLSnxyjUufHWxKOSo59F0FXq4YpeGL+IHyG15ULPmI7QwKRAz8 Tl52M19PfyzP7wbakIp/GvHgusnVRUkGD7tJHuupCm880KF5RwTKw0d1ynpnA8UfbdEw 6wYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761582062; x=1762186862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wdaMCLj/fJcPm40VhWQJPkvn5ECfFkI193dP959BhmY=; b=YSNoKopt04eJzGCVQUI/P3xU3xA5lTpHCgFJcowfDVxNCvf+laWzXdrOSfbz76N5ql gxnvX6+nIsp1xFEWEWEwrCO8uE5ZykHpiKrmBCu4FcqwI+7aElzsrO2hB3pZpKKU6QxE jIjFWUWp0r5SmJhv7Z1Doi85YOM3zGvIDg1KUJE5LPuVEbaTyLm3O5ZxBGb7NVUtMrGr rzNLmRsqlpGlHCcQ7jh/RYuCZCkoUVeNT95jq58GGgKXqN0IRoSc0VPGw+0bzVkIi+Le aJMyiv+qbPHoGVzkW+g+iXH+xG/3ez9whzcGr0d0pcD4Glx/y8PHLvzvL3Ns1vWg5pWl ZodQ== X-Forwarded-Encrypted: i=1; AJvYcCVDGD7fAoltiXKOkPlFlXXOaNFeVok/WOnMr3jk9lPEli+8nbUUMVuJ/kLm3ByaMU0uIcaB7sU=@dpdk.org X-Gm-Message-State: AOJu0YxrE3TuAch9QpF2bV6IAYqZw2A4MSUjZJK68BmR/RfXKUQG2oIP KzmpX8ooI1sILI9VoUgRyoUxIhqMKwLJKbJzMOMfEk+vihe1u35UDQ4U X-Gm-Gg: ASbGncvlSZymbM1yi4ncgwKH204xG8vCkL42tTahhNFqwXgRi7DC7Xogt2iKDaQBE1i eUsRFDz56qZJTUUvWeaVBuA/EhgB0m4ZyoOGRlxenycay3eQW73LD44MEFbF8r3yrhDt8HZjqJK fFJZgZoVerUvsS4/zm5FVaMqDgkdMQMVBJiQbxX4xq9ST1fBJU95IID5jLp5PA8qSErzU3v1dUm cAK50AuuM76KSykf2UTpUrqAeFZlmshtYSyefmKh0FYUqi1QM91WJ1AixfnrwgOZlol42k6QG/+ F08sELSO2bnaqQ1+XTHmeTg1jCFG9bZSe2tkL3I0DEh/K8WdZXdq4+N/661ABW3mDdny7Zd2BoF TLh50u8IGADRMVXiZYjvSrsSZ3vPY49yo90/IqkdtllUF0uVBNkkidck7TMopxsUtAEKfPE9p+q ExhdeJ8cxUcHylFIER X-Google-Smtp-Source: AGHT+IH/9szpI5seBskwKkfuMLbp3SPwsoG8wETqf0GYvVozkC8BJ0QvRg83noccppSiUFXaqTLkTw== X-Received: by 2002:a05:600c:45d5:b0:46f:b42e:ed87 with SMTP id 5b1f17b1804b1-47717e62bd2mr1807385e9.40.1761582061587; Mon, 27 Oct 2025 09:21:01 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:6fc5:c3bc:147e:832c]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-475dd02ce46sm173499495e9.3.2025.10.27.09.21.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:21:01 -0700 (PDT) From: luca.boccassi@gmail.com To: Maayan Kashani Cc: Dariusz Sosnowski , Ivan Malov , dpdk stable Subject: patch 'net/mlx5: fix unsupported flow rule port action' has been queued to stable release 22.11.11 Date: Mon, 27 Oct 2025 16:18:56 +0000 Message-ID: <20251027162001.3710450-18-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027162001.3710450-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/29/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/def814b06fd87d79f247e907f82269737e47eb3e Thanks. Luca Boccassi --- >From def814b06fd87d79f247e907f82269737e47eb3e Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Thu, 7 Aug 2025 12:12:47 +0300 Subject: [PATCH] net/mlx5: fix unsupported flow rule port action [ upstream commit c040e9a85a1fbce46528e9bc15d1ce4bbc911346 ] When dv_flow_en=2, the port ID action is not supported. Although a rule can be created successfully in non-template mode, the specified action will be silently ignored and not applied. To prevent this ambiguous behavior, explicitly return an error when a port ID action is used with dv_flow_en=2, and recommend using a represented port action instead. Fixes: f1fecffa88df ("net/mlx5: support Direct Rules action template API") Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski Acked-by: Ivan Malov --- drivers/net/mlx5/mlx5_flow_hw.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index a2cd9b8b5c..7a8455baf6 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -1666,6 +1666,10 @@ __flow_hw_actions_translate(struct rte_eth_dev *dev, case RTE_FLOW_ACTION_TYPE_END: actions_end = true; break; + case RTE_FLOW_ACTION_TYPE_PORT_ID: + DRV_LOG(ERR, "RTE_FLOW_ACTION_TYPE_PORT_ID action is not supported. " + "Use RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT instead."); + goto err; default: break; } @@ -4274,6 +4278,10 @@ flow_hw_dr_actions_template_create(struct rte_flow_actions_template *at) at->actions_off[i] = curr_off; action_types[curr_off++] = MLX5DR_ACTION_TYP_MISS; break; + case RTE_FLOW_ACTION_TYPE_PORT_ID: + DRV_LOG(ERR, "RTE_FLOW_ACTION_TYPE_PORT_ID action is not supported. " + "Use RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT instead.\n"); + return NULL; default: type = mlx5_hw_dr_action_types[at->actions[i].type]; at->actions_off[i] = curr_off; -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-27 15:54:35.502533826 +0000 +++ 0018-net-mlx5-fix-unsupported-flow-rule-port-action.patch 2025-10-27 15:54:34.751948446 +0000 @@ -1 +1 @@ -From c040e9a85a1fbce46528e9bc15d1ce4bbc911346 Mon Sep 17 00:00:00 2001 +From def814b06fd87d79f247e907f82269737e47eb3e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c040e9a85a1fbce46528e9bc15d1ce4bbc911346 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -21,2 +22,2 @@ - drivers/net/mlx5/mlx5_flow_hw.c | 10 +++++++++- - 1 file changed, 9 insertions(+), 1 deletion(-) + drivers/net/mlx5/mlx5_flow_hw.c | 8 ++++++++ + 1 file changed, 8 insertions(+) @@ -25 +26 @@ -index 016370f68b..0c3f554479 100644 +index a2cd9b8b5c..7a8455baf6 100644 @@ -28 +29 @@ -@@ -2913,6 +2913,10 @@ __flow_hw_translate_actions_template(struct rte_eth_dev *dev, +@@ -1666,6 +1666,10 @@ __flow_hw_actions_translate(struct rte_eth_dev *dev, @@ -39,6 +40,4 @@ -@@ -7648,7 +7652,11 @@ flow_hw_parse_flow_actions_to_dr_actions(struct rte_eth_dev *dev, - case MLX5_RTE_FLOW_ACTION_TYPE_MIRROR: - at->dr_off[i] = curr_off; - action_types[curr_off++] = MLX5DR_ACTION_TYP_DEST_ARRAY; -- break; -+ break; +@@ -4274,6 +4278,10 @@ flow_hw_dr_actions_template_create(struct rte_flow_actions_template *at) + at->actions_off[i] = curr_off; + action_types[curr_off++] = MLX5DR_ACTION_TYP_MISS; + break; @@ -47,2 +46,2 @@ -+ "Use RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT instead."); -+ return -EINVAL; ++ "Use RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT instead.\n"); ++ return NULL; @@ -51 +50 @@ - at->dr_off[i] = curr_off; + at->actions_off[i] = curr_off;