From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E245489EF for ; Mon, 27 Oct 2025 17:21:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85EDD4028B; Mon, 27 Oct 2025 17:21:17 +0100 (CET) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id 05C1E4028B for ; Mon, 27 Oct 2025 17:21:17 +0100 (CET) Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42701b29a7eso2550230f8f.0 for ; Mon, 27 Oct 2025 09:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761582076; x=1762186876; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9sH2GdtZltugVQN46BQ+2BUm6RYag74cM89lsUtvS8M=; b=Cub7ErEUOgP+UKQeGRtVMvqu+WEsbuVLJEqr6adgz1Y+411SA2rABzZXp7SR2c51UD 3GTpolaGWHhFOwJ8DQ1LSMOcTt0RKPJwoUfqExMxqZFY6cmtimHpmtDHGUKaqWlwrPCq wMwQYCX3aBkDgLKueQdLLB6w6XDIolEecLBxcM2tRByPz9BfeWs8dcVQUAZGieh2nImm 3RBi+fLxZuyQ7C9wJzTQBiNo3IN39DCKa8NbDIRNcxOygwkEztYFY7x+GTKJ0u5jlYJz i0WdiaOXLYORy1mzOunyzVtjCWxsW6FlXzV7fCajQz/IEnmrVej6D5Dtm0VSVdN4MNVm EJZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761582076; x=1762186876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9sH2GdtZltugVQN46BQ+2BUm6RYag74cM89lsUtvS8M=; b=MDEnSqzTZEjv7jVjUq7S/LDxpgWr9PuZR77wWNc1X4HRrntHXHhBtR2rzehTJoUcFs HYyFoVprpVnOClw9niKGO7vD78aBFz66HvZ/OrOpm9glMgrJO2CpqQcYIhQUyTAHl4q6 ezOpXmNVrTzwcJt2mT+/EGfn/BYFyIEbKXmLAaUvT1LXuUwAsHNJ54Mgg4l84Vwc70T0 aKn/U9knf+qEbIQFlyh36Tpquwh66sBlYY2cSCmo1ixKCH38jEAAVt9T/Et8JzaN7BuT asNZLF+CYAmt+Oy0lyidzMgZ3kVkfW4rXxy8UUecb0W3a3eAvuMywChBrqY+aSx8iSsV 72bg== X-Forwarded-Encrypted: i=1; AJvYcCXfZirNaiNmTXzK54gcaIgSyIE1FapLQY77SIQ8hOP5GJ+6IjynJ2McQ0kjh1hQELF12iLznuo=@dpdk.org X-Gm-Message-State: AOJu0YzpdZxPPJwIoDnmoVwvgy3WzAxzvcX1RFkPcNuY30TM031SdrTb oS4xzNLcP4QSrRzGVjYZIWvX+1XvL0TCl1OHHLr7QoSvV6mLB0PtwOU2TqhjdA== X-Gm-Gg: ASbGnct6aT2gnX3Oa7fj8XI8akCFUUYaTu0mFbmdXoMVH9DPVlmhTtmXF+PZa/gXeT8 KSGiMgytEGUeHC2OT9XsbRG9cwnWSM1vyJ9F/QdjqAMjbhTPUtaO/WDbAwxHxybp/BNUtZnTkOO C9D2LAlcaNqixS8E+OaFrolN5Tnw5bXiFlvXTtGRGBp2ounYHRX/aKlOCCY85c2i6onUdKe0/3v JfTNM9O2iADbZVTpuOeW1FaSZRKKVL4Wx2X+ZNH7MkeMDgUm459601imwL8c0AwPBRv1CkTGY3X znbMDamNJe1Z4yarsTeGVgaEY3fXN1mcQgP2+sN/0VdyDu7X+fASpiu5qA9CoPzYzeI7d3kLn9b goS5nG2Lj3209K6i5vNEFnNCca8dAW2LW+gCRKY4UvoXEeUcpNhHFxZXQggfToL9wQXPC2qbpYB tXzJLwmX7W85JgIjsy X-Google-Smtp-Source: AGHT+IFyEzJKRkw6xLkkQiisI2Zcw4pxt/4kP9w2bjoRBRGZmWUi4EkfidUECC0FTs33i6UXUOOUMA== X-Received: by 2002:a05:6000:65c:b0:425:7e33:b4a9 with SMTP id ffacd0b85a97d-429a8060ee8mr91504f8f.0.1761582076437; Mon, 27 Oct 2025 09:21:16 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:6fc5:c3bc:147e:832c]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-429952d5985sm14936010f8f.25.2025.10.27.09.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:21:16 -0700 (PDT) From: luca.boccassi@gmail.com To: Dariusz Sosnowski Cc: Andre Muezerie , dpdk stable Subject: patch 'net/mlx5: fix Direct Verbs counter offset detection' has been queued to stable release 22.11.11 Date: Mon, 27 Oct 2025 16:19:00 +0000 Message-ID: <20251027162001.3710450-22-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027162001.3710450-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/29/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/9d536ec45e17d575b632ae93a1df5e39b64b3cb5 Thanks. Luca Boccassi --- >From 9d536ec45e17d575b632ae93a1df5e39b64b3cb5 Mon Sep 17 00:00:00 2001 From: Dariusz Sosnowski Date: Wed, 20 Aug 2025 10:45:21 +0200 Subject: [PATCH] net/mlx5: fix Direct Verbs counter offset detection [ upstream commit d953431da8e1ece042e33ba71650a3ba6b1e27c1 ] This patch fixes a bug in mlx5_flow_dv_discover_counter_offset_support() uncovered by a warning reported by MSVC: ../drivers/net/mlx5/mlx5_flow_dv.c(19636): warning C5287: operands are different enum types 'ibv_flow_attr_type' and 'ibv_flow_flags'; use an explicit cast to silence this warning IBV_FLOW_ATTR_FLAGS_EGRESS was incorrectly passed in to type field of mlx5dv_flow_matcher_attr struct, instead of flags field. As a result counter offset support discovery returned a false positive result on application with old rdma-core. Bugzilla ID: 1758 Fixes: 4fd5e1484887 ("net/mlx5: fix counter offset detection") Reported-by: Andre Muezerie Signed-off-by: Dariusz Sosnowski Acked-by: Andre Muezerie --- drivers/net/mlx5/mlx5_flow_dv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index ff8d58db64..d7e886fa4f 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -18461,7 +18461,8 @@ mlx5_flow_dv_discover_counter_offset_support(struct rte_eth_dev *dev) .size = sizeof(value.buf), }; struct mlx5dv_flow_matcher_attr dv_attr = { - .type = IBV_FLOW_ATTR_NORMAL | IBV_FLOW_ATTR_FLAGS_EGRESS, + .type = IBV_FLOW_ATTR_NORMAL, + .flags = IBV_FLOW_ATTR_FLAGS_EGRESS, .priority = 0, .match_criteria_enable = 0, .match_mask = (void *)&mask, -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-27 15:54:35.676008294 +0000 +++ 0022-net-mlx5-fix-Direct-Verbs-counter-offset-detection.patch 2025-10-27 15:54:34.783949248 +0000 @@ -1 +1 @@ -From d953431da8e1ece042e33ba71650a3ba6b1e27c1 Mon Sep 17 00:00:00 2001 +From 9d536ec45e17d575b632ae93a1df5e39b64b3cb5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d953431da8e1ece042e33ba71650a3ba6b1e27c1 ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org @@ -33 +34 @@ -index f673637e7d..abfd54da1a 100644 +index ff8d58db64..d7e886fa4f 100644 @@ -36 +37 @@ -@@ -19657,7 +19657,8 @@ mlx5_flow_dv_discover_counter_offset_support(struct rte_eth_dev *dev) +@@ -18461,7 +18461,8 @@ mlx5_flow_dv_discover_counter_offset_support(struct rte_eth_dev *dev)