From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0A33489EF for ; Mon, 27 Oct 2025 17:21:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB5AB40663; Mon, 27 Oct 2025 17:21:19 +0100 (CET) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mails.dpdk.org (Postfix) with ESMTP id 4BBEC40657 for ; Mon, 27 Oct 2025 17:21:18 +0100 (CET) Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4711f3c386eso36810495e9.0 for ; Mon, 27 Oct 2025 09:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761582078; x=1762186878; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sLDFM3nf40OHowdI2vlygE3qJaLdIMGpGcUckhIz1H0=; b=DjRvhg+qmD5zHC6xYCJ4wLwFvPwzyam/UDdvtbMJENJ80Hwai7oIM2vZCbNNJcvKqW M10laJy8N93NScUQfYUS4MNRLni3Nv++mE+3RRL9QwuoF0+dbnlsmmE7QeNbHP1eeF/w dP7dNh6E7W/9Eq7ukpTBIWkca+AfWGuQKJLo3l0zdvLIoodGDwwF/uBmbiI7uK0Ijz3F JpAFHHvvOxm5SJBwCX3bu48Deha2jylfVtAJhRYmtmImBuMkyUBN11eRBp7EeTgBfXnX A0hI0YiiLu6iIg4zkLmbrkbklDdTVt3l7C+hX6hCwl4xj51+S2u1MLj55atwi9SrrLnd gEXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761582078; x=1762186878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sLDFM3nf40OHowdI2vlygE3qJaLdIMGpGcUckhIz1H0=; b=P29z4hiNcSNXS/yDp2pFvDfYQUSUyR3OxXBihCO2a7/U/n5cE5jH0pv4oVLjMEHJTR EvdAX1/1426koRhHcm0DK5RpMgrXy3x5EFuP7BdV03ANZl8KnS9jL1FtE4lvj1e11G2m cAUVf2bKo3YckWURVk77Hkhs1wBxwh+pFhJVCLGp7Z4WHdMf281ut7+IoAS5XiFep5Sg MDa5pD01zOw2mSKmY/S/XlkVY+/UJuUCn7AphkWr+1M5NhbclZXXnW2rrPJsDdzc8AgN Ib72rdVrl78b00021RJNAcccCB9Kr/omHrUMKPSAxLuiKIZVuw5UsQzSuYUXwGBLIMUs xbBg== X-Forwarded-Encrypted: i=1; AJvYcCVGbuLvYNNd9oO+9BD5ICmT6Nv6yKpXBTlWfQP7jgKSVZt33ZmZavDC/xtZnjdVlPLSq3bgwAQ=@dpdk.org X-Gm-Message-State: AOJu0Yz4+iB3DI7iFUds9SnqvR63ojNJsjtWw8esKki+2cvrXkvVibRG /xANlBe6mScy70XPScIUPsqCqixa2eI0dKEBVryu6o3zjkavNExlUbzA X-Gm-Gg: ASbGncv5nslKEA5g1rP3Z6PJk29bK7lHF+4R9lDdL2cKrjVO0tgiUKN96VXftM8uf/d Q1FXdDxR8gpQzKLmq6e7RFpk+qbB4VmOhotUGmNhjHcneOsqzo9r3uuTVHrH1g1rT7O6Pd+wCeB BPMp37SXtZZEV3vHLS8xx7kBXl+5cw2SyQNTqRKqZ5K+0KZ/yTjMcGlbpMVMIOgBLOgSXwv+y// rSFSLjGcYtKPdU+vfFylAxJhvoJG8OjUNSJk6hcr4edtYCDz02rWnf/+ZHRSKT+JYtft4pMaJwZ VgEFY4hStKEXl44/RyKBzEW97zwg1WFTimDFgvZw1XtIgYJI8OeVF2QBdoEHooOjkoUSrb/LaX/ 8/8Ccn8YeLRJtWHSAmpdDd40PIpDRMoThUqAI0cVE/Z+D6eZhQgrMIs9rN70+OdKhwI7XHJ2tQe Q13klxNA== X-Google-Smtp-Source: AGHT+IEQgMOKfAHUo0WAfyfPd1Uqr4pfH5seGeoCuGFndewwP84vmb4EMF0Dmy/TU1fOnufX9WuepA== X-Received: by 2002:a05:600c:8209:b0:46e:326e:4501 with SMTP id 5b1f17b1804b1-47717dfe812mr1964355e9.10.1761582077728; Mon, 27 Oct 2025 09:21:17 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:6fc5:c3bc:147e:832c]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-475dd478202sm144684965e9.14.2025.10.27.09.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:21:17 -0700 (PDT) From: luca.boccassi@gmail.com To: Gregory Etelson Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: fix interface name parameter definition' has been queued to stable release 22.11.11 Date: Mon, 27 Oct 2025 16:19:01 +0000 Message-ID: <20251027162001.3710450-23-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027162001.3710450-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/29/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/0458512915113b2da620fcf44f40beed30aefbe9 Thanks. Luca Boccassi --- >From 0458512915113b2da620fcf44f40beed30aefbe9 Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Sun, 10 Aug 2025 16:22:59 +0300 Subject: [PATCH] net/mlx5: fix interface name parameter definition [ upstream commit 9e58a50c059f3760c51ddee16073496c6e1d510a ] The patch fixes `ifname` parameter as a character buffer. Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 11 +++++------ drivers/net/mlx5/linux/mlx5_os.c | 2 +- drivers/net/mlx5/mlx5.h | 3 +-- drivers/net/mlx5/windows/mlx5_ethdev_os.c | 4 ++-- 4 files changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c index 4d126751a2..ea89ce8e05 100644 --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c @@ -156,7 +156,7 @@ mlx5_auxiliary_get_ifindex(const char *sf_name) * 0 on success, a negative errno value otherwise and rte_errno is set. */ int -mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) +mlx5_get_ifname(const struct rte_eth_dev *dev, char ifname[MLX5_NAMESIZE]) { struct mlx5_priv *priv = dev->data->dev_private; unsigned int ifindex; @@ -170,12 +170,11 @@ mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) ifindex = mlx5_ifindex(dev); if (!ifindex) { if (!priv->representor) - return mlx5_get_ifname_sysfs(priv->sh->ibdev_path, - *ifname); + return mlx5_get_ifname_sysfs(priv->sh->ibdev_path, ifname); rte_errno = ENXIO; return -rte_errno; } - if (if_indextoname(ifindex, &(*ifname)[0])) + if (if_indextoname(ifindex, ifname)) return 0; rte_errno = errno; return -rte_errno; @@ -233,10 +232,10 @@ error: static int mlx5_ifreq(const struct rte_eth_dev *dev, int req, struct ifreq *ifr) { - char ifname[sizeof(ifr->ifr_name)]; + char ifname[MLX5_NAMESIZE]; int ret; - ret = mlx5_get_ifname(dev, &ifname); + ret = mlx5_get_ifname(dev, ifname); if (ret) return -rte_errno; return mlx5_ifreq_by_ifname(ifname, req, ifr); diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 38a774ade7..23093b404a 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -1502,7 +1502,7 @@ err_secondary: { char ifname[MLX5_NAMESIZE]; - if (mlx5_get_ifname(eth_dev, &ifname) == 0) + if (mlx5_get_ifname(eth_dev, ifname) == 0) DRV_LOG(DEBUG, "port %u ifname is \"%s\"", eth_dev->data->port_id, ifname); else diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index b82142f2bc..ad90b090cf 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -1967,8 +1967,7 @@ void mlx5_get_mtu_bounds(struct rte_eth_dev *dev, uint16_t *min_mtu, uint16_t *m /* mlx5_ethdev_os.c */ -int mlx5_get_ifname(const struct rte_eth_dev *dev, - char (*ifname)[MLX5_NAMESIZE]); +int mlx5_get_ifname(const struct rte_eth_dev *dev, char ifname[MLX5_NAMESIZE]); unsigned int mlx5_ifindex(const struct rte_eth_dev *dev); int mlx5_get_mac(struct rte_eth_dev *dev, uint8_t (*mac)[RTE_ETHER_ADDR_LEN]); int mlx5_get_mtu(struct rte_eth_dev *dev, uint16_t *mtu); diff --git a/drivers/net/mlx5/windows/mlx5_ethdev_os.c b/drivers/net/mlx5/windows/mlx5_ethdev_os.c index 4f43b95a09..32a9f599b2 100644 --- a/drivers/net/mlx5/windows/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/windows/mlx5_ethdev_os.c @@ -56,7 +56,7 @@ mlx5_get_mac(struct rte_eth_dev *dev, uint8_t (*mac)[RTE_ETHER_ADDR_LEN]) * 0 on success, a negative errno value otherwise and rte_errno is set. */ int -mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) +mlx5_get_ifname(const struct rte_eth_dev *dev, char ifname[MLX5_NAMESIZE]) { struct mlx5_priv *priv; mlx5_context_st *context_obj; @@ -67,7 +67,7 @@ mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) } priv = dev->data->dev_private; context_obj = (mlx5_context_st *)priv->sh->cdev->ctx; - strncpy(*ifname, context_obj->mlx5_dev.name, MLX5_NAMESIZE); + strncpy(ifname, context_obj->mlx5_dev.name, MLX5_NAMESIZE); return 0; } -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-27 15:54:35.720784190 +0000 +++ 0023-net-mlx5-fix-interface-name-parameter-definition.patch 2025-10-27 15:54:34.787949348 +0000 @@ -1 +1 @@ -From 9e58a50c059f3760c51ddee16073496c6e1d510a Mon Sep 17 00:00:00 2001 +From 0458512915113b2da620fcf44f40beed30aefbe9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9e58a50c059f3760c51ddee16073496c6e1d510a ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index a371c2c747..4acaaca9ca 100644 +index 4d126751a2..ea89ce8e05 100644 @@ -24 +25 @@ -@@ -73,7 +73,7 @@ mlx5_auxiliary_get_ifindex(const char *sf_name) +@@ -156,7 +156,7 @@ mlx5_auxiliary_get_ifindex(const char *sf_name) @@ -33 +34 @@ -@@ -87,12 +87,11 @@ mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) +@@ -170,12 +170,11 @@ mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) @@ -48 +49 @@ -@@ -150,10 +149,10 @@ error: +@@ -233,10 +232,10 @@ error: @@ -62 +63 @@ -index 85b3fabaf5..3d87aec5bc 100644 +index 38a774ade7..23093b404a 100644 @@ -65 +66 @@ -@@ -1587,7 +1587,7 @@ err_secondary: +@@ -1502,7 +1502,7 @@ err_secondary: @@ -75 +76 @@ -index 53f0a27445..93e298d648 100644 +index b82142f2bc..ad90b090cf 100644 @@ -78 +79 @@ -@@ -2348,8 +2348,7 @@ void mlx5_get_mtu_bounds(struct rte_eth_dev *dev, uint16_t *min_mtu, uint16_t *m +@@ -1967,8 +1967,7 @@ void mlx5_get_mtu_bounds(struct rte_eth_dev *dev, uint16_t *min_mtu, uint16_t *m