From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45D58489EF for ; Mon, 27 Oct 2025 17:21:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F46E40655; Mon, 27 Oct 2025 17:21:33 +0100 (CET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mails.dpdk.org (Postfix) with ESMTP id 2239D40655 for ; Mon, 27 Oct 2025 17:21:32 +0100 (CET) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4710a1f9e4cso40359675e9.0 for ; Mon, 27 Oct 2025 09:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761582092; x=1762186892; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vfYJDvWjVZ+hChhkZyh/MhVoN35weXqxL5sr4tPYNY0=; b=TkMIOdwF/U13IdW7iVtB9mx10ArKM+MDU6GLoUR/Aqy5J0IZzSFyciF7ng6Ty/NlY/ hPP6SU8PcufGtpX4rP2at61zff0EojTeFrzKZjzlOm8rmlFbzeGcTHJM84hCI1etLlqv 6ib2gn8smK6fLhJ5ZsCrozOP7cu6rSbBu7JYpquNHx7IScTZ+Jn+opTiSBYrvDqoU1oP s9kKToofiaKU2bIUBaKPL8NpOhnDimT1VEFumfJY3k0jRyBPyTeUqKOvPei7lmDpNp4f jq6D2zO5UaDwe5dyCVLHlMV4JAoXy2kniPZSAVLx4Oghi2AkE47/E0LRqcHnGiJL3h4X bU2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761582092; x=1762186892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vfYJDvWjVZ+hChhkZyh/MhVoN35weXqxL5sr4tPYNY0=; b=TT8PBlq2biestd29PTfbF3+e3//xIciN3YAqgPWXrUP+rooie0jJ9w/3N30jkdplJV 0yjqLM/6pROIxJuU4qxQQZIZYUc5CSjb8Yy1p5a+cXwg2OWogklnODNLqS0t2rqITBOo hXA3LxVt8nc5g3f2JjsjlN/cGGgru1SChX4d4Gh4YxX3IY0CfoUV/XNVwCC5xpBblmF4 ozsp1kdT1Xgjl0dgWIY79b1zvFC82zi07y2NDF1mdhPcNvucgN4KuL4lt1HPnLYtcejS XQ407k5bWGkETiAfbrD1C+Ue5m8LNUuqoA6KwLLov2L5uiy3jc5P2GybuNMoKl/MPuCI 9LtQ== X-Forwarded-Encrypted: i=1; AJvYcCXaWJjdZ1a3vhVdhU3+41zt7KGXTdhNqoc4s0DIgOHn2VbL2aZLTTaneik+HR2YPCvt7jQNM+0=@dpdk.org X-Gm-Message-State: AOJu0YzWYikCzBJfxqXIqsOvuLwx128WbqXV4Uo57BF6K1BxaLq4c6ol 2qn3jv+qmJwYpLQACuZiC+/QfM0SkRO+W3ADzilP9Q+eazIWh7X65YjX X-Gm-Gg: ASbGncv0djrU1N7yMUqpSSChCEcUVTgQQpeQubb2H3k3gBLDbcwWx+MYMdOgQs2mJTf 1sTdHXvMOmeoUVj6RsOKHrVAN0Hn4iXa1U8pfg52JKLW1IaoT/tlUclICqGBY7baNtyZoJiekq+ Ne4SdzpziXdMHoateggjwO4EOW3IehjVM8KdfMGJ/8+4AWF/Hro7uwo0dhBzwagSDiCBvAJsfnS eiB7jwHzeacPcxDxK6VMiZrS2Y90oJpCGoIWEmhpFb470YvlUtwHySceM8ojesAmBOciItHDYYe Kr+cebp26MMNcudFEokf8+XJVY6eifP4eqAqv0uUnY2dJbYB3vJTvU7gRytX41GjhEVjPUTuMa8 OyeWxIY2OdsDBVcggJXdsDUhf5vpG6sG3dTxUUGYWT2inZ6l7dcC/qVYoNFfN6Ua1vzo5ZAfURI kHwlnyvjQj1Ko6qnXn X-Google-Smtp-Source: AGHT+IEH3I99xipuJ5cDYITwh9VvxxCKb7zEugWZlUj1Q6AqZ0vFr43Xxa+4gS6ePuKEubo9mA74nA== X-Received: by 2002:a05:600c:530e:b0:477:c71:1fc7 with SMTP id 5b1f17b1804b1-47717e54ad0mr1661295e9.26.1761582091574; Mon, 27 Oct 2025 09:21:31 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:6fc5:c3bc:147e:832c]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-475dd030b51sm69847235e9.3.2025.10.27.09.21.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:21:31 -0700 (PDT) From: luca.boccassi@gmail.com To: Jacob Keller Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/ice/base: fix memory leak in HW profile handling' has been queued to stable release 22.11.11 Date: Mon, 27 Oct 2025 16:19:04 +0000 Message-ID: <20251027162001.3710450-26-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027162001.3710450-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/29/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/4529cc81367a6de786989fd71963deb9734ed782 Thanks. Luca Boccassi --- >From 4529cc81367a6de786989fd71963deb9734ed782 Mon Sep 17 00:00:00 2001 From: Jacob Keller Date: Tue, 2 Sep 2025 18:26:53 +0100 Subject: [PATCH] net/ice/base: fix memory leak in HW profile handling [ upstream commit bce22ae3a0e61134b5fd19498bd849d1693dadb4 ] The ice_flow_set_hw_prof() function allocates a params structure with ice_malloc. It uses this structure to hold some data temporarily while processing the hardware profile to set. Static analysis indicated that this memory is not released. Fix this function to free the memory upon exit. Fixes: 8ebb93942b2c ("net/ice/base: add function to set HW profile for raw flow") Signed-off-by: Jacob Keller Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/ice/base/ice_flow.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c index 3483a5ed4f..2b06a70cab 100644 --- a/drivers/net/ice/base/ice_flow.c +++ b/drivers/net/ice/base/ice_flow.c @@ -2629,10 +2629,6 @@ ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle, status = ice_flow_assoc_hw_prof(hw, blk, dest_vsi_handle, fdir_vsi_handle, id); - if (status) - goto free_params; - - return ICE_SUCCESS; free_params: ice_free(hw, params); -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-27 15:54:35.834110051 +0000 +++ 0026-net-ice-base-fix-memory-leak-in-HW-profile-handling.patch 2025-10-27 15:54:34.799949649 +0000 @@ -1 +1 @@ -From bce22ae3a0e61134b5fd19498bd849d1693dadb4 Mon Sep 17 00:00:00 2001 +From 4529cc81367a6de786989fd71963deb9734ed782 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bce22ae3a0e61134b5fd19498bd849d1693dadb4 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ - drivers/net/intel/ice/base/ice_flow.c | 4 ---- + drivers/net/ice/base/ice_flow.c | 4 ---- @@ -23,5 +24,5 @@ -diff --git a/drivers/net/intel/ice/base/ice_flow.c b/drivers/net/intel/ice/base/ice_flow.c -index cdc9ee26c5..7b0ecd54df 100644 ---- a/drivers/net/intel/ice/base/ice_flow.c -+++ b/drivers/net/intel/ice/base/ice_flow.c -@@ -2632,10 +2632,6 @@ ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle, +diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c +index 3483a5ed4f..2b06a70cab 100644 +--- a/drivers/net/ice/base/ice_flow.c ++++ b/drivers/net/ice/base/ice_flow.c +@@ -2629,10 +2629,6 @@ ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle, @@ -34 +35 @@ -- return 0; +- return ICE_SUCCESS;