From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E652489EF for ; Mon, 27 Oct 2025 17:22:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 087824068E; Mon, 27 Oct 2025 17:22:43 +0100 (CET) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id 7F5384028B for ; Mon, 27 Oct 2025 17:22:42 +0100 (CET) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3f2cf786abeso2813940f8f.3 for ; Mon, 27 Oct 2025 09:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761582162; x=1762186962; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NEnoOgNzSTjpNLlb8JlTiEI6ITVLCGlxseUPwbSIKDQ=; b=URXc5bkWoI/MypGXjL7UlKdaK/OAMxQdzL+/J6QEMT6RfFgaW+R/Rq6TJr4JcIHJ6f QfNHQdjx9UriF99HTNZc0IyJT2d4+CX8bzYBEKADiOXTEJttTBNovAw9IqXjKeJxlqrX 3G5ghPxpXbXiO4rPqLhTVklT+cvk46egOkhy6h+qQjwfMooHIEw7s58AimVTu27tSKgn JHNoO0MjwToEqPcc6LVOK2C6mWVWSgGoiN98SRK9P+yxfEPfrMi9lQ2x4VRFoB9hevzT +rwnY5RzjLQAB1wP8V73bmPdTnOli4RbL9OiFdOHimDy8LILTOzH61jbQtLXMOm6OBzE wppw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761582162; x=1762186962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NEnoOgNzSTjpNLlb8JlTiEI6ITVLCGlxseUPwbSIKDQ=; b=Q0NQakhFboJ6NeDSI6Xz3/6PFTa8WcXwJYCPjHjyRWCeHgkb0Bx6N05Lk/Rzyg5538 gLKoZ0/v3qjvrxNRjoSz9Bj0P5ZxneY6vlE440MiaN7IBTWuhgj0+2Z7fZbwiQIvyEXi FQl0AjK0jjWt+MfEtTytPzmHrQJjV0y+L79gChqL2h5hncZBXLxfSiedsfB+gtLYR0f0 qxkPYZT5U8eYjPWmmoPLpob+cyvICf6yJdWWTG36LpZRF5Q8fNxCedNbNQGORolcZ//8 Ep5yhPYSkUzWzVqZ9de8EBJ/7cUlhcDvIcQ8a9ihtSfzYipouj+4RwXYS46bxV0L3Kvb rQYw== X-Forwarded-Encrypted: i=1; AJvYcCX8DUMqxJ+egBD922OomV4nnmNO1lt8T0EA6Zq/pYaQIrufsOHVzMIw454bUHU4mcc5TbmNLvY=@dpdk.org X-Gm-Message-State: AOJu0Yz/Eay5Fni5bAcDZg9GDWmwhmthKwktj6HfeJeKNs6bnDUD93z/ y1Pj8FXy9dtbJtIpKk+UDlFvvX+u1INQ2mM/cCULLeaZnOSxmNIkVW72 X-Gm-Gg: ASbGncsBcJKWaKigBLjniGNIrvTCzqNbI5UMfCSDYlPOB3mZUERIx2guy5FbZoZf90s T/U8CB/PjtoHE62E6StKusd6sK1yZ4vk96T5aXEiPjdZ16s1GdYL7RRLkSt5MEkHUglL6A5WA/f fk/B1vLVglDeINJ4X7yjjv/NvKGZcjR8ciZ/UrSTjxWKH/fgbvvEx8tAkXofw0wGnYlLnP56Cb9 rEtlO5MjaXVd9gk+fm0jZ3ZWUBUV2gCDHE7r894Sk4711AI61ORiIWtZzPjWmjIMr+f4K5PmtWe T51qkiLf9Xg1b7tnWNsIK2QtK0SJI7z/Ebb8PRoVpQcDIR9Pkoo+ez99ghUDtwlHbgMrKw5m3K6 PypJGdiKtSeCLwNsdhulIFWWHwyj50suEifkNSlYcOkV53yy/oLm5UW3ndWk7gdTE9WhwomBp0C /TXPjnkQ== X-Google-Smtp-Source: AGHT+IGycboPQYFyOa4yozn6pjVB5/aw1QzPJuVjH7OHKS39j4o1ZEX7z/LlMHrKbznthj2vbu6q1A== X-Received: by 2002:a05:6000:26cf:b0:426:ed9d:4072 with SMTP id ffacd0b85a97d-429a7e59dc9mr226115f8f.21.1761582161885; Mon, 27 Oct 2025 09:22:41 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:6fc5:c3bc:147e:832c]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-429952d9e80sm15150156f8f.28.2025.10.27.09.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:22:41 -0700 (PDT) From: luca.boccassi@gmail.com To: Anurag Mandal Cc: Bruce Richardson , dpdk stable Subject: patch 'net/i40e: fix symmetric Toeplitz hashing for SCTP' has been queued to stable release 22.11.11 Date: Mon, 27 Oct 2025 16:19:27 +0000 Message-ID: <20251027162001.3710450-49-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027162001.3710450-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/29/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/453ba3c522af037bd77cd42e1b309af45bb01686 Thanks. Luca Boccassi --- >From 453ba3c522af037bd77cd42e1b309af45bb01686 Mon Sep 17 00:00:00 2001 From: Anurag Mandal Date: Wed, 15 Oct 2025 23:41:50 +0530 Subject: [PATCH] net/i40e: fix symmetric Toeplitz hashing for SCTP [ upstream commit 09937a3646f83ffe9d0d27896066c3f3f6e4ee0c ] When symmetric toeplitz is configured for SCTP, packets belonging to the same SCTP session are getting distributed to multiple queues due to improper hash computation. Removed SCTP Verification Tag from hash computation of symmetric toeplitz as it changes for same SCTP session. Tested the following with the fix & enabling symmetric toeplitz for SCTP: 1. Packets belonging to the same SCTP session getting into the same queue. 2. Packets belonging to the different SCTP sessions getting distributed to multiple queues. Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") Signed-off-by: Anurag Mandal Acked-by: Bruce Richardson --- .mailmap | 1 + drivers/net/i40e/i40e_hash.c | 16 ++++++++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index f53fdf0d85..6a7af0e981 100644 --- a/.mailmap +++ b/.mailmap @@ -119,6 +119,7 @@ Antara Ganesh Kolar Anthony Fee Antonio Fischetti Anupam Kapoor +Anurag Mandal Apeksha Gupta Archana Muniganti Archit Pandey diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c index 0c84818977..c71c792f1c 100644 --- a/drivers/net/i40e/i40e_hash.c +++ b/drivers/net/i40e/i40e_hash.c @@ -561,7 +561,7 @@ i40e_hash_get_pattern_pctypes(const struct rte_eth_dev *dev, } static uint64_t -i40e_hash_get_inset(uint64_t rss_types) +i40e_hash_get_inset(uint64_t rss_types, bool symmetric_enable) { uint64_t mask, inset = 0; int i; @@ -608,6 +608,17 @@ i40e_hash_get_inset(uint64_t rss_types) I40E_INSET_IPV4_SRC | I40E_INSET_IPV6_SRC); } + /* SCTP Verification Tag is not required in hash computation for SYMMETRIC_TOEPLITZ */ + if (symmetric_enable) { + mask = rss_types & RTE_ETH_RSS_NONFRAG_IPV4_SCTP; + if (mask == RTE_ETH_RSS_NONFRAG_IPV4_SCTP) + inset &= ~I40E_INSET_SCTP_VT; + + mask = rss_types & RTE_ETH_RSS_NONFRAG_IPV6_SCTP; + if (mask == RTE_ETH_RSS_NONFRAG_IPV6_SCTP) + inset &= ~I40E_INSET_SCTP_VT; + } + return inset; } @@ -1113,6 +1124,7 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev, RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL, "RSS Queues not supported when pattern specified"); + rss_conf->symmetric_enable = false; /* by default, symmetric is disabled */ switch (rss_act->func) { case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ: @@ -1140,7 +1152,7 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev, rss_conf->conf.func = rss_act->func; rss_conf->conf.types = rss_act->types; - rss_conf->inset = i40e_hash_get_inset(rss_act->types); + rss_conf->inset = i40e_hash_get_inset(rss_act->types, rss_conf->symmetric_enable); return i40e_hash_get_pattern_pctypes(dev, pattern, rss_act, rss_conf, error); -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-27 15:54:36.614275485 +0000 +++ 0049-net-i40e-fix-symmetric-Toeplitz-hashing-for-SCTP.patch 2025-10-27 15:54:34.819950152 +0000 @@ -1 +1 @@ -From 09937a3646f83ffe9d0d27896066c3f3f6e4ee0c Mon Sep 17 00:00:00 2001 +From 453ba3c522af037bd77cd42e1b309af45bb01686 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 09937a3646f83ffe9d0d27896066c3f3f6e4ee0c ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org @@ -26,2 +27,2 @@ - .mailmap | 1 + - drivers/net/intel/i40e/i40e_hash.c | 16 ++++++++++++++-- + .mailmap | 1 + + drivers/net/i40e/i40e_hash.c | 16 ++++++++++++++-- @@ -31 +32 @@ -index c14288e1c7..adce7ee286 100644 +index f53fdf0d85..6a7af0e981 100644 @@ -34 +35,2 @@ -@@ -136,6 +136,7 @@ Anthony Harivel +@@ -119,6 +119,7 @@ Antara Ganesh Kolar + Anthony Fee @@ -36 +37,0 @@ - Anup Prabhu @@ -42,4 +43,4 @@ -diff --git a/drivers/net/intel/i40e/i40e_hash.c b/drivers/net/intel/i40e/i40e_hash.c -index 02e1457d80..3149682197 100644 ---- a/drivers/net/intel/i40e/i40e_hash.c -+++ b/drivers/net/intel/i40e/i40e_hash.c +diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c +index 0c84818977..c71c792f1c 100644 +--- a/drivers/net/i40e/i40e_hash.c ++++ b/drivers/net/i40e/i40e_hash.c