From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F86C489EF for ; Mon, 27 Oct 2025 17:22:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A52B4028B; Mon, 27 Oct 2025 17:22:45 +0100 (CET) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mails.dpdk.org (Postfix) with ESMTP id C49274067B for ; Mon, 27 Oct 2025 17:22:43 +0100 (CET) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3ed20bdfdffso4937736f8f.2 for ; Mon, 27 Oct 2025 09:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761582163; x=1762186963; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+UeU7Fihn9qXclAXbc72n3SbGTiP+NFiqrRwVnJVTXY=; b=VfWFaX3Em7NqZBHeyVBFe7eERQNrfDK7jXgDUwWNGKhE1fughDuuaLBSfyV6PI3kZ3 1YM6tgHC6mo1xRpx1oudRU2sgJPEd8lshTpa+UCQ6SBQr2A7GW8EXXTuQnZ8m+arjIhM WB5N+x7zXkOqeXXt4AHiHd+bEsYPCRI73zI7Cst94YHAMYwXNPQTBO4nrYQTsL4Zw9sm 5Fasa9OFwYQwuaZ9Oc2aQr2EcjCTjX1pVh//URthCv+SxQglgkk445Rw92cYcq/uTLYP iQI7z0rtndmOJ2z80FiWgef+Hd+eWUb04Dfpu3NFfTo+Ahkm/ks7UHMNwPgw1zRqqkFh e9Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761582163; x=1762186963; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+UeU7Fihn9qXclAXbc72n3SbGTiP+NFiqrRwVnJVTXY=; b=pKst3uWgpQyBQMokMiHnegwopdj7MjbXFW2hwjBQQzbN8Pt02YkfO1Uq1hS3JjfTsz wVqDLUQ9S2IsrThYnzW0XFgEtis5nQlbL4HZMjVeig4N5bPQJ7E1FfrPloTOu0onSGhs BsC73faW05ntJ/TN9HrhvVDUE8scDC1fRFztZ0Tx2Q7ZRKgjDOdsh3dqMKzBGQoi2J3w HciFsdGRdwjgnOq5xLXUTR4E1bgypJp0TfpjP6thLrSb7MRWlemULXtDIvytq1UqM9ao Vd42Cw+FyzXMNThckdHgye8bbbj/yuApPnoOhMqpoAAE1DESBAjwjElNeOxi4Bv+c24P DUYg== X-Forwarded-Encrypted: i=1; AJvYcCW2+mM40FrgiTddATvLyWl2+LLQhl4jTlNQY3PimSZH5ZQ+3qpfUglx9Tu17Xp0FyylKA8p0I0=@dpdk.org X-Gm-Message-State: AOJu0Yy/D6UCAJEjzVyPDkcjTNYF7bAk8kz3SL9qHcHJzchY/Sw35Hw8 uqqx0ddCqrzqsIzA0WpcLxfQqri6ce/6juVZUx4CR6YgIEyrstGuBIKD X-Gm-Gg: ASbGncvev1/TiaK9Yth3rZEuWSXD3Qt41EKNlEy7o92kpLOSZTNt+3gD4m3v8EO+kSZ 575Bw8avgqd/flZn/I8CQvkZz24VXPQdLV+Tqj9KvWZlEZxYV33RMqmQbT6Fld+N0C8FyylQh1x AV16dNRiwdfOBDODY9mhf1RCHEI3p9xLo4Arm9Tl31vqY96vs+BWzaVqeQacCEiIW8jUF+qoSku bnTh7ufXnjNZhdmlhGH0SSYZOwCqhYyzFbZlMyeiecWhyP0Nb9Tk1pW9V2eDbh4fPS1R7D0ni6z R+jAfCHJ/bwTJWkfdUEI9anxkKnGK+Oy2JOeNzXnnlXwwF78JYQo5PfyjPN5l7zfHJSEP35pw4n 5K4hWYeJBnvBfzEkOlNkKl4VpfkUatxMmHVl///KXyXP+tdAey2IxuE+d7SMH8u6hwEf6VZaJH8 bVxLGnWA== X-Google-Smtp-Source: AGHT+IGLAVfymHTx/BUfwpCanIOBApUSUFgzPDNmB6fBoQNgJZFHPMPXlYO3U+8IRAkJ5tH/kbnYcQ== X-Received: by 2002:a05:6000:1a89:b0:427:492:79cd with SMTP id ffacd0b85a97d-429a7e70cb5mr260628f8f.41.1761582163212; Mon, 27 Oct 2025 09:22:43 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:6fc5:c3bc:147e:832c]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-475dd02ce46sm173665775e9.3.2025.10.27.09.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:22:42 -0700 (PDT) From: luca.boccassi@gmail.com To: Gavin Li Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix multicast' has been queued to stable release 22.11.11 Date: Mon, 27 Oct 2025 16:19:28 +0000 Message-ID: <20251027162001.3710450-50-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027162001.3710450-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/29/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/58a6421bc396d0f95c3e9e456bb824b32c5bd014 Thanks. Luca Boccassi --- >From 58a6421bc396d0f95c3e9e456bb824b32c5bd014 Mon Sep 17 00:00:00 2001 From: Gavin Li Date: Fri, 29 Aug 2025 12:08:30 +0300 Subject: [PATCH] net/mlx5: fix multicast [ upstream commit 8c06434cd9e44ef8a4db2eb7e3300c7791c4e7b4 ] Device multicast MAC addresses are managed using the mac_addr_add and mac_addr_remove APIs. In the mlx5_dev_spawn function, devices such as PF, VFs, and SFs obtain the MAC addresses configured in netdev via netlink and store them in the PMD device data, which also includes multicast MAC addresses. Default rules are created for each MAC address to filter traffic accordingly. Previously, multicast MAC address flows were mistakenly disabled, which caused mac_addr_add to stop functioning for multicast MAC addresses, resulting in missed multicast traffic. To address this, default rules for multicast MAC addresses created by PMD should now be set up within mlx5_traffic_enable to properly update and manage multicast MAC address rules. Fixes: 2d0665a7f771 ("net/mlx5: align PF and VF/SF MAC address handling") Signed-off-by: Gavin Li Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_trigger.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index 198eeb019c..af25af47f8 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -1705,7 +1705,10 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) for (i = 0; i != MLX5_MAX_MAC_ADDRESSES; ++i) { struct rte_ether_addr *mac = &dev->data->mac_addrs[i]; - if (!memcmp(mac, &cmp, sizeof(*mac)) || rte_is_multicast_ether_addr(mac)) + /* Add flows for unicast and multicast mac addresses added by API. */ + if (!memcmp(mac, &cmp, sizeof(*mac)) || + !BITFIELD_ISSET(priv->mac_own, i) || + (dev->data->all_multicast && rte_is_multicast_ether_addr(mac))) continue; memcpy(&unicast.dst.addr_bytes, mac->addr_bytes, -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-27 15:54:36.648354451 +0000 +++ 0050-net-mlx5-fix-multicast.patch 2025-10-27 15:54:34.819950152 +0000 @@ -1 +1 @@ -From 8c06434cd9e44ef8a4db2eb7e3300c7791c4e7b4 Mon Sep 17 00:00:00 2001 +From 58a6421bc396d0f95c3e9e456bb824b32c5bd014 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8c06434cd9e44ef8a4db2eb7e3300c7791c4e7b4 ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org @@ -32 +33 @@ -index b104ca9f52..916ac03c16 100644 +index 198eeb019c..af25af47f8 100644 @@ -35 +36 @@ -@@ -1835,7 +1835,10 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) +@@ -1705,7 +1705,10 @@ mlx5_traffic_enable(struct rte_eth_dev *dev) @@ -45 +46 @@ - memcpy(&unicast.hdr.dst_addr.addr_bytes, + memcpy(&unicast.dst.addr_bytes,