From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B5AC489EF for ; Mon, 27 Oct 2025 17:22:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65F9B4068E; Mon, 27 Oct 2025 17:22:58 +0100 (CET) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id 0EFD34028B for ; Mon, 27 Oct 2025 17:22:56 +0100 (CET) Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-421851bca51so4534606f8f.1 for ; Mon, 27 Oct 2025 09:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761582176; x=1762186976; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I3Ao0Uja1MLoLNjEXklrP09Ucg0ZI3jm3m0zOA8XmN0=; b=GRXcw1uIrxOyXL+ESMUWqsptEu+puKTaa+E6mpQ7Kvq0PsuPQzWN2hjgfAfwwUT7IH e2K/KyTQ4DU2LKIV4DTD62cJ91mjpnZX21PuZ75Y1uhBeajnTRcC923EONaw5Y+yLdPF I9G4lvC0PPAapYSRGg0WLlTV8ALV+3s5CSQSpmnNEXgjqSdYBSbh9RxQbf9wWD7tpRJM 3Czk2lcoKJhAHxFbJpgoo7ZcvLUI3zxIBf/HLGBkiMYqHu40wNTrVpQQYC62bPU+LsGz Pr2dUbb/jWFdwEzTOtPyTDxC5eIl6F0CFP2YmJrZ1ueNEncIdgWtDfGyLBGrH1I11FFM 9T5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761582176; x=1762186976; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I3Ao0Uja1MLoLNjEXklrP09Ucg0ZI3jm3m0zOA8XmN0=; b=nVajwz126s6TCAAK0l4yWCylcRBt+TAzF7NQU0k5QX+Eulh02PyN2XJIERrGuzP5L5 s50WqgXmanXrWFnYz06+x0ZFcGyJ1GnfUJPWIRM6K+mpllaPtylUeVpREb1pyaWQFReq I99o3BjKf+WbrNC3uwAKR6yJpY+bPdHk1AvyhO11LoF090MHduiAD5GkeKxZ9Sc+uxrW I2ZSauuj8KjWnFoN8p32IvFZleD/ohMpn0hK5aR6wu8+zNLq91PKas3oRQYecb/IiEWU jRUkpW4EMzrNuCBVv+5kYvQaEmkUus1j2iz7LZAD3DOv35TFfPJWOvdUDg2I9+zMHMyU pODQ== X-Forwarded-Encrypted: i=1; AJvYcCWp5C1/6t94fpxawgJGvzmMoC+tcY4FV+qNXV0VpVRmeVAMtRd0PWoR4Q/BU+mTGf5MfyRvODE=@dpdk.org X-Gm-Message-State: AOJu0YxzX0sfomFRnoBprizAY6T2IlpFJjZr81yKtGupkxwDQtg4/uKe wifPXbhXAP98AuxVvFrK/Tp6blTfarBvjRgKbS3wyFBLaYuUM6n9yCk8 X-Gm-Gg: ASbGncsB6Z8xoKCMF4mQQRrzhJASvnDTHbxzYJktQZt0IjvC16E9Emu7kKojVYiRWlp jTaEVxQzLkFKZxKxNN4rj+SmfWUpinPxnBGJEWP+AOsgVbbkCboUAXyrkDJDC2vg1t9qg9iAt0y BXXDzVGIKwYSt3v2Vo6IxBuvR9M5wAFPmAY5Vrkl9hFbkhnjtqIhee2py5dO2i14mgzNRBL8V0i 9bmajCh0VfUv3mRTxogfh8/9zvJOdNZXr9zTASSNY/U7Dvvv/lH9aMx2YBFpjsSdslk9RCQpt75 CQ21UEEJDswSa+PDTeF5Rjj09E7i6dM1hlQWir0IJe6H47IHWDJyzH7vHpwdQua5hkVBfHoBS5M ggHWM9yMPq7sYtNqrcTm9PXgpFKK2hTKzup4qZv46KmOw9RlhgY63UWLQHp6CzQegC/Y9GYzxdM ygDBvbWA== X-Google-Smtp-Source: AGHT+IFeLmuX2vEylmF237a6LDr81KKVXL/OKdMAIpxuigRiZQN657YKEx9ok37iwB5endjeY5tF2Q== X-Received: by 2002:a05:6000:208a:b0:428:476e:e0ad with SMTP id ffacd0b85a97d-429a7e4ed45mr299076f8f.18.1761582175557; Mon, 27 Oct 2025 09:22:55 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:6fc5:c3bc:147e:832c]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-429952b7a94sm17362523f8f.5.2025.10.27.09.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:22:55 -0700 (PDT) From: luca.boccassi@gmail.com To: Roi Dayan Cc: Bing Zhao , dpdk stable Subject: patch 'net/mlx5: fix leak of flow indexed pools' has been queued to stable release 22.11.11 Date: Mon, 27 Oct 2025 16:19:30 +0000 Message-ID: <20251027162001.3710450-52-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027162001.3710450-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/29/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/3911c9348a430b3b94a0aa8a9f2392f0c58d1b2d Thanks. Luca Boccassi --- >From 3911c9348a430b3b94a0aa8a9f2392f0c58d1b2d Mon Sep 17 00:00:00 2001 From: Roi Dayan Date: Sun, 5 Oct 2025 10:23:45 +0300 Subject: [PATCH] net/mlx5: fix leak of flow indexed pools [ upstream commit eefec46eeb89672815afd6c2497d21b928d77c54 ] The cited commit allocated indexed pools but those pools were never released. Fix it. Fixes: b4edeaf3efd5 ("net/mlx5: replace flow list with indexed pool") Signed-off-by: Roi Dayan Acked-by: Bing Zhao --- .mailmap | 1 + drivers/net/mlx5/mlx5.c | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/.mailmap b/.mailmap index 6a7af0e981..fb9c3d74f9 100644 --- a/.mailmap +++ b/.mailmap @@ -1192,6 +1192,7 @@ Rob Miller Rob Scheepens Roger Melton Rohit Raj +Roi Dayan Roland Qi Rolf Neugebauer Romain Delhomel diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 94873dfe89..357f5eac11 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -2007,6 +2007,18 @@ mlx5_proc_priv_uninit(struct rte_eth_dev *dev) dev->process_private = NULL; } +static void +mlx5_flow_pools_destroy(struct mlx5_priv *priv) +{ + int i; + + for (i = 0; i < MLX5_FLOW_TYPE_MAXI; i++) { + if (!priv->flows[i]) + continue; + mlx5_ipool_destroy(priv->flows[i]); + } +} + /** * DPDK callback to close the device. * @@ -2180,6 +2192,7 @@ mlx5_dev_close(struct rte_eth_dev *dev) if (!c) claim_zero(rte_eth_switch_domain_free(priv->domain_id)); } + mlx5_flow_pools_destroy(priv); memset(priv, 0, sizeof(*priv)); priv->domain_id = RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID; /* -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-27 15:54:36.713332392 +0000 +++ 0052-net-mlx5-fix-leak-of-flow-indexed-pools.patch 2025-10-27 15:54:34.823950251 +0000 @@ -1 +1 @@ -From eefec46eeb89672815afd6c2497d21b928d77c54 Mon Sep 17 00:00:00 2001 +From 3911c9348a430b3b94a0aa8a9f2392f0c58d1b2d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit eefec46eeb89672815afd6c2497d21b928d77c54 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index aef57a4c32..ff13bf09fb 100644 +index 6a7af0e981..fb9c3d74f9 100644 @@ -23,2 +24,2 @@ -@@ -1361,6 +1361,7 @@ Rob Scheepens - Rogelio Domínguez Hernández +@@ -1192,6 +1192,7 @@ Rob Miller + Rob Scheepens @@ -32 +33 @@ -index ece29fb216..b018a4f0e2 100644 +index 94873dfe89..357f5eac11 100644 @@ -35 +36 @@ -@@ -2318,6 +2318,18 @@ mlx5_proc_priv_uninit(struct rte_eth_dev *dev) +@@ -2007,6 +2007,18 @@ mlx5_proc_priv_uninit(struct rte_eth_dev *dev) @@ -54 +55 @@ -@@ -2507,6 +2519,7 @@ mlx5_dev_close(struct rte_eth_dev *dev) +@@ -2180,6 +2192,7 @@ mlx5_dev_close(struct rte_eth_dev *dev)