From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8373489EF for ; Mon, 27 Oct 2025 17:23:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2B2840685; Mon, 27 Oct 2025 17:23:02 +0100 (CET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id 7763740685 for ; Mon, 27 Oct 2025 17:22:59 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47109187c32so26231525e9.2 for ; Mon, 27 Oct 2025 09:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761582179; x=1762186979; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DwBC1hwKFp6fUSSZVAiAdJDv9+ZofiMpK9/9yJvluyM=; b=K1pZHdolcYK9dWdbCL0NxEJf5AkSLHofrWjKvxSGF75aRgNqAWr+Uhn238PFtWgEG6 6lJzC6TMpsbIoM6mOiv2vM1PUAnP/BFDONGyK/eCpjZqUErr8SlRCLF28/R12ehAtaBF NRrq79Yjkcq/L1DYJkzfmSTOrdSWsvWNikRV/DdA6ZLz+7y3urTVAaYyZf1MY70e9gTq Ezvshmw6suc+/a5g375vnQ4qjoU23ShNLNPUMbmffeKtByLKpkyfEvSa0nfhxsFXHhRU qJDNu1cThORdBmZNqezdSLuQeqQKqXYNCeJa8PURKtdVoMA1hqF26vPMKdNOv8Nnpr7B FY5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761582179; x=1762186979; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DwBC1hwKFp6fUSSZVAiAdJDv9+ZofiMpK9/9yJvluyM=; b=m88mv+oFvRRoo8s659vQHNknKuS5pJi4Pehf8ZbEJrKgvt6mNG4xY5tElh3oJKGoqC sSvKFWMMsXl8PQmYiJQMOK9ys9pR77fkMzxMnQUjE29HupufqnnNF7YvzJbdO64HJZjm C4gEShIy020uRtyeKJe5/qul61fxn/7sGye7aiLqV5WIik4QXMjKyp0emUw4AZBB3p3y hpKndUbTR+Ht3fHFEgbv5WlcB+es78bAo3f9JFsJ5SkxHcb8I7sG/GrI1mF4XjI5Gu59 cXJ6FvHD5hCVPlFAnSrWYAYjzFJMnhsulR4u2rHgL8Uh40BPX59s/F0EbGyrTQzRdWUp I7gw== X-Gm-Message-State: AOJu0YyK6XN5VArgy3zzm3h40bUQdq7TQ6eWSZwNgXZCFB1znYJsIhp8 5MMwV9ZXNd4HrZiV4DAbK1eV5iIicR+TCSvo3CsafDyirJkUjdMWNktp X-Gm-Gg: ASbGnct4hX6RNtbmuVZXPFVHx/UyKZz43HZcP0FSpUDqz2+0NfJ/5Oaz7m/a4vrm1Mz wze2Xf02FJZkukV+5w1GEBKo5VAq9HAMPwQgzoGu9LfL06P2hKd5bnWkMcYVR8Vsl5Wc7sBKc1h wVZAIPtG7SX0J8cs9qd7t4gYSExWWl3OPJc7VAccPL/L+PHV1Kvp/viiboTvLX4NH/1f4hgMTw3 B1/KhyQfih/Y5YMSY6JWjyo2kI73ucL7mus4K5yvwr3z1Nh0SDdrF2YlLmyPMvllqF2wZkJaRRc ICpRPiwGn4Jbzafaj3c+PLT/qFrbD0ddCkh8XSsETTXiiaaoO297NVP7+AQ4c4G8iPx56eoHm+5 3rfnpaYdpp8I9+bEjPZTlurLXnBToCQkX0aiiBLy4TX/zsOkdplFD2+YSVcEol9b8m/8iAAYuzw f7LTYFvw== X-Google-Smtp-Source: AGHT+IHS0hL/JLHBQx7mMoQJX8IMZffla0X5/1zO+T5ePGZem31JSWejCuh4f4eiFn7WgxMOfn0pUQ== X-Received: by 2002:a05:6000:26d2:b0:428:3ee0:6965 with SMTP id ffacd0b85a97d-429a7e8938cmr202508f8f.43.1761582178928; Mon, 27 Oct 2025 09:22:58 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:6fc5:c3bc:147e:832c]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-429952df6b9sm15756588f8f.44.2025.10.27.09.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:22:58 -0700 (PDT) From: luca.boccassi@gmail.com To: Kerem Aksu Cc: dpdk stable Subject: patch 'net/af_packet: fix crash in secondary process' has been queued to stable release 22.11.11 Date: Mon, 27 Oct 2025 16:19:33 +0000 Message-ID: <20251027162001.3710450-55-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027162001.3710450-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/29/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/1abf7e31f268f3ec07df0ef96f612cc9f6a9d332 Thanks. Luca Boccassi --- >From 1abf7e31f268f3ec07df0ef96f612cc9f6a9d332 Mon Sep 17 00:00:00 2001 From: Kerem Aksu Date: Fri, 12 Sep 2025 14:35:25 +0300 Subject: [PATCH] net/af_packet: fix crash in secondary process [ upstream commit d57124f60ef60b24cd39e895cf6d211b93b897ae ] dumpcap crashes when trying to capture from af_packet devices. This is caused by allocating interface name with strdup (i.e. malloc). Interface name is not accessible from secondary process and causes segmentation fault. Use rte_malloc instead of strdup to fix the issue. Bugzilla ID: 1786 Fixes: 1b93c2aa81b4 ("net/af_packet: add interface name to internals") Signed-off-by: Kerem Aksu --- .mailmap | 1 + drivers/net/af_packet/rte_eth_af_packet.c | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.mailmap b/.mailmap index fb9c3d74f9..3ff821f286 100644 --- a/.mailmap +++ b/.mailmap @@ -729,6 +729,7 @@ Kefu Chai Keiichi Watanabe Keith Wiles Kent Wires +Kerem Aksu Keunhong Lee Kevin Laatz Kevin Lampis diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index 0b059bfd0b..6803502c74 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -462,7 +462,7 @@ eth_dev_close(struct rte_eth_dev *dev) rte_free(internals->rx_queue[q].rd); rte_free(internals->tx_queue[q].rd); } - free(internals->if_name); + rte_free(internals->if_name); rte_free(internals->rx_queue); rte_free(internals->tx_queue); @@ -752,9 +752,10 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, PMD_LOG_ERRNO(ERR, "%s: ioctl failed (SIOCGIFINDEX)", name); goto free_internals; } - (*internals)->if_name = strdup(pair->value); + (*internals)->if_name = rte_malloc_socket(name, ifnamelen + 1, 0, numa_node); if ((*internals)->if_name == NULL) goto free_internals; + strlcpy((*internals)->if_name, pair->value, ifnamelen + 1); (*internals)->if_index = ifr.ifr_ifindex; if (ioctl(sockfd, SIOCGIFHWADDR, &ifr) == -1) { @@ -941,7 +942,7 @@ error: free_internals: rte_free((*internals)->rx_queue); rte_free((*internals)->tx_queue); - free((*internals)->if_name); + rte_free((*internals)->if_name); rte_free(*internals); return -1; } -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-27 15:54:36.827302727 +0000 +++ 0055-net-af_packet-fix-crash-in-secondary-process.patch 2025-10-27 15:54:34.831950453 +0000 @@ -1 +1 @@ -From d57124f60ef60b24cd39e895cf6d211b93b897ae Mon Sep 17 00:00:00 2001 +From 1abf7e31f268f3ec07df0ef96f612cc9f6a9d332 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d57124f60ef60b24cd39e895cf6d211b93b897ae ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index ff13bf09fb..ff873856cb 100644 +index fb9c3d74f9..3ff821f286 100644 @@ -26 +27 @@ -@@ -830,6 +830,7 @@ Kefu Chai +@@ -729,6 +729,7 @@ Kefu Chai @@ -35 +36 @@ -index 85bc1201b4..de7ff63527 100644 +index 0b059bfd0b..6803502c74 100644 @@ -38 +39 @@ -@@ -525,7 +525,7 @@ eth_dev_close(struct rte_eth_dev *dev) +@@ -462,7 +462,7 @@ eth_dev_close(struct rte_eth_dev *dev) @@ -47 +48 @@ -@@ -875,9 +875,10 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, +@@ -752,9 +752,10 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, @@ -59 +60 @@ -@@ -1063,7 +1064,7 @@ error: +@@ -941,7 +942,7 @@ error: