From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAA5F489EF for ; Mon, 27 Oct 2025 17:20:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B581440647; Mon, 27 Oct 2025 17:20:28 +0100 (CET) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mails.dpdk.org (Postfix) with ESMTP id 0B6E640647 for ; Mon, 27 Oct 2025 17:20:27 +0100 (CET) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4770c2cd96fso14047085e9.3 for ; Mon, 27 Oct 2025 09:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761582027; x=1762186827; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wOoNz+fial/ZNSDJlCuKiecks3mXfUj7tGtJWQPkPpw=; b=V1B3PTD+tH34+EOXKEVsHmFJdhgRhNVSazgP1QeoGdBjrHtMbfQ/SnEoTLE5SRIlr9 r21Gn3ZW/dUOL0ANRdAB9pQ5mzU5vDQcNCKEtqDypAPmibID+9QHLJpQXLbSrRjdHVM7 EhsY94n6LbDmwO3OGSguzu31aF98slmTd+6seRBhpjHnkyYfofcBDw6N4O/UXfpegjLr QVZV0TfmzH/QQLms72HlKhUwf7yX2hiqcBM0/+q8DSWtJ+lYr8TM/PtB5ysn0dYXlxht 2T0OwCtPB3agyocVjvmRBgGeC8IBYlMqS617XHdBvQF3Hhxoe0oNj5Aat/KTG04OLcej 4IVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761582027; x=1762186827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wOoNz+fial/ZNSDJlCuKiecks3mXfUj7tGtJWQPkPpw=; b=TU1oeQ5QIbPj7aH7KHoDoWgl+8yH7TOhcHf34AGi7ZcOGzruvZdF3IvtJMTev4Iskm ZEi6qGehi8ki3f611kd5NMsVYFRyB5rDMlaO54sx0fYXpAFHRs7DvcUjVyqC8aVOQss9 H28ZMzcya6+PHA78d4gazXTW9gDhU3RoOpe7dFlN/mDl2diOKXegt6Eeb1+1w/EY6CJR nJYeopiQBkB2pkRiMy11kpvhWNtkcU8JZAc4rTo17EFIdAhuKqAIqm5OTFdvyRWJqwz8 IQmAkIy789Ws0btT1HEUQ4oWO+PF99Ih2b3rf9hFPQHzAhTdbnVvJuL6yd5Emf8QAxsa rFUw== X-Forwarded-Encrypted: i=1; AJvYcCWGjPkdgyuY/r6jB/UpxRWQDvwywenMng1kLut3llsQ5k4yJnKk8My2TpDmARH9fOjp3MEQD/k=@dpdk.org X-Gm-Message-State: AOJu0Yy2bHmdRuWdUcS9TurAfCfRbLNih+oOvIZ9Yio/QPwNwF6UQ+Aw MeM4Oe8YALHKQdHz5N6uiaB3zuENDYPeyRowCZsu7Azuv9eq8f5wtLs2 X-Gm-Gg: ASbGncsgDA41VvJCWO6qnN9OyUtOQAbyDm1yuEuMfNMFge8ZucwrkMwMse7Uj6qHPoY OUUnfAhVVtERwryiOEMMOg5TQAkqciKAXEJ4iyPuGz+Sa6/pz/H2wz7YpRAueL+XZbsLxi343Tf HHZBSNdDld3hXBPe1rGVTZAN6mgWbf2MI2RUhf1wOEqSa+AbSjmggIrlT8bivW17cwwa4zEh+Sz dOOgo9/H0y0GWnSsZ9SzB6o05gnlAm8iXJDYaKwI53WqI8AwKPKaUQ9A25VCSzAYesew4qqj5+W 7rWmJ6nDGisBQgEBuOkhRzbDfOIGhy5sX3zd1ajAfg3NCjFro+29yArS38VKPC3pPtZUYI9UeVv KY3AFFOiBO8IxsCUCZKKfRPN3BB+o8+gH8YI4XSeidTiL9pckh69DK495o5IkyMscfxsLF2TNEh p3it4i9w== X-Google-Smtp-Source: AGHT+IGYxWdlaFQX+RHCwacCv3EEn49ap/yYx8lhEgwngs1GvjvL+xHnUYihyo1vTAwl6p6O2s+Jaw== X-Received: by 2002:a05:600c:190d:b0:477:e66:4077 with SMTP id 5b1f17b1804b1-47717e67befmr1915885e9.29.1761582026459; Mon, 27 Oct 2025 09:20:26 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:6fc5:c3bc:147e:832c]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-475dd4cba64sm143644965e9.14.2025.10.27.09.20.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:20:25 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Bruce Richardson , Vladimir Medvedkin , Konstantin Ananyev , Chengwen Feng , dpdk stable Subject: patch 'hash: fix unaligned access in predictable RSS' has been queued to stable release 22.11.11 Date: Mon, 27 Oct 2025 16:18:44 +0000 Message-ID: <20251027162001.3710450-6-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027162001.3710450-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/29/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/c9c2860199be5e07d4dade6e1229df0593208a57 Thanks. Luca Boccassi --- >From c9c2860199be5e07d4dade6e1229df0593208a57 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 18 Jun 2025 17:33:38 +0200 Subject: [PATCH] hash: fix unaligned access in predictable RSS [ upstream commit b70d04d8ac6d47b221500d418df1de2b2c65b50a ] Caught by UBSan: ../lib/hash/rte_thash.c:421:8: runtime error: load of misaligned address 0x0001816c2da3 for type 'uint32_t' (aka 'unsigned int'), which requires 4 byte alignment Fixes: 28ebff11c2dc ("hash: add predictable RSS") Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev Acked-by: Chengwen Feng --- lib/hash/rte_thash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index 363603c102..188cfca6c2 100644 --- a/lib/hash/rte_thash.c +++ b/lib/hash/rte_thash.c @@ -437,10 +437,10 @@ generate_subkey(struct rte_thash_ctx *ctx, struct thash_lfsr *lfsr, static inline uint32_t get_subvalue(struct rte_thash_ctx *ctx, uint32_t offset) { - uint32_t *tmp, val; + uint32_t tmp, val; - tmp = (uint32_t *)(&ctx->hash_key[offset >> 3]); - val = rte_be_to_cpu_32(*tmp); + tmp = *(unaligned_uint32_t *)&ctx->hash_key[offset >> 3]; + val = rte_be_to_cpu_32(tmp); val >>= (TOEPLITZ_HASH_LEN - ((offset & (CHAR_BIT - 1)) + ctx->reta_sz_log)); -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-27 15:54:35.075253233 +0000 +++ 0006-hash-fix-unaligned-access-in-predictable-RSS.patch 2025-10-27 15:54:34.719947643 +0000 @@ -1 +1 @@ -From b70d04d8ac6d47b221500d418df1de2b2c65b50a Mon Sep 17 00:00:00 2001 +From c9c2860199be5e07d4dade6e1229df0593208a57 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b70d04d8ac6d47b221500d418df1de2b2c65b50a ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 6c662bf14f..0f9ed20d0d 100644 +index 363603c102..188cfca6c2 100644 @@ -28 +29 @@ -@@ -415,10 +415,10 @@ generate_subkey(struct rte_thash_ctx *ctx, struct thash_lfsr *lfsr, +@@ -437,10 +437,10 @@ generate_subkey(struct rte_thash_ctx *ctx, struct thash_lfsr *lfsr,