From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D92A7489EF for ; Mon, 27 Oct 2025 17:23:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D11014028B; Mon, 27 Oct 2025 17:23:30 +0100 (CET) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id F40E740696 for ; Mon, 27 Oct 2025 17:23:28 +0100 (CET) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-475ca9237c2so27548115e9.3 for ; Mon, 27 Oct 2025 09:23:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761582208; x=1762187008; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nh7PZbKaz6dSpDN61PuiN6oc3/Nj7ybUqfgrPNC56s0=; b=SZvCC8cfFuIPNg8G4MF1vcqwLiDo+Aa37ldjUzHOZ3KL3PVWfwoNerdY1ZVHhEzaLO uI08UATRbmJCOtkbXOGqgdjgdtmc83B4hIOC0sP/ceyIp+SnES/m9oKYttdvHQtUqFzJ Bc5YjULAHMdsIQRRpts2zd1IhISfsyuZRZX8rT0YPj5Z4jNX+VVAIvChg4SkarZn5iB3 1zxe1E6ye69oktlfZ4D/QHdvPtxQ0Ok1XJ+aXxTgrQWD9HUL4LEPJgl7EUa4hGW/bjw8 PLffYaDWlcRtbtho0wN3OxyKn9pQeCYcUNaI5OHTfXPtO7A5TARCqs+KbbFyrW1VwGuJ /5Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761582208; x=1762187008; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nh7PZbKaz6dSpDN61PuiN6oc3/Nj7ybUqfgrPNC56s0=; b=JQ2v8TsDKtqYnT03+Gf2Ez/4GFWhZ7f/GD494osSoEe3W5NgyW4+iDi+Mw0VhPMbZw cpqBhzVzbHa0JtAqNo4XuLe1SIpaoG2OoYnwnl2qRyBEM3KK5V7/M6WqC3f5CJi1AElG pJDScx9byNWswHsuR0hiq3tIwRI91jrjET6Pj2CI15ypOpEhRPWRG78wwybFqllJW9iv 7Cfop6m3COabNVz3konjmkYNceIZPFNXZfhXlGZUHHphzZKeP6Hjt4HRNnzH8X15yESv yFEum8Xp0tkRkHUfazqoS1WULG5MBoWy7GcoCyeEdkprbfeacqYncUfwX06dzBswPCNg 6rrw== X-Forwarded-Encrypted: i=1; AJvYcCXCZrKANqzV/EZwMXuTeHlu7ys3yhkW/UsmFalDZe0aGoshaKQPdlab+nj44C3rGnl2FSRUYk4=@dpdk.org X-Gm-Message-State: AOJu0YzBo9SH8TSip+S0g1XhHbNNtuL3kINDo0HE5kvjkXDsxBacKy8M aAojSocO880C46WXwtQMRV2TitvPqlpItdUpeRImzzRtC2jKxC8PRulSlOq3Q5/8 X-Gm-Gg: ASbGncswpTQ0ZWFRXnlc4D8iak6ddfDCD0PhDXHGeetwKaJbKmADSlDx+kX6+Riciee yQ0ufjVuewS2RniItCyz2yEehugEgHiZIOWg497nHSU2xtRzIowvZ0PyL+CzxPDzeDxmJbcoLym 7AvRbTVUbo3XE0PRR3qiPM6AfccmSzg8pw/Vvj/fk/Avl8omhkkJKoHRyNLDvl/PJVcnAN6gMTW mViM4Yav4tkNZPeghrgRZC39HNc00GlDtd/tuqAreQxihJS9cMccvb2C+WArFgBNTsWaF+fV5Iq UkyFYd7fcHlVeIUFj8nEHSVI+Qd/uc8uzub9IT50NLRnkptdf6mRKkXQoSNU3TGtG+oQzq91pUy spNQwJEX4NpJUw+IDJyoGwiheJCUO1oM0sT4mDLVbm8ylCokSUsEK/9fzr+5yDCmLl4YLHg124m NoiMvcPH1QecwBfox8 X-Google-Smtp-Source: AGHT+IFxqxc4qNKN5nYhpBb4i5qp4Ja47T6Nxi5OPAXFfwwTbW5x8HuqqnmDFwhiKyxdbvPCNcppFw== X-Received: by 2002:a05:6000:43d6:10b0:427:51d:1177 with SMTP id ffacd0b85a97d-429a7e36f8cmr226168f8f.8.1761582208501; Mon, 27 Oct 2025 09:23:28 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:6fc5:c3bc:147e:832c]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-429952b7b43sm15391391f8f.6.2025.10.27.09.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:23:27 -0700 (PDT) From: luca.boccassi@gmail.com To: Hemant Agrawal Cc: Sachin Saxena , dpdk stable Subject: patch 'net/enetfec: fix checksum flag handling and error return' has been queued to stable release 22.11.11 Date: Mon, 27 Oct 2025 16:19:41 +0000 Message-ID: <20251027162001.3710450-63-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027162001.3710450-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/29/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d0777ba4054c3ae9b0555681171076af51db37f6 Thanks. Luca Boccassi --- >From d0777ba4054c3ae9b0555681171076af51db37f6 Mon Sep 17 00:00:00 2001 From: Hemant Agrawal Date: Mon, 6 Oct 2025 13:34:04 +0530 Subject: [PATCH] net/enetfec: fix checksum flag handling and error return [ upstream commit b35089c52802378ed267717f069aa57cb8dce5d2 ] - Corrects the logic for setting RX checksum flags based on error. - Updates TX checksum offload condition to check for TX flags. - Fixes incorrect error return in RX queue setup by replacing `errno` with `-ENOMEM`. Fixes: ecae71571b0d ("net/enetfec: support Rx/Tx") Signed-off-by: Hemant Agrawal Acked-by: Sachin Saxena --- drivers/net/enetfec/enet_rxtx.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/enetfec/enet_rxtx.c b/drivers/net/enetfec/enet_rxtx.c index 0aea8b240d..ea2c28a26b 100644 --- a/drivers/net/enetfec/enet_rxtx.c +++ b/drivers/net/enetfec/enet_rxtx.c @@ -121,10 +121,11 @@ enetfec_recv_pkts(void *rxq1, struct rte_mbuf **rx_pkts, (rxq->fep->flag_csum & RX_FLAG_CSUM_EN)) { if ((rte_read32(&ebdp->bd_esc) & rte_cpu_to_le_32(RX_FLAG_CSUM_ERR)) == 0) { - /* don't check it */ - mbuf->ol_flags = RTE_MBUF_F_RX_IP_CKSUM_BAD; - } else { + /* No checksum error - checksum is good */ mbuf->ol_flags = RTE_MBUF_F_RX_IP_CKSUM_GOOD; + } else { + /* Checksum error detected */ + mbuf->ol_flags = RTE_MBUF_F_RX_IP_CKSUM_BAD; } } @@ -238,7 +239,8 @@ enetfec_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) if (txq->fep->bufdesc_ex) { struct bufdesc_ex *ebdp = (struct bufdesc_ex *)bdp; - if (mbuf->ol_flags == RTE_MBUF_F_RX_IP_CKSUM_GOOD) + if (mbuf->ol_flags & (RTE_MBUF_F_TX_IP_CKSUM | RTE_MBUF_F_TX_TCP_CKSUM | + RTE_MBUF_F_TX_UDP_CKSUM | RTE_MBUF_F_TX_SCTP_CKSUM)) estatus |= TX_BD_PINS | TX_BD_IINS; rte_write32(0, &ebdp->bd_bdu); -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-27 15:54:37.097264651 +0000 +++ 0063-net-enetfec-fix-checksum-flag-handling-and-error-ret.patch 2025-10-27 15:54:34.839950653 +0000 @@ -1 +1 @@ -From b35089c52802378ed267717f069aa57cb8dce5d2 Mon Sep 17 00:00:00 2001 +From d0777ba4054c3ae9b0555681171076af51db37f6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b35089c52802378ed267717f069aa57cb8dce5d2 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org