From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7ED51489EF for ; Mon, 27 Oct 2025 17:24:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A15D4028B; Mon, 27 Oct 2025 17:24:17 +0100 (CET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id 9544D4028B for ; Mon, 27 Oct 2025 17:24:16 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4711b95226dso60836635e9.0 for ; Mon, 27 Oct 2025 09:24:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761582256; x=1762187056; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VqHAnk9TIe0OglSvRLrnwzusUjJ87k/N0mFX/XBJPkA=; b=g6g2hOEPxZQkyJQOSlDT7M3yxvHduvBUNUPiw3GVa0+K7HXjs9rzK5rLTzAqS98MQB /afpQSE8i2ETDVfYT1A7nWO/uyabZxCZFnjEY9ZYRCZqgJ+HnI2DPX2R880rlOiHrXhw OFkL59RpIMGvpFj+oh+1R9P+3ckCmvGcX1mR+/gXPvAKNQglwPGP3gkVT37iPbvB29RO cXXVLusPmd9pjuu2v7kv+2AQJZuqw7liUfUV2RlFhJs90saE0JTKJKIti6OjbxiKEnxh NBB97z6xu/AZ+zPq7R/qYx2FzcspK3L3B2ymxYQRHT1TRI0ZEz2cAAuvNgHSMPEgOVNZ OxDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761582256; x=1762187056; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VqHAnk9TIe0OglSvRLrnwzusUjJ87k/N0mFX/XBJPkA=; b=RS+AIOAWOoFJ/O3BbYS4XmOLaevO0hCBssijweAN40mrYeOwNMRwnT6V5eB4CzD0H+ OeZujoqOSyKfGKJl12VOYZAeACrVtZrHOD3aeINNvLnCOY85duFpsWogFddLbkRrYVlt jqoJYRXeM05YgfSnsDAnY9TI1zIWXQNP8WA4VZ17iHll++TnRaJwU20gGO723loKyWJN s8Ed/SFdaOFwcpUYP4NmGXLr/xpU/0VTm9vD6Qa/tP5+frnz00hlJIETeXrnZDBiwIPm YRqb1GAuPey6DLAK4N1NBi4nNcHeyxVCvLRpUlIDGenAYsmb2BHqWh5HDv3OQr9cQlQu kJWw== X-Forwarded-Encrypted: i=1; AJvYcCU7CoeNNjr4mXs04CgkVN7PBJEP1+V0yY/h7tMbDLUylIgtZOgZIxJBBQMR61QtL0Oh9HAuf/M=@dpdk.org X-Gm-Message-State: AOJu0YyaxVd5cl5QJE9R2GWZAXZcIzdrOiy9dJwv7Gl/YLVo8R7fy6gt aTPheFlHiYmzqYJu8nD3NuDyuYOhKcfJvyE4UdK0+/Q5wmVY3/auc2ce X-Gm-Gg: ASbGncuw2ii+eRn24leWi6u5hDu//CoQOqM3r99YhiBwlt/DLq7IyR79ZxTkl3HGOKs v2kp0SJh4iWUp+BQ2dEr7hDqUx1V4qG3ZhcwWL7LEaa/lil1oAEhy/ukQesoyCt7nwGt//2m6iT KCPoj0DppMvogTz4DqeWTM70GlDHSVmphkLP085pAGMiOdR5Li/RWSILxrILNXSPjs5D1E7MTKb +eWEVD3aes6XT698Vcw1mzGcexZw24BX8xyrdB+r1YcpER+4yZ/9mhsNFYUNSTMED8UlHED0wO4 /Gickk9SORKrBdbqRSJ2DkziISkvFZ7pPdD8PN+uyjAFmRWYbednWILFD1Scn4muYjhFPfAm3Ar PNSKXtO2h1LZ/yUq+o9QFXUl8F0rIWEV07OWKfxGxWrXXs91r/xdLcyleeLoIPfeM18sOy15hbt DLpI+75gHVRiPFAPMi X-Google-Smtp-Source: AGHT+IE+oDGA8H2zFY5Nx3ReUFqC99yxUwusgqgqQW9LQy5/XvKLFbBRpzPbphm2clMxGQktJRfDAg== X-Received: by 2002:a05:600c:46c3:b0:46f:b32e:528f with SMTP id 5b1f17b1804b1-47717df6c5bmr2545695e9.5.1761582256005; Mon, 27 Oct 2025 09:24:16 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:6fc5:c3bc:147e:832c]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-429952d5985sm14947925f8f.25.2025.10.27.09.24.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:24:15 -0700 (PDT) From: luca.boccassi@gmail.com To: Shani Peretz Cc: Kai Ji , Akhil Goyal , dpdk stable Subject: patch 'app/crypto-perf: fix plaintext size exceeds buffer size' has been queued to stable release 22.11.11 Date: Mon, 27 Oct 2025 16:19:54 +0000 Message-ID: <20251027162001.3710450-76-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027162001.3710450-1-luca.boccassi@gmail.com> References: <20251027162001.3710450-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/29/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/49d89d2e003ef9b463d5e10a8a8aaab20a141285 Thanks. Luca Boccassi --- >From 49d89d2e003ef9b463d5e10a8a8aaab20a141285 Mon Sep 17 00:00:00 2001 From: Shani Peretz Date: Mon, 25 Aug 2025 10:14:50 +0300 Subject: [PATCH] app/crypto-perf: fix plaintext size exceeds buffer size [ upstream commit b2988038656b03d1c019114fbe7609018cc16e87 ] When test vector plaintext exceeds buffer size, only the first max_buffer_size bytes are processed, causing incorrect digest verification (computed vs expected mismatch). This patch fixes this issue by checking that the plaintext size is larger than the buffer size and returns an error with a log. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Shani Peretz Acked-by: Kai Ji Acked-by: Akhil Goyal --- .../cperf_test_vector_parsing.c | 47 +++++++++++-------- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c index 737d61d4af..5665fb425b 100644 --- a/app/test-crypto-perf/cperf_test_vector_parsing.c +++ b/app/test-crypto-perf/cperf_test_vector_parsing.c @@ -308,12 +308,19 @@ parse_entry(char *entry, struct cperf_test_vector *vector, if (strstr(key_token, "plaintext")) { rte_free(vector->plaintext.data); vector->plaintext.data = data; + + if (opts->test == CPERF_TEST_TYPE_VERIFY && data_length > opts->max_buffer_size) { + printf("Global plaintext (%u) larger than buffer_sz (%u)\n", + data_length, opts->max_buffer_size); + return -1; + } + if (tc_found) vector->plaintext.length = data_length; else { if (opts->max_buffer_size > data_length) { - printf("Global plaintext shorter than " - "buffer_sz\n"); + printf("Global plaintext (%u) shorter than " + "buffer_sz (%u)\n", data_length, opts->max_buffer_size); return -1; } vector->plaintext.length = opts->max_buffer_size; @@ -326,8 +333,8 @@ parse_entry(char *entry, struct cperf_test_vector *vector, vector->cipher_key.length = data_length; else { if (opts->cipher_key_sz > data_length) { - printf("Global cipher_key shorter than " - "cipher_key_sz\n"); + printf("Global cipher_key (%u) shorter than " + "cipher_key_sz (%u)\n", data_length, opts->cipher_key_sz); return -1; } vector->cipher_key.length = opts->cipher_key_sz; @@ -340,8 +347,8 @@ parse_entry(char *entry, struct cperf_test_vector *vector, vector->auth_key.length = data_length; else { if (opts->auth_key_sz > data_length) { - printf("Global auth_key shorter than " - "auth_key_sz\n"); + printf("Global auth_key (%u) shorter than " + "auth_key_sz (%u)\n", data_length, opts->auth_key_sz); return -1; } vector->auth_key.length = opts->auth_key_sz; @@ -354,8 +361,8 @@ parse_entry(char *entry, struct cperf_test_vector *vector, vector->aead_key.length = data_length; else { if (opts->aead_key_sz > data_length) { - printf("Global aead_key shorter than " - "aead_key_sz\n"); + printf("Global aead_key (%u) shorter than " + "aead_key_sz (%u)\n", data_length, opts->aead_key_sz); return -1; } vector->aead_key.length = opts->aead_key_sz; @@ -368,8 +375,8 @@ parse_entry(char *entry, struct cperf_test_vector *vector, vector->cipher_iv.length = data_length; else { if (opts->cipher_iv_sz > data_length) { - printf("Global cipher iv shorter than " - "cipher_iv_sz\n"); + printf("Global cipher iv (%u) shorter than " + "cipher_iv_sz (%u)\n", data_length, opts->cipher_iv_sz); return -1; } vector->cipher_iv.length = opts->cipher_iv_sz; @@ -382,8 +389,8 @@ parse_entry(char *entry, struct cperf_test_vector *vector, vector->auth_iv.length = data_length; else { if (opts->auth_iv_sz > data_length) { - printf("Global auth iv shorter than " - "auth_iv_sz\n"); + printf("Global auth iv (%u) shorter than " + "auth_iv_sz (%u)\n", data_length, opts->auth_iv_sz); return -1; } vector->auth_iv.length = opts->auth_iv_sz; @@ -396,8 +403,8 @@ parse_entry(char *entry, struct cperf_test_vector *vector, vector->aead_iv.length = data_length; else { if (opts->aead_iv_sz > data_length) { - printf("Global aead iv shorter than " - "aead_iv_sz\n"); + printf("Global aead iv (%u) shorter than " + "aead_iv_sz (%u)\n", data_length, opts->aead_iv_sz); return -1; } vector->aead_iv.length = opts->aead_iv_sz; @@ -410,8 +417,8 @@ parse_entry(char *entry, struct cperf_test_vector *vector, vector->ciphertext.length = data_length; else { if (opts->max_buffer_size > data_length) { - printf("Global ciphertext shorter than " - "buffer_sz\n"); + printf("Global ciphertext (%u) shorter than " + "buffer_sz (%u)\n", data_length, opts->max_buffer_size); return -1; } vector->ciphertext.length = opts->max_buffer_size; @@ -425,8 +432,8 @@ parse_entry(char *entry, struct cperf_test_vector *vector, vector->aad.length = data_length; else { if (opts->aead_aad_sz > data_length) { - printf("Global aad shorter than " - "aead_aad_sz\n"); + printf("Global aad (%u) shorter than " + "aead_aad_sz (%u)\n", data_length, opts->aead_aad_sz); return -1; } vector->aad.length = opts->aead_aad_sz; @@ -441,8 +448,8 @@ parse_entry(char *entry, struct cperf_test_vector *vector, vector->digest.length = data_length; else { if (opts->digest_sz > data_length) { - printf("Global digest shorter than " - "digest_sz\n"); + printf("Global digest (%u) shorter than " + "digest_sz (%u)\n", data_length, opts->digest_sz); return -1; } vector->digest.length = opts->digest_sz; -- 2.47.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-27 15:54:37.551745641 +0000 +++ 0076-app-crypto-perf-fix-plaintext-size-exceeds-buffer-si.patch 2025-10-27 15:54:34.859951155 +0000 @@ -1 +1 @@ -From b2988038656b03d1c019114fbe7609018cc16e87 Mon Sep 17 00:00:00 2001 +From 49d89d2e003ef9b463d5e10a8a8aaab20a141285 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b2988038656b03d1c019114fbe7609018cc16e87 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org