From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Chengwen Feng <fengchengwen@huawei.com>,
Kevin Laatz <kevin.laatz@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] dmadev: fix build if RTE_DMADEV_DEBUG enabled
Date: Wed, 29 Oct 2025 07:32:15 -0700 [thread overview]
Message-ID: <20251029073215.494d130e@phoenix> (raw)
In-Reply-To: <CAJFAV8zi5=hBo6wEWwqr=QZyzodkf1K-39m82Fj9CA+-2SX1PQ@mail.gmail.com>
On Wed, 29 Oct 2025 14:48:13 +0100
David Marchand <david.marchand@redhat.com> wrote:
> On Mon, 27 Oct 2025 at 17:46, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > Missing definition of errnos causes build failure:
> >
> > In file included from ../lib/dmadev/rte_dmadev_trace.h:16,
> > from ../lib/dmadev/rte_dmadev_trace_points.c:8:
> > ../lib/dmadev/rte_dmadev.h: In function ‘rte_dma_copy’:
> > ../lib/dmadev/rte_dmadev.h:1183:25: error: ‘EINVAL’ undeclared (first use in this function)
> > 1183 | return -EINVAL;
> > | ^~~~~~
> >
> > Bugzilla ID: 1814
> > Fixes: 8f1d23ece06a ("eal: deprecate RTE_FUNC_PTR_* macros")
>
> I am not following the rationale... 8f1d23ece06a removed a macro but
> use of errno was already there, so I am skeptical this is the right
> Fixes: tag.
>
> The issue was present from the start, so:
> Fixes: 91e581e5c924 ("dmadev: add data plane API")
>
> > Cc: david.marchand@redhat.com
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
>
Yes, the fixes tag is incorrect. The issue probably goes back further
in time. Might be related to tracepoints not including errno.h
next prev parent reply other threads:[~2025-10-29 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 16:46 Stephen Hemminger
2025-10-28 0:45 ` fengchengwen
2025-10-29 13:48 ` David Marchand
2025-10-29 14:32 ` Stephen Hemminger [this message]
2025-10-29 14:40 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029073215.494d130e@phoenix \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=kevin.laatz@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).