From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8AFD48A48 for ; Wed, 29 Oct 2025 15:32:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D171440609; Wed, 29 Oct 2025 15:32:20 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id E8306402D2 for ; Wed, 29 Oct 2025 15:32:18 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7a4176547bfso4258936b3a.2 for ; Wed, 29 Oct 2025 07:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1761748338; x=1762353138; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/QB1AvB0iBmCeLCBiP3WNQx2iewg81zJ8kxbY+YPZFU=; b=o/i/tFz8lV2/BKMKOQwtJa4PvvL1Zi2cg1fnakvHhs6gfU4YnZDDwvBH+l/U9XgeAf r2LCQjiT1XgZtDr5CXJsJE8qe238h0SNw4FdWs8X7x3tqTNTKh2ucEkevI9GjrPmZXHj TjpVFRCdnIIkJ26391rFLxBV1sw8NBE5ngW+UNrfvk0SoFL0VCTvA1+rlStXwIDkrcqG CazzM5BXO1Ooh5KMYQWa5WcgQgKc6nQbns7Hg3vfcmDpZtqXAv5QGxVjZJ2GpS/gyLwQ yveZL23mJU/tnQLNIIQFLHnkV3HsA7G7YMFHyp1+kYnjDmCueYbH86YNB+jybXM3qcOb 47PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761748338; x=1762353138; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/QB1AvB0iBmCeLCBiP3WNQx2iewg81zJ8kxbY+YPZFU=; b=xMnj6VbTaEtQkyZVCPseU+S4tuq3ZlseT2ssuFmdCLLfmuhYJ2FyARXNvi5fUbmMmg TcAbAEiqhMegkHWZbUxxBimmssG1rkRNCwd83F1bb846kN3Fgs3BBg2HmPtB3dMotmvm P1bu8fuZx7NoNZe653P8t8GvRauvOsfD0zpUDo+v7oo3kCxGZvsP1UQfo7D+2s33O7iq FZZs29UGuAodhRZfyf60/axO7Dux2y8LYWl35TqaapppMqs97Ddbc/0Syc/gSipds8BG A3YdF1mz74i1+GyUxen5fz+PjTkQdA02OcxV0QuP0rxPc5z7Ppxwf/VAly646toCpwvX NlhA== X-Forwarded-Encrypted: i=1; AJvYcCUXT/ceajrUkR2Dz32Xnf3jnZ5vnFYIE7yCJXQWDyZ/eOG2vVLMz61934D1E40Ehz17PmFbsUM=@dpdk.org X-Gm-Message-State: AOJu0YzuLkiw2ZRHqXxqpwkIq39fwnWvmxmZ/6xaIYGkUAjJPOJOvdoj PUfxOAF1/wKL6mSLv4sr6z5srLHygt5synesOzNzJBB2zBKYCWEYNDqPKc0wKUgkL6c= X-Gm-Gg: ASbGncuiD2AVXRcUYgRK0kaydjV8GC3oPx6yftIV0wACRG9ugVdpeAz5K52WfeQIVw9 0MjGXhKxen+QWXkjUllWiokWd43eG1ZkYS1jkrrHWdvLjBPO68Ptxl+3nZiNzykME6r8fbkZrbK XQTeRYgozWUxsJw+TbvSWSC0CHG8nqegHriPTa4RuvCUIaVA1icxy92Ddxbq8u+l8SNfVEQaDci p3lmWXuHv5f8EohUNmEqNLBw8W5hz19YNp7/B5IvYJA/q/N7MOYijdps7T/2EFWhGSCip4kdf07 Kxxkv0SRIiZ55fi4o1TmktH6FVYtDabRXlGQHa3Pohb+4xRdN59NcpP6LmmAjEFmWciBh6F03wr cO8GMh5fyQmRKYSD3+DQ9RQfiSCtGYSwmMqTOwTAzDmPG2Wvr0+c1sYMv+FyauiezJztnKQ7kMS lI2YDewR6ZNDTLBZB+KVQJvf9wyDbv4ot+uA== X-Google-Smtp-Source: AGHT+IG6nM37uZ/uOI1Ew58WP5G5o7CGiBdOrN3zvuOHq+dpDD70cGX6jZ2c/i9OfLHAgOY+BymVlg== X-Received: by 2002:a05:6a00:1742:b0:7a1:49f7:ad04 with SMTP id d2e1a72fcca58-7a4e2dfd22fmr4255157b3a.14.1761748337749; Wed, 29 Oct 2025 07:32:17 -0700 (PDT) Received: from phoenix (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a414012d02sm15884362b3a.4.2025.10.29.07.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Oct 2025 07:32:17 -0700 (PDT) Date: Wed, 29 Oct 2025 07:32:15 -0700 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Chengwen Feng , Kevin Laatz , Bruce Richardson Subject: Re: [PATCH] dmadev: fix build if RTE_DMADEV_DEBUG enabled Message-ID: <20251029073215.494d130e@phoenix> In-Reply-To: References: <20251027164621.175861-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, 29 Oct 2025 14:48:13 +0100 David Marchand wrote: > On Mon, 27 Oct 2025 at 17:46, Stephen Hemminger > wrote: > > > > Missing definition of errnos causes build failure: > > > > In file included from ../lib/dmadev/rte_dmadev_trace.h:16, > > from ../lib/dmadev/rte_dmadev_trace_points.c:8: > > ../lib/dmadev/rte_dmadev.h: In function =E2=80=98rte_dma_copy=E2=80=99: > > ../lib/dmadev/rte_dmadev.h:1183:25: error: =E2=80=98EINVAL=E2=80=99 und= eclared (first use in this function) > > 1183 | return -EINVAL; > > | ^~~~~~ > > > > Bugzilla ID: 1814 > > Fixes: 8f1d23ece06a ("eal: deprecate RTE_FUNC_PTR_* macros") =20 >=20 > I am not following the rationale... 8f1d23ece06a removed a macro but > use of errno was already there, so I am skeptical this is the right > Fixes: tag. >=20 > The issue was present from the start, so: > Fixes: 91e581e5c924 ("dmadev: add data plane API") >=20 > > Cc: david.marchand@redhat.com > > > > Signed-off-by: Stephen Hemminger =20 >=20 >=20 Yes, the fixes tag is incorrect. The issue probably goes back further in time. Might be related to tracepoints not including errno.h