patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: <a.schollmeyer@syseleven.de>
Cc: Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
	Suanming Mou <suanmingm@nvidia.com>,
	Matan Azrad <matan@nvidia.com>, Xueming Li <xuemingl@nvidia.com>,
	<dev@dpdk.org>, Michael Rossberg <michael.rossberg@tu-ilmenau.de>,
	Erez Ferber <erezf@nvidia.com>, <stable@dpdk.org>
Subject: Re: [PATCH v2] net/mlx5: store rxq MTU at allocation time
Date: Thu, 30 Oct 2025 11:40:09 +0100	[thread overview]
Message-ID: <20251030104009.cx74wmofh6ljsukv@ds-vm-debian.local> (raw)
In-Reply-To: <20251030102155.m2uk2us7vzgh3k7h@ds-vm-debian.local>

On Thu, Oct 30, 2025 at 11:21:55AM +0100, Dariusz Sosnowski wrote:
> Hi,
> 
> Thank you very much for applying the changes from last review.
> 
> On Thu, Oct 30, 2025 at 10:13:13AM +0100, a.schollmeyer@syseleven.de wrote:
> > From: Adrian Schollmeyer <a.schollmeyer@syseleven.de>
> > 
> > For shared Rx queues, equal MTU for all ports sharing queues is enforced
> > using mlx5_shared_rxq_match() to make sure, the memory allocated in the
> > Rx buffer is large enough. The check uses the MTU as reported by the
> > ports' private dev_data structs, which contain the MTU currently set for
> > the device. In case one port's MTU is altered after Rx queues are
> > allocated and then a second port joins the shared Rx queue with the old,
> > yet correct MTU, the check fails despite the fact that the Rx buffer
> > size is correct for both ports.
> > 
> > This patch adds a new entry to the Rx queue control structure that
> > captures the MTU at the time the Rx buffer was allocated, since this is
> > the relevant information that needs to be checked when a port joins a
> > shared Rx queue.
> > 
> > Fixes: 09c2555303be ("net/mlx5: support shared Rx queue")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Adrian Schollmeyer <a.schollmeyer@syseleven.de>
> 
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

One other thing, unrelated to the patch content.

Could you please change the state of previous versions of this patch
to "Superseded" in Patchwork?
This would be very helpful since it reduces the amount of patches to track.

This requires creating the account on Patchwork - https://patches.dpdk.org/

Best regards,
Dariusz Sosnowski

  reply	other threads:[~2025-10-30 10:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251028100144.36284-1-a.schollmeyer@syseleven.de>
2025-10-30  9:13 ` a.schollmeyer
2025-10-30 10:21   ` Dariusz Sosnowski
2025-10-30 10:40     ` Dariusz Sosnowski [this message]
2025-10-30 11:21       ` Adrian Schollmeyer
2025-10-30 12:39         ` Dariusz Sosnowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251030104009.cx74wmofh6ljsukv@ds-vm-debian.local \
    --to=dsosnowski@nvidia.com \
    --cc=a.schollmeyer@syseleven.de \
    --cc=bingz@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=erezf@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=michael.rossberg@tu-ilmenau.de \
    --cc=orika@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=suanmingm@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).