From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D53B748A44 for ; Fri, 31 Oct 2025 15:39:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE88D40150; Fri, 31 Oct 2025 15:39:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7E97340150 for ; Fri, 31 Oct 2025 15:39:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7f2ihszwd+i6nCmckfTK5wrneKKsGG9kUiKZYMV+jpc=; b=U7YjNFnDqXMk/sVXHC/GNxgfy7sjz15SaycsxnhaK1ixYUl2yXd5Abao3RRheJicuZh77Q cxk7zGgZsjPI5egQVgMs5rPscxY1bRaE8AnIcGR0eJ1vcXf5MeljDUcwS0lz9PQue9LBuP H6mHx8t3BCZWtHp/d3L7qDwl6A/eWRs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-sgdbIyLHPyOlQxtbKPRMGQ-1; Fri, 31 Oct 2025 10:39:10 -0400 X-MC-Unique: sgdbIyLHPyOlQxtbKPRMGQ-1 X-Mimecast-MFC-AGG-ID: sgdbIyLHPyOlQxtbKPRMGQ_1761921549 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D067A19560A3; Fri, 31 Oct 2025 14:39:09 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1AFF71800579; Fri, 31 Oct 2025 14:39:07 +0000 (UTC) From: Kevin Traynor To: Hemant Agrawal Cc: Sachin Saxena , dpdk stable Subject: patch 'net/enetfec: fix file descriptor leak on read error' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:43 +0000 Message-ID: <20251031143421.324432-101-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ooOx8lmK6TQEQVPY6n_zO93kw_4-eddOkT1_-CbBbSM_1761921549 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/ddebfe7526d396153545507b48cc04f2d7126398 Thanks. Kevin --- >From ddebfe7526d396153545507b48cc04f2d7126398 Mon Sep 17 00:00:00 2001 From: Hemant Agrawal Date: Mon, 6 Oct 2025 13:34:00 +0530 Subject: [PATCH] net/enetfec: fix file descriptor leak on read error [ upstream commit 2e503215692e8ab50e473e963ec58d5ab714a375 ] The file descriptor was not closed when a read error occurred while reading the first line from a UIO device file. This could lead to resource leakage. The patch ensures the descriptor is closed in case of read failure. Fixes: b84fdd39638b ("net/enetfec: support UIO") Signed-off-by: Hemant Agrawal Acked-by: Sachin Saxena --- drivers/net/enetfec/enet_uio.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/enetfec/enet_uio.c b/drivers/net/enetfec/enet_uio.c index 9f4e896985..23cb4e7e93 100644 --- a/drivers/net/enetfec/enet_uio.c +++ b/drivers/net/enetfec/enet_uio.c @@ -1,4 +1,4 @@ /* SPDX-License-Identifier: BSD-3-Clause - * Copyright 2021 NXP + * Copyright 2021,2024 NXP */ @@ -67,6 +67,8 @@ file_read_first_line(const char root[], const char subdir[], fd = open(absolute_file_name, O_RDONLY); - if (fd <= 0) + if (fd < 0) { ENETFEC_PMD_ERR("Error opening file %s", absolute_file_name); + return fd; + } /* read UIO device name from first line in file */ @@ -74,4 +76,5 @@ file_read_first_line(const char root[], const char subdir[], if (ret <= 0) { ENETFEC_PMD_ERR("Error reading file %s", absolute_file_name); + close(fd); return ret; } -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:55.307945432 +0000 +++ 0101-net-enetfec-fix-file-descriptor-leak-on-read-error.patch 2025-10-31 13:53:52.283079063 +0000 @@ -1 +1 @@ -From 2e503215692e8ab50e473e963ec58d5ab714a375 Mon Sep 17 00:00:00 2001 +From ddebfe7526d396153545507b48cc04f2d7126398 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2e503215692e8ab50e473e963ec58d5ab714a375 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org