From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F6FF48A44 for ; Fri, 31 Oct 2025 15:39:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48DCB40150; Fri, 31 Oct 2025 15:39:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 93A3740693 for ; Fri, 31 Oct 2025 15:39:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A9ph+ZYPrLSTK5gGKrpmlF28qVujQOcrGBd5hMJCdfU=; b=C0tZaEdAqJsg5eZLy02YIHP8lXHHTHRFN/X/Yxdu8M8BFgc20DuvNVMjR50kYDJYuHEVaT HGKKOc/VBPyLu5pogi0Ql2qxPBnRtxFb0szTvcZOqiSyQyBAexOwEoGkBCraCxdUUPKbm3 vi+RXAaWy+tX9Rox78beHnmwJFLQTcM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-pezfeCblPhygIngStBzu9w-1; Fri, 31 Oct 2025 10:39:19 -0400 X-MC-Unique: pezfeCblPhygIngStBzu9w-1 X-Mimecast-MFC-AGG-ID: pezfeCblPhygIngStBzu9w_1761921558 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B9508195606C; Fri, 31 Oct 2025 14:39:18 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 18859180044F; Fri, 31 Oct 2025 14:39:16 +0000 (UTC) From: Kevin Traynor To: Hemant Agrawal Cc: Sachin Saxena , dpdk stable Subject: patch 'net/enetfec: fix checksum flag handling and error return' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:47 +0000 Message-ID: <20251031143421.324432-105-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5WLIDqV6Zb1Jnbg6kNE0aADlPkZ_NADEtE63ddF6sG8_1761921558 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/703b931f295de28361ab2d5b68a39f8c3b0297ed Thanks. Kevin --- >From 703b931f295de28361ab2d5b68a39f8c3b0297ed Mon Sep 17 00:00:00 2001 From: Hemant Agrawal Date: Mon, 6 Oct 2025 13:34:04 +0530 Subject: [PATCH] net/enetfec: fix checksum flag handling and error return [ upstream commit b35089c52802378ed267717f069aa57cb8dce5d2 ] - Corrects the logic for setting RX checksum flags based on error. - Updates TX checksum offload condition to check for TX flags. - Fixes incorrect error return in RX queue setup by replacing `errno` with `-ENOMEM`. Fixes: ecae71571b0d ("net/enetfec: support Rx/Tx") Signed-off-by: Hemant Agrawal Acked-by: Sachin Saxena --- drivers/net/enetfec/enet_rxtx.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/enetfec/enet_rxtx.c b/drivers/net/enetfec/enet_rxtx.c index 0aea8b240d..ea2c28a26b 100644 --- a/drivers/net/enetfec/enet_rxtx.c +++ b/drivers/net/enetfec/enet_rxtx.c @@ -122,8 +122,9 @@ enetfec_recv_pkts(void *rxq1, struct rte_mbuf **rx_pkts, if ((rte_read32(&ebdp->bd_esc) & rte_cpu_to_le_32(RX_FLAG_CSUM_ERR)) == 0) { - /* don't check it */ - mbuf->ol_flags = RTE_MBUF_F_RX_IP_CKSUM_BAD; - } else { + /* No checksum error - checksum is good */ mbuf->ol_flags = RTE_MBUF_F_RX_IP_CKSUM_GOOD; + } else { + /* Checksum error detected */ + mbuf->ol_flags = RTE_MBUF_F_RX_IP_CKSUM_BAD; } } @@ -239,5 +240,6 @@ enetfec_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) struct bufdesc_ex *ebdp = (struct bufdesc_ex *)bdp; - if (mbuf->ol_flags == RTE_MBUF_F_RX_IP_CKSUM_GOOD) + if (mbuf->ol_flags & (RTE_MBUF_F_TX_IP_CKSUM | RTE_MBUF_F_TX_TCP_CKSUM | + RTE_MBUF_F_TX_UDP_CKSUM | RTE_MBUF_F_TX_SCTP_CKSUM)) estatus |= TX_BD_PINS | TX_BD_IINS; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:55.414490150 +0000 +++ 0105-net-enetfec-fix-checksum-flag-handling-and-error-ret.patch 2025-10-31 13:53:52.284524142 +0000 @@ -1 +1 @@ -From b35089c52802378ed267717f069aa57cb8dce5d2 Mon Sep 17 00:00:00 2001 +From 703b931f295de28361ab2d5b68a39f8c3b0297ed Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b35089c52802378ed267717f069aa57cb8dce5d2 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org