From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BE4B48A44 for ; Fri, 31 Oct 2025 15:35:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04FA640661; Fri, 31 Oct 2025 15:35:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B545140655 for ; Fri, 31 Oct 2025 15:35:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6CRCy/wi5R53hYrjCt5u4euvsZ97IK/eA04t1hAEaoA=; b=iB5UVfq+Sa2OaH2gyqZkIbupYGN86NyiUEbKUuzgRfRLd9jEVMOh6jQwgpKQR0TpoXrx8l vidRnYHvCptrWXqm/2SNL9FIJxo9OCAhAiA5GapeYuFWp1jXddVWBkoE6yGrd+cUCLIug0 Z5wlEXCDwLm7NgSrDVyF5PPkhxHmDoE= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-W_tiPudJO5qEZ_3JqRV2jQ-1; Fri, 31 Oct 2025 10:35:40 -0400 X-MC-Unique: W_tiPudJO5qEZ_3JqRV2jQ-1 X-Mimecast-MFC-AGG-ID: W_tiPudJO5qEZ_3JqRV2jQ_1761921339 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B0A151954B06; Fri, 31 Oct 2025 14:35:39 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 289B118004D4; Fri, 31 Oct 2025 14:35:37 +0000 (UTC) From: Kevin Traynor To: Joshua Washington Cc: Ankit Garg , dpdk stable Subject: patch 'net/gve: do not write zero-length descriptors' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:13 +0000 Message-ID: <20251031143421.324432-11-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gFVG_HSBQvORc8gKrirxGJM3tIG4dxdJ2jDQ6PtEzmY_1761921339 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b343e73b03049fbd627c62ab9ae8b40360550ac1 Thanks. Kevin --- >From b343e73b03049fbd627c62ab9ae8b40360550ac1 Mon Sep 17 00:00:00 2001 From: Joshua Washington Date: Mon, 7 Jul 2025 16:18:07 -0700 Subject: [PATCH] net/gve: do not write zero-length descriptors [ upstream commit 671d15dad5f41cda4887ca3bb73afafc1b9768e3 ] Writing zero-length descriptors to the hardware can cause the hardware to reject that packet and stop transmitting altogether. Fixes: 4022f9999f56 ("net/gve: support basic Tx data path for DQO") Signed-off-by: Joshua Washington Reviewed-by: Ankit Garg --- drivers/net/gve/gve_tx_dqo.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c index 652a0e5175..b2e5aae634 100644 --- a/drivers/net/gve/gve_tx_dqo.c +++ b/drivers/net/gve/gve_tx_dqo.c @@ -169,4 +169,9 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) PMD_DRV_LOG(DEBUG, "Overwriting an entry in sw_ring"); + /* Skip writing descriptor if mbuf has no data. */ + if (!tx_pkt->data_len) + goto finish_mbuf; + + txd = &txr[tx_id]; sw_ring[sw_id] = tx_pkt; @@ -190,4 +195,5 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) } +finish_mbuf: sw_id = (sw_id + 1) & sw_mask; bytes += tx_pkt->data_len; @@ -195,5 +201,6 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) } while (tx_pkt); - /* fill the last descriptor with End of Packet (EOP) bit */ + /* fill the last written descriptor with End of Packet (EOP) bit */ + txd = &txr[(tx_id - 1) & mask]; txd->pkt.end_of_packet = 1; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:52.630832332 +0000 +++ 0011-net-gve-do-not-write-zero-length-descriptors.patch 2025-10-31 13:53:52.017426238 +0000 @@ -1 +1 @@ -From 671d15dad5f41cda4887ca3bb73afafc1b9768e3 Mon Sep 17 00:00:00 2001 +From b343e73b03049fbd627c62ab9ae8b40360550ac1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 671d15dad5f41cda4887ca3bb73afafc1b9768e3 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org