From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECF5748A44 for ; Fri, 31 Oct 2025 15:39:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4E9040150; Fri, 31 Oct 2025 15:39:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BFDCA40150 for ; Fri, 31 Oct 2025 15:39:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A3MLY2vCDoAvA2MiSfu4GIbnBKsxPvzSqGqGD8kkwxw=; b=Zqpwfe1j/Dm65FO6VjdG/e+/DDIWqFpVXEYaK9vhux+JDAD631PENa3eOpezvqOiHwLoOE BJYmVNIkCTdfPq6X8Cr6UPlu9A6cE2Iqh8Q5CPZuXiQnE0VLNNj60NY1TD0A79BIh8kF9o wCwdtN9z0XFI9VcmO60ko1opffrelMc= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-fEtLjRpdO6Ki5qJgzh8UGw-1; Fri, 31 Oct 2025 10:39:30 -0400 X-MC-Unique: fEtLjRpdO6Ki5qJgzh8UGw-1 X-Mimecast-MFC-AGG-ID: fEtLjRpdO6Ki5qJgzh8UGw_1761921569 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 636281800D86; Fri, 31 Oct 2025 14:39:29 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1334E18004D4; Fri, 31 Oct 2025 14:39:27 +0000 (UTC) From: Kevin Traynor To: Serhii Iliushyk Cc: dpdk stable Subject: patch 'net/ntnic: fix potential format overflow' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:52 +0000 Message-ID: <20251031143421.324432-110-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AX7HSrs3Nqfyq28SIiHseZCdZLWqctlOO9l-UETlqTo_1761921569 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e8db19ca4d93831e6ff5a39bd9315b53950eff57 Thanks. Kevin --- >From e8db19ca4d93831e6ff5a39bd9315b53950eff57 Mon Sep 17 00:00:00 2001 From: Serhii Iliushyk Date: Mon, 20 Oct 2025 18:35:59 +0200 Subject: [PATCH] net/ntnic: fix potential format overflow [ upstream commit f5f6e545d91875845287f3c2a0b34b22d309028d ] Use snprintf instead sprintf to avoid format overflow Fixes: d3dc362770d9 ("net/ntnic: add adapter initialization") Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/ntnic_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntnic_ethdev.c index 3c668a41ef..ee9b5a6abb 100644 --- a/drivers/net/ntnic/ntnic_ethdev.c +++ b/drivers/net/ntnic/ntnic_ethdev.c @@ -2472,5 +2472,5 @@ nthw_pci_dev_deinit(struct rte_eth_dev *eth_dev __rte_unused) int i; - char name[32]; + char name[RTE_ETH_NAME_MAX_LEN]; struct pmd_internals *internals = eth_dev->data->dev_private; @@ -2499,5 +2499,5 @@ nthw_pci_dev_deinit(struct rte_eth_dev *eth_dev __rte_unused) for (i = 0; i < n_phy_ports; i++) { - sprintf(name, "ntnic%d", i); + snprintf(name, sizeof(name), "ntnic%d", i); eth_dev = rte_eth_dev_allocated(name); if (eth_dev == NULL) -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:55.550905602 +0000 +++ 0110-net-ntnic-fix-potential-format-overflow.patch 2025-10-31 13:53:52.288524155 +0000 @@ -1 +1 @@ -From f5f6e545d91875845287f3c2a0b34b22d309028d Mon Sep 17 00:00:00 2001 +From e8db19ca4d93831e6ff5a39bd9315b53950eff57 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f5f6e545d91875845287f3c2a0b34b22d309028d ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ -index a867e7b16d..58be82b2d2 100644 +index 3c668a41ef..ee9b5a6abb 100644 @@ -20 +21 @@ -@@ -2614,5 +2614,5 @@ nthw_pci_dev_deinit(struct rte_eth_dev *eth_dev __rte_unused) +@@ -2472,5 +2472,5 @@ nthw_pci_dev_deinit(struct rte_eth_dev *eth_dev __rte_unused) @@ -27 +28 @@ -@@ -2641,5 +2641,5 @@ nthw_pci_dev_deinit(struct rte_eth_dev *eth_dev __rte_unused) +@@ -2499,5 +2499,5 @@ nthw_pci_dev_deinit(struct rte_eth_dev *eth_dev __rte_unused)