From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F81948A44 for ; Fri, 31 Oct 2025 15:39:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3711F40150; Fri, 31 Oct 2025 15:39:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 37BFA4069F for ; Fri, 31 Oct 2025 15:39:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LjMnCAhtUbZjKW3gvTz5iSrb6YPesTJKJERNHQGHeL8=; b=ZqmNlHjVVexBHSsegv/sia64c8f0Uj5ve9kpcfo2STRG+I2db8ALQnVKAMRE3OpP6l6UYP EbjAhIKfFW+jK4lYVYDuN4Wu+PNh3C2Rnx7bFTneTQXZL3GUEqtb6JTavobeWgiek1BKZr oj/3RzeMNEq31y/+8AfEitT3P4B3K7Q= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-DmYY1zjeO2iIuXW6DkbM5w-1; Fri, 31 Oct 2025 10:39:35 -0400 X-MC-Unique: DmYY1zjeO2iIuXW6DkbM5w-1 X-Mimecast-MFC-AGG-ID: DmYY1zjeO2iIuXW6DkbM5w_1761921574 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4D9261800744; Fri, 31 Oct 2025 14:39:34 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6FDFB180044F; Fri, 31 Oct 2025 14:39:32 +0000 (UTC) From: Kevin Traynor To: Shai Brandes Cc: Amit Bernstein , Yosef Raisman , dpdk stable Subject: patch 'net/ena/base: fix unsafe memcpy on invalid memory' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:33:54 +0000 Message-ID: <20251031143421.324432-112-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: T_t9hvv5gUBdOFT08g667BDSBiWVpn7kIfo5TOPqz8c_1761921574 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/7a28479ec749426cf5f36f6d0dac984b97b26316 Thanks. Kevin --- >From 7a28479ec749426cf5f36f6d0dac984b97b26316 Mon Sep 17 00:00:00 2001 From: Shai Brandes Date: Wed, 15 Oct 2025 15:12:30 +0300 Subject: [PATCH] net/ena/base: fix unsafe memcpy on invalid memory [ upstream commit b70db0912a6a181ecf513a4eef61153d1063c0ae ] The return status check was placed after a memcpy operation, which could result in copying from an invalid memory region if the feature fetch failed. Fixes: b68309be44c0 ("net/ena/base: update communication layer for the ENAv2") Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein Reviewed-by: Yosef Raisman --- drivers/net/ena/base/ena_com.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c index 24bad19848..5acea3c4a8 100644 --- a/drivers/net/ena/base/ena_com.c +++ b/drivers/net/ena/base/ena_com.c @@ -2330,11 +2330,11 @@ int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev, rc = ena_com_get_feature(ena_dev, &get_resp, ENA_ADMIN_MAX_QUEUES_NUM, 0); + if (rc) + return rc; + memcpy(&get_feat_ctx->max_queues, &get_resp.u.max_queue, sizeof(get_resp.u.max_queue)); ena_dev->tx_max_header_size = get_resp.u.max_queue.max_header_size; - - if (rc) - return rc; } -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:55.608819340 +0000 +++ 0112-net-ena-base-fix-unsafe-memcpy-on-invalid-memory.patch 2025-10-31 13:53:52.291524164 +0000 @@ -1 +1 @@ -From b70db0912a6a181ecf513a4eef61153d1063c0ae Mon Sep 17 00:00:00 2001 +From 7a28479ec749426cf5f36f6d0dac984b97b26316 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b70db0912a6a181ecf513a4eef61153d1063c0ae ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index ede3c06139..f0936a6262 100644 +index 24bad19848..5acea3c4a8 100644 @@ -24 +25 @@ -@@ -2454,11 +2454,11 @@ int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev, +@@ -2330,11 +2330,11 @@ int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev,