From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3996C48A44 for ; Fri, 31 Oct 2025 15:39:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30CBB40150; Fri, 31 Oct 2025 15:39:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BFBD940150 for ; Fri, 31 Oct 2025 15:39:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cp8R250nrNKKX15JBPuXM502Pcv0DnE7xJqyDuLc5B8=; b=Orhh5c1qXpuPYnWDL+4wTIGsObLtujx8SSW1aAJtL6GkBGZkoN11P3eB7AndXaM17LL2Rs F1JcP7CuNTy+WLUEg0RF4tPRDHh7ziHA8eNyVomfzjCYEFOwFR3G0oH06NQIxPWvk0Q7r5 /eDvlg2cIA5/GtuvEK+welnM9B+BjKA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-fxWTcS6PO-GpKcVO3I1BNg-1; Fri, 31 Oct 2025 10:39:49 -0400 X-MC-Unique: fxWTcS6PO-GpKcVO3I1BNg-1 X-Mimecast-MFC-AGG-ID: fxWTcS6PO-GpKcVO3I1BNg_1761921588 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 10C70195605F; Fri, 31 Oct 2025 14:39:48 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5DFEB180044F; Fri, 31 Oct 2025 14:39:46 +0000 (UTC) From: Kevin Traynor To: Radu Nicolau Cc: Kai Ji , dpdk stable Subject: patch 'crypto/qat: fix ECDH' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:34:01 +0000 Message-ID: <20251031143421.324432-119-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: f4a09TtQLhKX_5u1FlEr3rihxe8ECuqqiOXuL6NZL-U_1761921588 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4267e03a57b701dd426cb4cf8538a66845798300 Thanks. Kevin --- >From 4267e03a57b701dd426cb4cf8538a66845798300 Mon Sep 17 00:00:00 2001 From: Radu Nicolau Date: Wed, 27 Aug 2025 09:23:58 +0000 Subject: [PATCH] crypto/qat: fix ECDH [ upstream commit 25ef596203a94c79b1c9fa8504839c3f41da1a57 ] Read EC parameters from the xform, not from the asym_op, where they may not be set. Fixes: 305e1f856f0c ("crypto/qat: add ECDH key exchange algorithm") Signed-off-by: Radu Nicolau Acked-by: Kai Ji --- drivers/crypto/qat/qat_asym.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c index f5b56b2f71..dff7efbbff 100644 --- a/drivers/crypto/qat/qat_asym.c +++ b/drivers/crypto/qat/qat_asym.c @@ -802,11 +802,11 @@ ecdh_set_input(struct icp_qat_fw_pke_request *qat_req, if (asym_op->ecdh.ke_type == RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE) { - SET_PKE_LN(asym_op->ecdh.priv_key, qat_func_alignsize, 0); + SET_PKE_LN(xform->ec.pkey, qat_func_alignsize, 0); SET_PKE_LN_EC(curve[curve_id], x, 1); SET_PKE_LN_EC(curve[curve_id], y, 2); } else { - SET_PKE_LN(asym_op->ecdh.priv_key, qat_func_alignsize, 0); - SET_PKE_LN(asym_op->ecdh.pub_key.x, qat_func_alignsize, 1); - SET_PKE_LN(asym_op->ecdh.pub_key.y, qat_func_alignsize, 2); + SET_PKE_LN(xform->ec.pkey, qat_func_alignsize, 0); + SET_PKE_LN(xform->ec.q.x, qat_func_alignsize, 1); + SET_PKE_LN(xform->ec.q.y, qat_func_alignsize, 2); } SET_PKE_LN_EC(curve[curve_id], a, 3); -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:55.806440211 +0000 +++ 0119-crypto-qat-fix-ECDH.patch 2025-10-31 13:53:52.301610602 +0000 @@ -1 +1 @@ -From 25ef596203a94c79b1c9fa8504839c3f41da1a57 Mon Sep 17 00:00:00 2001 +From 4267e03a57b701dd426cb4cf8538a66845798300 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 25ef596203a94c79b1c9fa8504839c3f41da1a57 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 80f7e5cda2..8808337551 100644 +index f5b56b2f71..dff7efbbff 100644 @@ -22 +23 @@ -@@ -799,11 +799,11 @@ ecdh_set_input(struct icp_qat_fw_pke_request *qat_req, +@@ -802,11 +802,11 @@ ecdh_set_input(struct icp_qat_fw_pke_request *qat_req, @@ -29 +30 @@ - } else if (asym_op->ecdh.ke_type == RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE) { + } else { @@ -36,2 +37,2 @@ - } else { - return -EINVAL; + } + SET_PKE_LN_EC(curve[curve_id], a, 3);