From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 048A648A44 for ; Fri, 31 Oct 2025 15:40:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1D04406B6; Fri, 31 Oct 2025 15:40:04 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 59B3840150 for ; Fri, 31 Oct 2025 15:40:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hb6GFCAatyurk4Af4Azd2JPiq1LrH2yY0R/eNbhpLh4=; b=iP+dsN/T8z44iofQXeJeP8L+M2qExGAWTh8P8MHJoXkp2l72Vq28/lPcaDr8ylrQ7xdYBB TfJcYh+tt0JTVcU0mbbW61/HLHzSJe9VJsZAPsm3fbEOm7dTCLv49RPU8Smh2YPs+bqIbY /I9RL0C+9P+ga0jYxyYH4lNz78KdNQU= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-VoO7hYkVMFyK9ekPoPLdJA-1; Fri, 31 Oct 2025 10:40:01 -0400 X-MC-Unique: VoO7hYkVMFyK9ekPoPLdJA-1 X-Mimecast-MFC-AGG-ID: VoO7hYkVMFyK9ekPoPLdJA_1761921600 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9CE4B1800669; Fri, 31 Oct 2025 14:40:00 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5F2C7180057E; Fri, 31 Oct 2025 14:39:59 +0000 (UTC) From: Kevin Traynor To: Gowrishankar Muthukrishnan Cc: dpdk stable Subject: patch 'crypto/virtio: fix cookies leak' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:34:07 +0000 Message-ID: <20251031143421.324432-125-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: H9y86LJ-xGVzzx4MEQ1aKXv6dfXYj7EDsIL3e_PCh2w_1761921600 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2effa20c58fba0b2702681c7ee063786abc36f4c Thanks. Kevin --- >From 2effa20c58fba0b2702681c7ee063786abc36f4c Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Sat, 11 Oct 2025 10:07:03 +0530 Subject: [PATCH] crypto/virtio: fix cookies leak [ upstream commit 8b0d855fd98c6c88665489fdba12f8e603deae21 ] Free memory used by virt queue op cookies in dev close. Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD ops") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/virtio_cryptodev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c index 034a479994..c933f16d2d 100644 --- a/drivers/crypto/virtio/virtio_cryptodev.c +++ b/drivers/crypto/virtio/virtio_cryptodev.c @@ -266,4 +266,5 @@ virtio_crypto_queue_release(struct virtqueue *vq) { struct virtio_crypto_hw *hw; + uint16_t i; PMD_INIT_FUNC_TRACE(); @@ -276,4 +277,7 @@ virtio_crypto_queue_release(struct virtqueue *vq) rte_memzone_free(vq->mz); rte_mempool_free(vq->mpool); + for (i = 0; i < vq->vq_nentries; i++) + rte_free(vq->vq_descx[i].cookie); + rte_free(vq); } -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:55.988028386 +0000 +++ 0125-crypto-virtio-fix-cookies-leak.patch 2025-10-31 13:53:52.322524261 +0000 @@ -1 +1 @@ -From 8b0d855fd98c6c88665489fdba12f8e603deae21 Mon Sep 17 00:00:00 2001 +From 2effa20c58fba0b2702681c7ee063786abc36f4c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8b0d855fd98c6c88665489fdba12f8e603deae21 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ -index d661ce8025..6f079f15f6 100644 +index 034a479994..c933f16d2d 100644 @@ -20 +21 @@ -@@ -69,4 +69,5 @@ virtio_crypto_queue_release(struct virtqueue *vq) +@@ -266,4 +266,5 @@ virtio_crypto_queue_release(struct virtqueue *vq) @@ -26 +27 @@ -@@ -80,4 +81,7 @@ virtio_crypto_queue_release(struct virtqueue *vq) +@@ -276,4 +277,7 @@ virtio_crypto_queue_release(struct virtqueue *vq)