From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20BF148A44 for ; Fri, 31 Oct 2025 15:40:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1909B40150; Fri, 31 Oct 2025 15:40:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 496E340150 for ; Fri, 31 Oct 2025 15:40:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XlSs0I6CeV3ngQueMMawWCgljGf/TKb8kPU5c9osFVg=; b=C5UmXuzyipI/tS2CgP6XqTpJJOHiEasCc3ZfqsoImKLF/OM/5Mjp7o/AVOHeVMytv30lcr KsGYVClyo3cQ2HP2uR7pnzUciH1LQfxwaI2RmRN1YzOxa3CgR8Lzz4xWhnikTiDGYgMZm3 2aML3/bfoEgpU193SYMn2Hn06Ld37z8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-IEt5u8BSPMm0W4778CpEwg-1; Fri, 31 Oct 2025 10:40:04 -0400 X-MC-Unique: IEt5u8BSPMm0W4778CpEwg-1 X-Mimecast-MFC-AGG-ID: IEt5u8BSPMm0W4778CpEwg_1761921603 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5DB021800675; Fri, 31 Oct 2025 14:40:03 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 51DA0180044F; Fri, 31 Oct 2025 14:40:00 +0000 (UTC) From: Kevin Traynor To: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Cc: Bruce Richardson , =?UTF-8?q?Morten=20Br=C3=B8rup?= , dpdk stable Subject: patch 'bitops: improve power of 2 alignment documentation' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:34:08 +0000 Message-ID: <20251031143421.324432-126-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 34A-LSiBM5StRmIFNhcUvDcxXrF3ULz5p9TAHtpgqD8_1761921603 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a44f69f6a7af98679f26c6432e1b36c1e852ae92 Thanks. Kevin --- >From a44f69f6a7af98679f26c6432e1b36c1e852ae92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Date: Tue, 22 Jul 2025 09:53:21 +0200 Subject: [PATCH] bitops: improve power of 2 alignment documentation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit f9f773fe2d6f49f1223283dc3e75198f2e6c0664 ] In the documentation, make clear rte_align(32|64)prevpow2() -> , provided is a power of 2. The original documentation stated the "previous" power of 2 would be returned, potentially leaving the user to erroneously conclude that, for example, rte_align32prevpow2(32) -> 16. The rte_align(32|64)pow2() documentation, suffering from a similar issue, is reworded in the same manner. Fixes: 08f683174e94 ("eal: add functions for previous power of 2 alignment") Signed-off-by: Mattias Rönnblom Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/eal/include/rte_bitops.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h index deb1fd43f2..fbabd9bdd5 100644 --- a/lib/eal/include/rte_bitops.h +++ b/lib/eal/include/rte_bitops.h @@ -1235,5 +1235,5 @@ rte_is_power_of_2(uint32_t n) * * @return - * Input parameter aligned to the next power of 2 + * The smallest power of 2 which is greater than or equal to @c x. */ static inline uint32_t @@ -1253,5 +1253,5 @@ rte_align32pow2(uint32_t x) * * @return - * Input parameter aligned to the previous power of 2 + * The greatest power of 2 which is smaller than or equal to @c x. */ static inline uint32_t @@ -1270,5 +1270,5 @@ rte_align32prevpow2(uint32_t x) * * @return - * Input parameter aligned to the next power of 2 + * The smallest power of 2 which is greater than or equal to @c v. */ static inline uint64_t @@ -1288,5 +1288,5 @@ rte_align64pow2(uint64_t v) * * @return - * Input parameter aligned to the previous power of 2 + * The greatest power of 2 which is smaller than or equal to @c v. */ static inline uint64_t -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:56.015143069 +0000 +++ 0126-bitops-improve-power-of-2-alignment-documentation.patch 2025-10-31 13:53:52.323524264 +0000 @@ -1 +1 @@ -From f9f773fe2d6f49f1223283dc3e75198f2e6c0664 Mon Sep 17 00:00:00 2001 +From a44f69f6a7af98679f26c6432e1b36c1e852ae92 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit f9f773fe2d6f49f1223283dc3e75198f2e6c0664 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -30 +31 @@ -index b9a6af381b..2d1b9d281c 100644 +index deb1fd43f2..fbabd9bdd5 100644 @@ -33 +34 @@ -@@ -1321,5 +1321,5 @@ rte_is_power_of_2(uint32_t n) +@@ -1235,5 +1235,5 @@ rte_is_power_of_2(uint32_t n) @@ -40 +41 @@ -@@ -1339,5 +1339,5 @@ rte_align32pow2(uint32_t x) +@@ -1253,5 +1253,5 @@ rte_align32pow2(uint32_t x) @@ -47 +48 @@ -@@ -1356,5 +1356,5 @@ rte_align32prevpow2(uint32_t x) +@@ -1270,5 +1270,5 @@ rte_align32prevpow2(uint32_t x) @@ -54 +55 @@ -@@ -1374,5 +1374,5 @@ rte_align64pow2(uint64_t v) +@@ -1288,5 +1288,5 @@ rte_align64pow2(uint64_t v)