From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F75F48A44 for ; Fri, 31 Oct 2025 15:35:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3900B40655; Fri, 31 Oct 2025 15:35:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0FA4A40655 for ; Fri, 31 Oct 2025 15:35:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oG01adI3NsSCDpeaaFxVjJlvxeZ+6NtxLSajlft5ZpI=; b=HOewaZ7pEvq56bivjqcY8sfzHNvZ+sjX/v7wQ4k20MlHJreppu9c2YrzggaLLGwb81H7ib Db40+bpmaFTYj2//t6322GlKa7VKOnZuNMOEf1hiLjRI6+nVs8pk2nLXJWZ44wCIK4e4Un Tb5ShJNU6gJYFt8QPCbgN53OQUO/cww= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-T0J-9s0KOl-cS7EQFkCEmw-1; Fri, 31 Oct 2025 10:35:45 -0400 X-MC-Unique: T0J-9s0KOl-cS7EQFkCEmw-1 X-Mimecast-MFC-AGG-ID: T0J-9s0KOl-cS7EQFkCEmw_1761921344 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1E51D180066C; Fri, 31 Oct 2025 14:35:44 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7218B1800579; Fri, 31 Oct 2025 14:35:42 +0000 (UTC) From: Kevin Traynor To: Joshua Washington Cc: Ankit Garg , dpdk stable Subject: patch 'net/gve: add DQO Tx descriptor limit' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:15 +0000 Message-ID: <20251031143421.324432-13-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PWbAGIjP_VQPi1IvIyK8Ik2GnEbsVLzlYAUzAwf5yis_1761921344 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/952398a7b241ed5a32b604a67f6972a33eb3589b Thanks. Kevin --- >From 952398a7b241ed5a32b604a67f6972a33eb3589b Mon Sep 17 00:00:00 2001 From: Joshua Washington Date: Mon, 7 Jul 2025 16:18:09 -0700 Subject: [PATCH] net/gve: add DQO Tx descriptor limit [ upstream commit f4a70b449bfac5343bf498f4132d5b8da4b0a885 ] The hardware supports at most 10 data descriptors per MTU-sized segment. GVE_TX_MAX_DATA_DESCS was defined in the initial implmenentation, but the descriptor limit was never actually enforced. Fixes: 4022f9999f56 ("net/gve: support basic Tx data path for DQO") Signed-off-by: Joshua Washington Reviewed-by: Ankit Garg --- drivers/net/gve/gve_ethdev.c | 1 + drivers/net/gve/gve_ethdev.h | 1 + drivers/net/gve/gve_tx_dqo.c | 6 ++++++ 3 files changed, 8 insertions(+) diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c index e471a34e61..5be4f64fde 100644 --- a/drivers/net/gve/gve_ethdev.c +++ b/drivers/net/gve/gve_ethdev.c @@ -604,4 +604,5 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) .nb_min = priv->min_tx_desc_cnt, .nb_align = 1, + .nb_mtu_seg_max = GVE_TX_MAX_DATA_DESCS, }; diff --git a/drivers/net/gve/gve_ethdev.h b/drivers/net/gve/gve_ethdev.h index 35cb9062b1..195dadc4d4 100644 --- a/drivers/net/gve/gve_ethdev.h +++ b/drivers/net/gve/gve_ethdev.h @@ -103,4 +103,5 @@ struct gve_tx_stats { uint64_t bytes; uint64_t errors; + uint64_t too_many_descs; }; diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c index 7e03e75b20..27f98cdeb3 100644 --- a/drivers/net/gve/gve_tx_dqo.c +++ b/drivers/net/gve/gve_tx_dqo.c @@ -166,4 +166,10 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) } + /* Drop packet if it doesn't adhere to hardware limits. */ + if (!tso && nb_descs > GVE_TX_MAX_DATA_DESCS) { + txq->stats.too_many_descs++; + break; + } + if (tso) { txd = &txr[tx_id]; -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:52.686450388 +0000 +++ 0013-net-gve-add-DQO-Tx-descriptor-limit.patch 2025-10-31 13:53:52.019523315 +0000 @@ -1 +1 @@ -From f4a70b449bfac5343bf498f4132d5b8da4b0a885 Mon Sep 17 00:00:00 2001 +From 952398a7b241ed5a32b604a67f6972a33eb3589b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f4a70b449bfac5343bf498f4132d5b8da4b0a885 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index bdb7f1d075..81325ba98c 100644 +index e471a34e61..5be4f64fde 100644