From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18F6348A44 for ; Fri, 31 Oct 2025 15:40:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1202440150; Fri, 31 Oct 2025 15:40:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3B6A040653 for ; Fri, 31 Oct 2025 15:40:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+NUYn1aHGjWtKmd0F59/4cv89UzuYJfeUfV9/9GVKKU=; b=YUOmmwqjED4esN/vRPmc99KKPxaPl4KrQmhNdBbwnMEsITbQneH9LfP6SZPLfKVVZQT+ik nZbeJxA+ELe7iX2sYytm/cqy3EwQ6TUVNPmzuxDodD+pgimQAUcnQVJ0W+NuVJSIcN1OMp 3yMNBFJJprUlF2/SrFinUBE6gemQm08= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-C60cVh-CO1aCUHBOnWdPkg-1; Fri, 31 Oct 2025 10:40:25 -0400 X-MC-Unique: C60cVh-CO1aCUHBOnWdPkg-1 X-Mimecast-MFC-AGG-ID: C60cVh-CO1aCUHBOnWdPkg_1761921624 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2A57A1955E7C; Fri, 31 Oct 2025 14:40:23 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F3BE91800579; Fri, 31 Oct 2025 14:40:20 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Bruce Richardson , Marat Khalili , Chengwen Feng , dpdk stable Subject: patch 'cmdline: fix highest bit port list parsing' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:34:16 +0000 Message-ID: <20251031143421.324432-134-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Wkxw5syXyxqDpJcl5t1ueHC7wGp1sxOr4KpEFuUA_wg_1761921624 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/72c21546e14bbb63ca9e128cc4e4e6542b1866ab Thanks. Kevin --- >From 72c21546e14bbb63ca9e128cc4e4e6542b1866ab Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 3 Feb 2025 13:50:48 +0100 Subject: [PATCH] cmdline: fix highest bit port list parsing [ upstream commit f3a07a33d7b3a0b153f7f5b60c13bebede9a9104 ] pl->map is a uint32_t. Caught by UBSan: ../lib/cmdline/cmdline_parse_portlist.c:27:17: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../lib/cmdline/cmdline_parse_portlist.c:27:17 in Fixes: af75078fece3 ("first public release") Signed-off-by: David Marchand Acked-by: Bruce Richardson Reviewed-by: Marat Khalili Acked-by: Chengwen Feng --- lib/cmdline/cmdline_parse_portlist.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/cmdline/cmdline_parse_portlist.c b/lib/cmdline/cmdline_parse_portlist.c index 290e61f211..6b7096579e 100644 --- a/lib/cmdline/cmdline_parse_portlist.c +++ b/lib/cmdline/cmdline_parse_portlist.c @@ -10,5 +10,7 @@ #include +#include #include + #include "cmdline_parse.h" #include "cmdline_parse_portlist.h" @@ -25,5 +27,6 @@ parse_set_list(cmdline_portlist_t *pl, size_t low, size_t high) { do { - pl->map |= (1 << low++); + pl->map |= RTE_BIT32(low); + low++; } while (low <= high); } -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:56.234650988 +0000 +++ 0134-cmdline-fix-highest-bit-port-list-parsing.patch 2025-10-31 13:53:52.328964874 +0000 @@ -1 +1 @@ -From f3a07a33d7b3a0b153f7f5b60c13bebede9a9104 Mon Sep 17 00:00:00 2001 +From 72c21546e14bbb63ca9e128cc4e4e6542b1866ab Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f3a07a33d7b3a0b153f7f5b60c13bebede9a9104 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 549f6d9671..3efe4143e3 100644 +index 290e61f211..6b7096579e 100644 @@ -30 +31,2 @@ -@@ -11,5 +11,7 @@ +@@ -10,5 +10,7 @@ + #include @@ -32 +33,0 @@ - #include @@ -38 +39 @@ -@@ -27,5 +29,6 @@ parse_set_list(cmdline_portlist_t *pl, size_t low, size_t high) +@@ -25,5 +27,6 @@ parse_set_list(cmdline_portlist_t *pl, size_t low, size_t high)