From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EA1D48A44 for ; Fri, 31 Oct 2025 15:35:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7762A40655; Fri, 31 Oct 2025 15:35:52 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9904740668 for ; Fri, 31 Oct 2025 15:35:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=twZ9/gpqPopXlnf+T9CC77NIaDI46R1la3XxcKfD8ps=; b=GT64zGRsoL/2FKKXAoVt2YindameeKDVYZA7c0d0oShzs4p7T4LAg7PV5v/SOpZnDu8rv6 PJAaNlKF0qaWY0xnR5uUQVmXc6sb6t/lqpGtj5wxDb+OCOY7octUD6mqYUK+DL0GgDUKfA anCmtGD8M/+YWkv2kGvwWPMxvCGyrCg= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-AqJ0ZofKNUuBmdznvuFEAg-1; Fri, 31 Oct 2025 10:35:49 -0400 X-MC-Unique: AqJ0ZofKNUuBmdznvuFEAg-1 X-Mimecast-MFC-AGG-ID: AqJ0ZofKNUuBmdznvuFEAg_1761921348 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 99DA21809A02; Fri, 31 Oct 2025 14:35:48 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1275F18004D4; Fri, 31 Oct 2025 14:35:46 +0000 (UTC) From: Kevin Traynor To: Joshua Washington Cc: Ankit Garg , dpdk stable Subject: patch 'net/gve: clear DQO Tx descriptors before writing' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:17 +0000 Message-ID: <20251031143421.324432-15-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IttQG3bx4rhnr5AVQIN0bVlVbPGyvVIexaiK41M9UKQ_1761921348 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/53ca02042d547407982e7dd5fdd2e980e75da1df Thanks. Kevin --- >From 53ca02042d547407982e7dd5fdd2e980e75da1df Mon Sep 17 00:00:00 2001 From: Joshua Washington Date: Mon, 7 Jul 2025 16:18:11 -0700 Subject: [PATCH] net/gve: clear DQO Tx descriptors before writing [ upstream commit 4ef9cf43d0ee57e082cb9e89f47756f3414171a4 ] When TSO was introduced, it became possible for two differing descriptor formats to be written to the descriptor ring, GVE_TX_PKT_DESC_DTYPE_DQO and GVE_TX_TSO_CTX_DESC_DTYPE_DQO. Because these descriptor types have different formats, they end up setting different fields, which can be misinterpreted by the hardware if not fully cleared. Fixes: 403c671a46b6 ("net/gve: support TSO in DQO RDA") Signed-off-by: Joshua Washington Reviewed-by: Ankit Garg --- drivers/net/gve/gve_tx_dqo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c index 3befbbcacb..169c40d5b0 100644 --- a/drivers/net/gve/gve_tx_dqo.c +++ b/drivers/net/gve/gve_tx_dqo.c @@ -160,4 +160,6 @@ gve_tx_fill_seg_desc_dqo(volatile union gve_tx_desc_dqo *desc, struct rte_mbuf * { uint32_t hlen = tx_pkt->l2_len + tx_pkt->l3_len + tx_pkt->l4_len; + + desc->tso_ctx = (struct gve_tx_tso_context_desc_dqo) {}; desc->tso_ctx.cmd_dtype.dtype = GVE_TX_TSO_CTX_DESC_DTYPE_DQO; desc->tso_ctx.cmd_dtype.tso = 1; @@ -258,4 +260,5 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) txd = &txr[tx_id]; + txd->pkt = (struct gve_tx_pkt_desc_dqo) {}; txd->pkt.buf_addr = rte_cpu_to_le_64(buf_addr); txd->pkt.compl_tag = rte_cpu_to_le_16(first_sw_id); -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:52.741001992 +0000 +++ 0015-net-gve-clear-DQO-Tx-descriptors-before-writing.patch 2025-10-31 13:53:52.022523324 +0000 @@ -1 +1 @@ -From 4ef9cf43d0ee57e082cb9e89f47756f3414171a4 Mon Sep 17 00:00:00 2001 +From 53ca02042d547407982e7dd5fdd2e980e75da1df Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4ef9cf43d0ee57e082cb9e89f47756f3414171a4 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org