From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5872748A44 for ; Fri, 31 Oct 2025 15:36:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5266040150; Fri, 31 Oct 2025 15:36:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 84E3B4066C for ; Fri, 31 Oct 2025 15:36:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761921370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8r/Q+FtJA3SD7XRz14I5H2iAnYQUeNs955ZQ/TVxrD4=; b=di0zlTzOEoVTkZQ+KU7aR5CHjqe92LoVoxYzPCvGhuOXkcUkyBFOBnp56KYg5xZgDsL9PN /vJ+cn6+6R7yIXogIYJF50hJNev1K9j/71LvH14L5Qf8a6J58B9oLRPQjhtAIBsrjs5uau Cm6vnxuNgVVxbH0uUIQjx+mqkULES/c= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-hQe8HX29Ozyr6kI-kxOirw-1; Fri, 31 Oct 2025 10:36:06 -0400 X-MC-Unique: hQe8HX29Ozyr6kI-kxOirw-1 X-Mimecast-MFC-AGG-ID: hQe8HX29Ozyr6kI-kxOirw_1761921365 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CBDA2195609F; Fri, 31 Oct 2025 14:36:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.44.32.50]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0403B18004D4; Fri, 31 Oct 2025 14:36:03 +0000 (UTC) From: Kevin Traynor To: Maayan Kashani Cc: Dariusz Sosnowski , dpdk stable Subject: patch 'app/testpmd: fix mask in flow random item' has been queued to stable release 24.11.4 Date: Fri, 31 Oct 2025 14:32:25 +0000 Message-ID: <20251031143421.324432-23-ktraynor@redhat.com> In-Reply-To: <20251031143421.324432-1-ktraynor@redhat.com> References: <20251031143421.324432-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: l8gcOt6rzI1oFOY38B2VXxetE2xhi6q_WFwmEJRMe-Y_1761921365 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/05/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/6bc6f0786b0346521dea67fcb3e03b45ba70d054 Thanks. Kevin --- >From 6bc6f0786b0346521dea67fcb3e03b45ba70d054 Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Wed, 30 Jul 2025 14:32:43 +0300 Subject: [PATCH] app/testpmd: fix mask in flow random item [ upstream commit e3054b2f402f52c744344a4ec2a17ff1eb47f8e0 ] A previous patch addressing an ASAN global-buffer-overflow issue inadvertently degraded the random mask value translation. Specifically, changing the mask from 0xffff to 0x0000ffff caused the value to be shifted left by 16 bits, since Testpmd defines arg::mask as a byte array. Independent of the ASAN fix, the random item mask specification was invalid at the API level: random items require a 32-bit mask, but only a 16-bit mask was being used. The correct mask for this use case is 0xffffffff. This fix restores the correct random value translation by applying the proper 32-bit mask and addresses the original ASAN issue. Fixes: 9a18070e3fe4 ("app/testpmd: fix flow random item token") Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index eb26333759..c5ae8300d6 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -5583,5 +5583,5 @@ static const struct token token_list[] = { item_param), .args = ARGS(ARGS_ENTRY_MASK(struct rte_flow_item_random, - value, "\x00\x00\xff\xff")), + value, "\xff\xff\xff\xff")), }, [ITEM_GRE_KEY] = { -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-10-31 13:53:52.978476792 +0000 +++ 0023-app-testpmd-fix-mask-in-flow-random-item.patch 2025-10-31 13:53:52.048523406 +0000 @@ -1 +1 @@ -From e3054b2f402f52c744344a4ec2a17ff1eb47f8e0 Mon Sep 17 00:00:00 2001 +From 6bc6f0786b0346521dea67fcb3e03b45ba70d054 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e3054b2f402f52c744344a4ec2a17ff1eb47f8e0 ] + @@ -22 +23,0 @@ -Cc: stable@dpdk.org @@ -31 +32 @@ -index 83d398f8ee..38e751f3f3 100644 +index eb26333759..c5ae8300d6 100644 @@ -34 +35 @@ -@@ -5592,5 +5592,5 @@ static const struct token token_list[] = { +@@ -5583,5 +5583,5 @@ static const struct token token_list[] = {